From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC2D9C433E0 for ; Fri, 12 Jun 2020 13:00:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DA8420801 for ; Fri, 12 Jun 2020 13:00:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nxuDZ6SB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="zjGYScyO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DA8420801 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gzb+ChurLcNf3LLNL4fkqsWZmfEiPeWw6FyIayKdPgA=; b=nxuDZ6SBZQGrxpZu8B5yTN2C1 b4HXdzYKpynf1npo/OgKs+T7jmfbnTtHemWIkPkJdKpPJiNf/37WuBbzNJm6jo0G4g3UA4j98Ez0f 5Zj1f4meL1scY29nuTAlfO3LcT+a0RNG48KHgkYKx5A0DuYaC9pJS952k4Dx/24DpfGH0jH9/wlTw gcqTgEPWx7sYfdTmx/QErJzVmVpaCXbayc+9/+a+uVVWk0jSiN3oovsHm+zt9rNcu80toVxTCA8AD siQq5iHjvbDlMAufzhUXKwuvXBz6Il3eUwbJxeURZ/63XXt0IdZfxlmy+L7mUJFdaYhSHcvMdouAu jyFHM4eRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjjI5-0003jj-Ga; Fri, 12 Jun 2020 13:00:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjjI0-0002eN-LW for linux-arm-kernel@lists.infradead.org; Fri, 12 Jun 2020 13:00:10 +0000 Received: from localhost (p54b33104.dip0.t-ipconnect.de [84.179.49.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 228A520801; Fri, 12 Jun 2020 13:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591966806; bh=p9zdw6Ix408GDSOOW0UAhlBPPpxUZXF56TDRkRrBo50=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zjGYScyOOsAy3gVeFKrd5vkNkraV2RnlZRh01K85GpQCvcot6I/QFrzcOqyNfKGkI 6G4HIXXSnYdkiTLXeyhxcv+bm0QFVYyWnMWwBEZBRVE6hDKqa3YcDKjdDzqW4b6z7y GCptfpJ3oBZpi1ggPlzNz6s/wNWA81iJEkjSk+IQ= Date: Fri, 12 Jun 2020 15:00:03 +0200 From: Wolfram Sang To: Marc Kleine-Budde Subject: Re: [PATCH] i2c: imx: Fix external abort on early interrupt Message-ID: <20200612130003.GB18557@ninjato> References: <1591796802-23504-1-git-send-email-krzk@kernel.org> <20200612090517.GA3030@ninjato> <20200612092941.GA25990@pi3> <20200612095604.GA17763@ninjato> <20200612102113.GA26056@pi3> <20200612103149.2onoflu5qgwaooli@pengutronix.de> <20200612103949.GB26056@pi3> <20200612115116.GA18557@ninjato> <859e8211-2c56-8dd5-d6fb-33e4358e4128@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <859e8211-2c56-8dd5-d6fb-33e4358e4128@pengutronix.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200612_060008_785335_4B41C584 X-CRM114-Status: GOOD ( 10.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Oleksij Rempel , linux-i2c@vger.kernel.org, Oleksij Rempel , Krzysztof Kozlowski , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org, NXP Linux Team Content-Type: multipart/mixed; boundary="===============0801341133575100292==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0801341133575100292== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WYTEVAkct0FjGQmd" Content-Disposition: inline --WYTEVAkct0FjGQmd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 12, 2020 at 02:18:06PM +0200, Marc Kleine-Budde wrote: > On 6/12/20 1:51 PM, Wolfram Sang wrote: > >=20 > >> This basically kills the concept of devm for interrupts. Some other > >=20 > > It only works when you can ensure you have all interrupts disabled (and > > none pending) in remove() or the error paths of probe() etc. >=20 > But when requesting the interrupt as shared the interrupt handler can get= called > any time, even if you have disabled the IRQ source in your IP core....The= shared > IRQ debug code tests this. Yes, so you'd need something like if (clks_are_off) return IRQ_NONE; or skip devm_ for interrupts and handle it manually. (IIRC the input subsystem really frowns upon devm + irqs for such reasons) D'accord? --WYTEVAkct0FjGQmd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl7jfE8ACgkQFA3kzBSg KbYU2g//YH252FclavZQfOCs9H4QzD8SUrVlAuUOYIo2XLzjN9/S+n1K4LakWCz8 J6zxoyCp/gTkEqkY1Y0vyvgPCGlO49Cy4DCNgUDEz9fHP1hK5d6QTb9DZS62qGe0 mvVSm+21eLSHPO0H2v6pT+eP8bhQUiHIEWs8yxTSbI1QM8VysbSFJXx3rgwSb7s5 Os5hOy6/4O5rn9StieglVEZ2CNl0ZoAqpvOHPziGkhlYB6XzfLRLjYY+9tDOcM+d Eza2rjTYPrm3v1nqsbNz3/44PVjgyMMwuHehVllaSVfkCsAUiBCnnmwZXNr1N4oT c4MNBQAInQw0jqDesVX+Y+YTbaa8McEZFs6giB6C6wb+Cg3Y+dILxtFdtZO6zg5+ RTEPjFl+pOUwqj8CwxQ3DPJPpxnKTssp/+lnVNMmFxqAqjk5Xf9xHRIYlexPi9Ai GJfwOLCo5sOjAnCqFG8n6PYdyCDbmzmBw58rqlL5MKEKzAchbbwKQVLiVgBthVw3 7lj2JUWrPEBUVMMO7DGulNaz0mvfXhRoNfbyTp373rcN03kRLQoNFHSYIZTBLg+f Z4JVGFjSK8Thf/0kFMWKakmmRvW5u0isnMwSbPIE4cuL6tdkrLadPpPYlscPL+wt 3dqTVphas2XIcGTH4/PLXQj1uZnxFU12ST1WP0TBZXY77Ydvw1E= =key/ -----END PGP SIGNATURE----- --WYTEVAkct0FjGQmd-- --===============0801341133575100292== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0801341133575100292==--