From: Wolfram Sang <wsa@kernel.org>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Andy Duan <fugang.duan@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
"kjlu@umn.edu" <kjlu@umn.edu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Markus Elfring <Markus.Elfring@web.de>,
dl-linux-imx <linux-imx@nxp.com>,
Dinghao Liu <dinghao.liu@zju.edu.cn>,
Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error
Date: Mon, 15 Jun 2020 09:06:13 +0200 [thread overview]
Message-ID: <20200615070613.GA1497@kunai> (raw)
In-Reply-To: <AM6PR04MB4966A1FD80A29BA1E63247C0809C0@AM6PR04MB4966.eurprd04.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 851 bytes --]
On Mon, Jun 15, 2020 at 06:33:40AM +0000, Aisheng Dong wrote:
> > From: Wolfram Sang <wsa@kernel.org>
> > Sent: Sunday, June 14, 2020 5:12 PM
> >
> > On Mon, Jun 01, 2020 at 02:16:40PM +0800, Dinghao Liu wrote:
> > > pm_runtime_get_sync() increments the runtime PM usage counter even the
> > > call returns an error code. Thus a corresponding decrement is needed
> > > on the error handling path to keep the counter balanced.
> >
> > Can you point me to a discussion where it was decided that this is a proper fix?
> > I'd think we rather should fix pm_runtime_get_sync() but maybe there are
> > technical reasons against it.
>
> I had the same feeling.
> Copy pm guys to comments.
I started a seperate thread:
https://lkml.org/lkml/2020/6/14/76
Still, on-going discussion if the proper fix is to remove the error
check.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-15 7:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 6:16 [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error Dinghao Liu
2020-06-01 6:24 ` [EXT] " Andy Duan
2020-06-01 6:42 ` [PATCH v3] i2c: imx-lpi2c: Fix runtime PM imbalance in lpi2c_imx_master_enable() Markus Elfring
2020-06-14 9:12 ` [PATCH] [v3] i2c: imx-lpi2c: Fix runtime PM imbalance on error Wolfram Sang
2020-06-14 12:08 ` dinghao.liu
2020-06-15 6:33 ` Aisheng Dong
2020-06-15 7:06 ` Wolfram Sang [this message]
2020-06-15 7:40 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615070613.GA1497@kunai \
--to=wsa@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=aisheng.dong@nxp.com \
--cc=dinghao.liu@zju.edu.cn \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kjlu@umn.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).