From: Greg KH <gregkh@linuxfoundation.org>
To: Tamseel Shams <m.shams@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, alim.akhtar@samsung.com,
linux-kernel@vger.kernel.org, krzk@kernel.org, kgene@kernel.org,
linux-serial@vger.kernel.org, jslaby@suse.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC
Date: Mon, 15 Jun 2020 14:50:45 +0200 [thread overview]
Message-ID: <20200615125045.GA946844@kroah.com> (raw)
In-Reply-To: <20200615122609.71884-1-m.shams@samsung.com>
On Mon, Jun 15, 2020 at 05:56:09PM +0530, Tamseel Shams wrote:
> In few older Samsung SoCs like s3c2410, s3c2412
> and s3c2440, UART IP is having 2 interrupt lines.
> However, in other SoCs like s3c6400, s5pv210,
> exynos5433, and exynos4210 UART is having only 1
> interrupt line. Due to this, "platform_get_irq(platdev, 1)"
> call in the driver gives the following warning:
> "IRQ index 1 not found" on recent platforms.
>
> This patch re-factors the IRQ resources handling for
> each platform and hence fixing the above warnings seen
> on some platforms.
>
> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> ---
> drivers/tty/serial/samsung_tty.c | 20 ++++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
RFC means "I do not trust this so I don't want anyone to merge it", so
I'll just delete it from my queue and wait for you to come up with
something that you feel confident with :)
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-15 12:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200615124355epcas5p446ae2f1b63331ef87334cd7d696c3c43@epcas5p4.samsung.com>
2020-06-15 12:26 ` [RFC PATCH] serial: samsung: Re-factors UART IRQ resource for various Samsung SoC Tamseel Shams
2020-06-15 12:50 ` Greg KH [this message]
2020-06-17 16:28 ` M Tamseel Shams
2020-06-15 13:13 ` Robin Murphy
2020-06-17 17:08 ` M Tamseel Shams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615125045.GA946844@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alim.akhtar@samsung.com \
--cc=jslaby@suse.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.shams@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).