From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D015C433E0 for ; Mon, 15 Jun 2020 14:43:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B48F20739 for ; Mon, 15 Jun 2020 14:43:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ifu3yUAe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B48F20739 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PfNaebgxehvCvgYUEBxMnC+VyEeDR9id4hSZn8wMVBY=; b=Ifu3yUAeThBNPV FgSnZIbMFqIaVKG4qSPREpU/FxOnSUeF1auTEEFhAPa0PWPRDvmv3GjzYQR4PbaAnNk3kxakxhkj3 tkObyQP2WcXL7SLROZC7pa66F/ULyNclYPpdFwSMWnkKfmVW6a/dDL2PPTjdyTlKWVGecffIOuKdc 6k1C5zjQ2hzaaY2vB3CLEyik8MEi+yMKLpCp8F6E2C3ttVHSQ5yOWx10h9BNTpMv5Mbtz1LM28whS sQeo2Qvf/0ibmQJiCQiHHPtlsGpA2cnoZD2p+MfB8KKYKUbEVcYNfn+9aONcwqNRvqaH5qEu92hW4 Auk2dcuNEuCyYKlB6m4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkqKY-0001Gq-EQ; Mon, 15 Jun 2020 14:43:22 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jkqKQ-00017y-Fw for linux-arm-kernel@lists.infradead.org; Mon, 15 Jun 2020 14:43:16 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id D8AE268AFE; Mon, 15 Jun 2020 16:43:10 +0200 (CEST) Date: Mon, 15 Jun 2020 16:43:10 +0200 From: Christoph Hellwig To: Arnd Bergmann Subject: Re: [PATCH 2/6] exec: simplify the compat syscall handling Message-ID: <20200615144310.GA15101@lst.de> References: <20200615130032.931285-1-hch@lst.de> <20200615130032.931285-3-hch@lst.de> <20200615141239.GA12951@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200615_074314_690727_5E649FEC X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , linux-s390 , Parisc List , the arch/x86 maintainers , "open list:BROADCOM NVRAM DRIVER" , "linux-kernel@vger.kernel.org" , Linux FS-devel Mailing List , Luis Chamberlain , Al Viro , sparclinux , linuxppc-dev , Christoph Hellwig , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 15, 2020 at 04:40:28PM +0200, Arnd Bergmann wrote: > > ld: arch/x86/entry/syscall_x32.o:(.rodata+0x1040): undefined reference to > > `__x32_sys_execve' > > ld: arch/x86/entry/syscall_x32.o:(.rodata+0x1108): undefined reference to > > `__x32_sys_execveat' > > make: *** [Makefile:1139: vmlinux] Error 1 > > Ah, I see: it's marked x32-only, so arch/x86/entry/syscall_x32.c > uses the __x32 prefix instead of the __x64 one. Marking it 'common' > instead would make it work, but also create an extra entry point > for native processes, something that commit > 6365b842aae4 ("x86/syscalls: Split the x32 syscalls into their own table") > was trying to avoid. Marking it common also doesn't compile at all because __NR_execve and __NR_execveat get redefined in unistd_64.h. I then tried to rename the x32 versions, which failed in yet another way. At that point I gave up instead of digging myself into a deeper hole.. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel