From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>
Cc: devicetree@vger.kernel.org, jason@lakedaemon.net,
airlied@linux.ie, robh+dt@kernel.org, tomi.valkeinen@ti.com,
dri-devel@lists.freedesktop.org, kernel@collabora.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: make the ports node optional
Date: Tue, 16 Jun 2020 04:51:19 +0300 [thread overview]
Message-ID: <20200616015119.GI1629@pendragon.ideasonboard.com> (raw)
In-Reply-To: <8ad9a397a5fa6cebd2a4e0170dfa96ad73907faf.camel@collabora.com>
Hi Ricardo,
On Mon, Jun 15, 2020 at 11:38:07AM +0200, Ricardo Cañuelo wrote:
> On Thu, 2020-06-11 at 19:08 +0300, Laurent Pinchart wrote:
> > On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote:
> > > Make the ports node optional, since there are some DTs that don't define
> > > any ports for ti,tfp410.
> > >
> > > Signed-off-by: Ricardo Cañuelo <ricardo.canuelo@collabora.com>
> >
> > Shouldn't we fix those DTs instead ? What's the point of a TFP410
> > without ports in DT ?
>
> This comes from the discussion in the previous version of this series.
>
> In the DTs that don't define any ports (it's dove-sbc-a510.dts only, actually)
> it's not clear how to define the ports (I'm not familiar with this board).
> Initially I defined a set of empty ports just to comply with the binding
> requirements, but Rob suggested that we might as well declare them as optional,
> since having an empty port definition with no remote endpoints is no better than
> having no ports at all.
>
> I understand both opinions but I just don't know which is the best option at
> this point.
How about keeping the ports mandatory, and leaving dove-sbc-a510.dts to
be fixed later ?
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-16 1:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 10:23 [PATCH v3 0/5] dt-bindings: display: ti,tfp410.txt: convert to yaml Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 1/5] " Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 2/5] dt-bindings: display: ti, tfp410.yaml: Redefine ti, deskew property Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 3/5] drm/bridge: tfp410: fix de-skew value retrieval from DT Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 4/5] drm/bridge: tfp410: Fix setup and hold time calculation Ricardo Cañuelo
2020-06-11 10:23 ` [PATCH v3 5/5] dt-bindings: display: ti, tfp410.yaml: make the ports node optional Ricardo Cañuelo
2020-06-11 16:08 ` [PATCH v3 5/5] dt-bindings: display: ti,tfp410.yaml: " Laurent Pinchart
2020-06-15 9:38 ` Ricardo Cañuelo
2020-06-16 1:51 ` Laurent Pinchart [this message]
2020-06-16 6:42 ` Ricardo Cañuelo
2020-06-17 22:37 ` Rob Herring
2020-06-17 22:34 ` Rob Herring
2020-06-17 22:43 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616015119.GI1629@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason@lakedaemon.net \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ricardo.canuelo@collabora.com \
--cc=robh+dt@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).