From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F91AC433DF for ; Tue, 16 Jun 2020 10:00:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F023320767 for ; Tue, 16 Jun 2020 10:00:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tqdfhJLb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="s35iCxf2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F023320767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NsVxKm5a0iVOTC66NPheP2ZlSEAGKADh6qRPPqFdX/0=; b=tqdfhJLbvoJplvUyprDrneBJx PsiCi8rFLrs61czdR9y7znHpkTf1U3aYiTq/7p11wZZx48hNHmaLFImcd500oh+HpG+QRJNfjXEA7 7lKvKvWjn+rpjqDVHB4yjEAC36FazXYaRounGufhVpCYdU46urAQCQm/ZjP8e0/XVHLbgRzu6SIxj N6qDO3SLgHu7JPCDCR5FlwHyxLkeJAjIOWRxzcKh0HhXMLJnm5WAQMnhgG3EzF/F8eOG436EYLa2S 46Mcu5V/qtk73PHFqx5aDqlg5iFA/zH2aNNOXEWwrdPXEEtwxQKWaq4V4IdVm45vK53tPnd1nGubI HOkUog+og==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jl8Nl-0000iv-N6; Tue, 16 Jun 2020 09:59:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jl8Nj-0000iX-6m for linux-arm-kernel@lists.infradead.org; Tue, 16 Jun 2020 09:59:52 +0000 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CA0720767; Tue, 16 Jun 2020 09:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592301590; bh=H00RGJq5KezVcrQ/vGzLRXHsGQa2G3LnLHyCG7559QU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s35iCxf2ApOcJZGyTnKb4vFHqFOY/SexyqbRTgxWkYLnGAD85dUn2XN6AYZkK4Yms bl62nwah75Ax2duvcU+bVe2CmlysoY32l9chot9A7Qr1u4UA5fiP/m2ZlZQO/ik3av tMj/TY1ARiyudeRqXH3l8XqEFpJspJfUFi6ej97w= Date: Tue, 16 Jun 2020 10:59:48 +0100 From: Mark Brown To: Robin Gong Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio Message-ID: <20200616095948.GJ4447@sirena.org.uk> References: <20200612141611.GI5396@sirena.org.uk> <20200615123553.GP4447@sirena.org.uk> <20200615133905.GV4447@sirena.org.uk> <20200615143622.GX4447@sirena.org.uk> <20200615145556.GY4447@sirena.org.uk> MIME-Version: 1.0 In-Reply-To: X-Cookie: Offer may end without notice. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200616_025951_269211_F7A1E422 X-CRM114-Status: UNSURE ( 8.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "matthias.schiffer@ew.tq-group.com" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , "robin.murphy@arm.com" , "linux-spi@vger.kernel.org" , Vinod Koul , dl-linux-imx , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-arm-kernel@lists.infradead.org" Content-Type: multipart/mixed; boundary="===============3108385117953840908==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============3108385117953840908== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6xTM0kUsJcaNctaW" Content-Disposition: inline --6xTM0kUsJcaNctaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 16, 2020 at 02:03:40AM +0000, Robin Gong wrote: > On 2020/06/15 22:56 Mark Brown wrote:=20 > struct list_head transfer_list; > + > +#define SPI_TRANS_DMA_PREP_FAIL BIT(3) /* prepare dma failed */ > + u16 flags; I'd just make this a generic flag for failures before we start interacting with the hardware rather than specifically this one error case. Otherwise this looks fine. --6xTM0kUsJcaNctaW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7omBMACgkQJNaLcl1U h9CvpQf+Nxs8GAzGWD8q5WQ5Yfk5Dd+UDwg0tf7+zdTr05h6hiN4THe7qjTZBk6+ MC0R19TGfmpOaqHJY8nh3Nr2HY2QUv+ceTtIYVmwxpG+oE9TTE1v5WQTzOTQ5HMV yq8qU6g8Tfa1uB6BLAchJMy2lBvU/mjNqRnDY4ONnr5qkrmmKgQZycDnilH3ICEy VVS2cenoNIUooeyGwBCFOO8GnxfPhYtO3P5CLZvFPmg6OEdq0qIbluxYksdknKiR cBMORkKWR3BEZwuCx2R6xjUk17zxIpc5Km7XmjrZXSSitzONPcMjcaqVq4mtuNAU 5hztHr9mzDtIlWqoD8uLxSczu7wlVg== =AZSa -----END PGP SIGNATURE----- --6xTM0kUsJcaNctaW-- --===============3108385117953840908== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============3108385117953840908==--