From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53635C433E0 for ; Tue, 16 Jun 2020 11:03:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E8CC9207C4 for ; Tue, 16 Jun 2020 11:03:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NExfIg3Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E8CC9207C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cl+ED2zZvVCUywOEdbNnalXVkOqsGhBmQDwqVwQ4Hf4=; b=NExfIg3ZQnwhX/ 1MvPofsn4w6zarCh4sv3Ze+cGsgEc1xZNCQx0E7Mw5/bgW0R3vjE8R/d7YWq4NNQ2stKHzlLAUw0P g/OFKwj6iuDAVWpsXL2Ot4mFvzIalJ0hFfFjJ1NQ3VVZ8XuFslkEegjcvE90z+pQKUqDCLuaGxrVR 87W9XcGB9dX8GwN1x+xONf7sMCbR3li03ROa7gmH4dOhG3Jwn/6t9eISIY3+VLg2aiA4gwMVCh1tS FJHgvSNfcuISZd+rhSsdHb51/t3LhkGhhZ7N1cXNIa3HZCcMvY6C7otQFNqPaqP34bLoEz+pI5EAt PzCuAO2WsqQQD5mErD2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jl9NQ-0002Ka-9q; Tue, 16 Jun 2020 11:03:36 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jl9NO-0002K4-81; Tue, 16 Jun 2020 11:03:35 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 0D7FF1C0C0A; Tue, 16 Jun 2020 13:03:33 +0200 (CEST) Date: Tue, 16 Jun 2020 13:03:25 +0200 From: Pavel Machek To: Fengping Yu Subject: Re: [PATCH v1 2/3] drivers: input: misc: Add mtk vibrator driver Message-ID: <20200616110325.GL1718@bug> References: <20200615114203.116656-1-fengping.yu@mediatek.com> <20200615114203.116656-3-fengping.yu@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200615114203.116656-3-fengping.yu@mediatek.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200616_040334_433607_A1AE80EA X-CRM114-Status: GOOD ( 12.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Dmitry Torokhov , linux-mediatek@lists.infradead.org, Jacek Anaszewski , linux-input@vger.kernel.org, Matthias Brugger , Yingjoe Chen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 2020-06-15 19:42:04, Fengping Yu wrote: > From: "fengping.yu" > > This adds regulator vibrator driver for Mediatek SoCs. > > Signed-off-by: fengping.yu > --- > drivers/input/misc/Kconfig | 10 + > drivers/input/misc/Makefile | 1 + > drivers/input/misc/regulator-vibrator.c | 422 ++++++++++++++++++++++++ > 3 files changed, 433 insertions(+) > create mode 100644 drivers/input/misc/regulator-vibrator.c > > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > index 7e2e658d551c..71a0dd7a5271 100644 > --- a/drivers/input/misc/Kconfig > +++ b/drivers/input/misc/Kconfig > @@ -459,6 +459,16 @@ config INPUT_REGULATOR_HAPTIC > To compile this driver as a module, choose M here: the > module will be called regulator-haptic. > > +config INPUT_REGULATOR_VIBRATOR Can you look at input_regulator_haptic, and explain why you need separate driver? Pavel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel