From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Mike Leach <mike.leach@linaro.org>
Cc: mathieu.poirier@linaro.org, suzuki.poulose@arm.com,
peterz@infradead.org, coresight@lists.linaro.org,
mingo@redhat.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5] perf: cs-etm: Allow no CoreSight sink to be specified on command line
Date: Tue, 16 Jun 2020 16:43:55 -0300 [thread overview]
Message-ID: <20200616194355.GA31667@kernel.org> (raw)
In-Reply-To: <20200616164041.15373-1-mike.leach@linaro.org>
Em Tue, Jun 16, 2020 at 05:40:41PM +0100, Mike Leach escreveu:
> Adjust the handling of the session sink selection to allow no sink to
> be selected on the command line. This then forwards the sink selection to
> the CoreSight infrastructure which will attempt to select a sink based
> on the default sink select priorities.
>
> Signed-off-by: Mike Leach <mike.leach@linaro.org>
> Tested-by: Leo Yan <leo.yan@linaro.org>
Thanks, applied.
- Arnaldo
> ---
> tools/perf/arch/arm/util/cs-etm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c
> index cea5e33d61d2..cad7bf783413 100644
> --- a/tools/perf/arch/arm/util/cs-etm.c
> +++ b/tools/perf/arch/arm/util/cs-etm.c
> @@ -243,10 +243,10 @@ static int cs_etm_set_sink_attr(struct perf_pmu *pmu,
> }
>
> /*
> - * No sink was provided on the command line - for _now_ treat
> - * this as an error.
> + * No sink was provided on the command line - allow the CoreSight
> + * system to look for a default
> */
> - return ret;
> + return 0;
> }
>
> static int cs_etm_recording_options(struct auxtrace_record *itr,
> --
> 2.17.1
>
--
- Arnaldo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-06-16 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 16:40 [PATCH v5] perf: cs-etm: Allow no CoreSight sink to be specified on command line Mike Leach
2020-06-16 19:43 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200616194355.GA31667@kernel.org \
--to=acme@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).