linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mm-beacon: Fix voltages on LDO1 and LDO2
@ 2020-05-26 17:09 Adam Ford
  2020-05-26 17:43 ` Daniel Baluta
  0 siblings, 1 reply; 3+ messages in thread
From: Adam Ford @ 2020-05-26 17:09 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: devicetree, Fabio Estevam, Adam Ford, Sascha Hauer, aford,
	linux-kernel, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo

LDO1 and LDO2 settings are wrong and case the voltage to go above the
maximum level of 2.15V permitted by the SoC to 3.0V.

This patch is based on work done on the i.MX8M Mini-EVK which utilizes
the same fix.

Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
index fb0137a8611c..94911b1707ef 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
@@ -136,7 +136,7 @@
 
 			ldo1_reg: LDO1 {
 				regulator-name = "LDO1";
-				regulator-min-microvolt = <3000000>;
+				regulator-min-microvolt = <1600000>;
 				regulator-max-microvolt = <3300000>;
 				regulator-boot-on;
 				regulator-always-on;
@@ -144,7 +144,7 @@
 
 			ldo2_reg: LDO2 {
 				regulator-name = "LDO2";
-				regulator-min-microvolt = <900000>;
+				regulator-min-microvolt = <800000>;
 				regulator-max-microvolt = <900000>;
 				regulator-boot-on;
 				regulator-always-on;
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mm-beacon: Fix voltages on LDO1 and LDO2
  2020-05-26 17:09 [PATCH] arm64: dts: imx8mm-beacon: Fix voltages on LDO1 and LDO2 Adam Ford
@ 2020-05-26 17:43 ` Daniel Baluta
  2020-06-18 14:35   ` Shawn Guo
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Baluta @ 2020-05-26 17:43 UTC (permalink / raw)
  To: Adam Ford
  Cc: Devicetree List, Fabio Estevam, Sascha Hauer, aford,
	Linux Kernel Mailing List, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Shawn Guo, linux-arm-kernel

On Tue, May 26, 2020 at 8:11 PM Adam Ford <aford173@gmail.com> wrote:
>
> LDO1 and LDO2 settings are wrong and case the voltage to go above the
> maximum level of 2.15V permitted by the SoC to 3.0V.
>
> This patch is based on work done on the i.MX8M Mini-EVK which utilizes
> the same fix.
>
> Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
No need for a new line between fixes and signed-off-by.

With that:

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: imx8mm-beacon: Fix voltages on LDO1 and LDO2
  2020-05-26 17:43 ` Daniel Baluta
@ 2020-06-18 14:35   ` Shawn Guo
  0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2020-06-18 14:35 UTC (permalink / raw)
  To: Daniel Baluta
  Cc: Devicetree List, Fabio Estevam, Sascha Hauer, aford,
	Linux Kernel Mailing List, Rob Herring, NXP Linux Team,
	Pengutronix Kernel Team, Adam Ford, linux-arm-kernel

On Tue, May 26, 2020 at 08:43:24PM +0300, Daniel Baluta wrote:
> On Tue, May 26, 2020 at 8:11 PM Adam Ford <aford173@gmail.com> wrote:
> >
> > LDO1 and LDO2 settings are wrong and case the voltage to go above the
> > maximum level of 2.15V permitted by the SoC to 3.0V.
> >
> > This patch is based on work done on the i.MX8M Mini-EVK which utilizes
> > the same fix.
> >
> > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> No need for a new line between fixes and signed-off-by.

I fixed it up and applied the patch.

> 
> With that:
> 
> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>

Thanks.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-06-18 14:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-26 17:09 [PATCH] arm64: dts: imx8mm-beacon: Fix voltages on LDO1 and LDO2 Adam Ford
2020-05-26 17:43 ` Daniel Baluta
2020-06-18 14:35   ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).