From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E96C433DF for ; Thu, 18 Jun 2020 18:02:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FCFA207DD for ; Thu, 18 Jun 2020 18:02:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JDmL/MVR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="H3iLz3i6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FCFA207DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HNImS0+RzkJHDjMnWGHntXRZkQCk3UGc9rpvcfrXNbg=; b=JDmL/MVR6BwTBDfEfkvfdzc9G 18Mz3naH3tvrDBu/4hmFu8MJXg+Sgf0UJ2rtI/FhnK14MqkJgujuGr0FEnsMQ/lvvpgcfmyHSxRdk oqBE1ZnJa6Iil7B6o2nJ7fqLGKoDdxzCpbyvHYzIJRL8K0BY/otGxjjR78RMQxEedvBX4qxFCpnhW 8x6CYFROZ2Ar6Hnf2Z6TPFdIa8Pml83wkfcG9eCcRXxLCqz8fIWvKoadmqqKWmaD/tVdeXlmfmkx5 4OUClwDFrEUThAuC7aZZBB2XwVfefDOEyo42T+XkeIIY3cPCnKGtyD0kJ/OWL8h0DVO5U0A0VQglH 1D36o4jcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlyru-0003Rr-AK; Thu, 18 Jun 2020 18:02:30 +0000 Received: from mail29.static.mailgun.info ([104.130.122.29]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlyro-0003RS-L2 for linux-arm-kernel@lists.infradead.org; Thu, 18 Jun 2020 18:02:29 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1592503347; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=0wfkwopuLx8hs9G0OXE+EBnMO69t9YFTTa2ykBZeSkI=; b=H3iLz3i6LfeVC1T2yeArRZ5T/ybNY0AYKN4T6VcGHnFNeeDx+z/i0H+UQGB3uHQ86NAywvoK LFavn5VoZdpPU9hgFYR8e/frgwR1KCtVbzFKmB4wvjjCLQpGFa0yF6gHHjdPf24YzzWqvXnt eTaR0ygvdsnHloc4u8nyuRZTH4I= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n10.prod.us-east-1.postgun.com with SMTP id 5eebac118fe116ddd985f86f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Thu, 18 Jun 2020 18:01:53 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5B3AEC43395; Thu, 18 Jun 2020 18:01:52 +0000 (UTC) Received: from localhost (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: ilina) by smtp.codeaurora.org (Postfix) with ESMTPSA id 59BFEC433C9; Thu, 18 Jun 2020 18:01:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 59BFEC433C9 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=ilina@codeaurora.org Date: Thu, 18 Jun 2020 12:01:50 -0600 From: Lina Iyer To: Ulf Hansson Subject: Re: [PATCH 1/5] cpuidle: psci: Fail cpuidle registration if set OSI mode failed Message-ID: <20200618180150.GK12942@codeaurora.org> References: <20200615152054.6819-1-ulf.hansson@linaro.org> <20200615152054.6819-2-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200615152054.6819-2-ulf.hansson@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200618_110227_977967_70D1B288 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Benjamin Gaignard , Saravana Kannan , linux-pm@vger.kernel.org, Stephen Boyd , Daniel Lezcano , "Rafael J . Wysocki" , Bjorn Andersson , Sudeep Holla , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 15 2020 at 09:21 -0600, Ulf Hansson wrote: >Currently we allow the cpuidle driver registration to succeed, even if we >failed to enable the OSI mode when the hierarchical DT layout is used. This >means running in a degraded mode, by using the available idle states per >CPU, while also preventing the domain idle states. > >Moving forward, this behaviour looks quite questionable to maintain, as >complexity seems to grow around it, especially when trying to add support >for deferred probe, for example. > >Therefore, let's make the cpuidle driver registration to fail in this >situation, thus relying on the default architectural cpuidle backend for >WFI to be used. > >Signed-off-by: Ulf Hansson May be PATCH 3/5 should come before this change, but for this patch itself, please consider - Reviewed-by: Lina Iyer >--- > drivers/cpuidle/cpuidle-psci-domain.c | 5 ----- > 1 file changed, 5 deletions(-) > >diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c >index 423f03bbeb74..f07786aad673 100644 >--- a/drivers/cpuidle/cpuidle-psci-domain.c >+++ b/drivers/cpuidle/cpuidle-psci-domain.c >@@ -26,7 +26,6 @@ struct psci_pd_provider { > }; > > static LIST_HEAD(psci_pd_providers); >-static bool osi_mode_enabled __initdata; > > static int psci_pd_power_off(struct generic_pm_domain *pd) > { >@@ -272,7 +271,6 @@ static int __init psci_idle_init_domains(void) > goto remove_pd; > } > >- osi_mode_enabled = true; > of_node_put(np); > pr_info("Initialized CPU PM domain topology\n"); > return pd_count; >@@ -293,9 +291,6 @@ struct device __init *psci_dt_attach_cpu(int cpu) > { > struct device *dev; > >- if (!osi_mode_enabled) >- return NULL; >- > dev = dev_pm_domain_attach_by_name(get_cpu_device(cpu), "psci"); > if (IS_ERR_OR_NULL(dev)) > return dev; >-- >2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel