From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Clang-Built-Linux ML <clang-built-linux@googlegroups.com>,
vincent.whitchurch@axis.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Nathan Huckleberry <nhuck@google.com>
Subject: Re: [PATCH] Fix unwind_frame for clang-built kernels
Date: Thu, 18 Jun 2020 23:03:12 +0100 [thread overview]
Message-ID: <20200618220312.GK1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <CA+icZUW4Jv7589yCU55+C-P0=B0ztzvsOZ9TEMcTt4vKjFU1dA@mail.gmail.com>
On Wed, Jun 17, 2020 at 06:23:48AM +0200, Sedat Dilek wrote:
> On Wed, Jun 17, 2020 at 12:36 AM 'Nathan Huckleberry' via Clang Built
> Linux <clang-built-linux@googlegroups.com> wrote:
> >
> > Since clang does not push pc and sp in function prologues, the current
> > implementation of unwind_frame does not work. By using the previous
> > frame's lr/fp instead of saved pc/sp we get valid unwinds on clang-built
> > kernels.
> >
> > The bounds check on next frame pointer must be changed as well since
> > there are 8 less bytes between frames.
> >
> > This fixes /proc/<pid>/stack.
> >
> > Link: https://github.com/ClangBuiltLinux/linux/issues/912
> > Signed-off-by: Nathan Huckleberry <nhuck@google.com>
>
> Just a small nit.
>
> Please label your patch with: "arm/stacktrace: ..." or "arm: stacktrace: ..."
Convention is to use "ARM: ..." for arch/arm.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-18 22:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-16 22:36 [PATCH] Fix unwind_frame for clang-built kernels Nathan Huckleberry
2020-06-17 4:23 ` Sedat Dilek
2020-06-18 22:03 ` Russell King - ARM Linux admin [this message]
2020-06-18 20:22 ` Nick Desaulniers
2020-06-18 20:29 ` Nick Desaulniers
2020-06-19 1:55 ` Miles Chen
2020-07-06 18:27 ` [PATCH v2] ARM: stacktrace: " Nathan Huckleberry
2020-07-10 16:45 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618220312.GK1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhuck@google.com \
--cc=sedat.dilek@gmail.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).