From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F740C433DF for ; Tue, 23 Jun 2020 17:35:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2A3E207E8 for ; Tue, 23 Jun 2020 17:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0V4iyIJX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cAB5DngA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2A3E207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qU5pK5lY6O0Qvar/YjO0S/AQJmbR5O2ZJKH1r+7/o0M=; b=0V4iyIJXe/Y6XoE2e2Y2greQH iQcFgZhPIOtKb0I4BzNI+mzZd2yqOPsOZYtRaTrNqf9j1gTig3HqclsGE5M5N8rbKqNKjBgvILrZE 0mxSsRNCxGu+ZwBn4IQi7lqRbOKNnQxh3mU2M8Utk0G2tmyjh/11ZEmAWd6+6k+UjaAsV8p4DbL1G fqMdEpffWgbKXh0JzxknxxE4bXNqqay0m+TbgR4n8nCEi7E15iyjO+bTlaxgz7Y1ywnsAT8z2R0YW esAAgiHWtyQXuibOk51UIopcRvUUXa/TFJgHHSlHHY61Z8xeJyPB8UwVthE1QcXdvjAqB44JykSEN mQHfBzrbA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jnmns-0002uJ-41; Tue, 23 Jun 2020 17:33:48 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jnmnp-0002t4-MJ for linux-arm-kernel@lists.infradead.org; Tue, 23 Jun 2020 17:33:46 +0000 Received: by mail-pg1-x542.google.com with SMTP id u128so10155950pgu.13 for ; Tue, 23 Jun 2020 10:33:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iraOuU2nAS/k+2VyIidfWI20LZhSMu95WvSW+PLhzDA=; b=cAB5DngApas7biJNLKGUGeIVB7awS3HBWEggJGEguHU4d9COs9mhzD/TPXeAJZIpi3 rFzfPGPaBMtuYwXVbd1pSCnw2zGHnykBm8p1mo/6Z6DcsMlKOsLv4+Ukw1oGI2aFKeEK CblL4eBdtq6+Wdo2dto3J4/Csc352cOBivSYnXXIhi5Yik7Tq3f/AanhBl2cq3ymzcjF xx5ofMdjrpAUEq0Ci29EVUd0X+51lwLux3bczfcjoOTdCzCxA6owTOUVBDK7rQhlc1Lm pdNkVYIjiiFJfv64p3drFJTwDitN8JOEjZmxj//s5ILV3rZz0IuZHj2JN2h/3j62vVKN 5Wtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iraOuU2nAS/k+2VyIidfWI20LZhSMu95WvSW+PLhzDA=; b=KxIbvv8WMofGgZRLGTdTtIxVGgFfQCDRdEmT9vHdtN655RS5shLmM8aFHNUzD1n5p/ ySsrKTOJkBXffbqqTu+3TsgUtF88la18CS0xn3nHYCj/9h7AV7PPwtkDZ7InVOtGN3it 8b4PmlTopvpp/fzYh/gPAfLdAUxmqePplBFOxjClfKhMSqKTE5P8M7ZzzubWbXRH4AXO JVfmN+wZJsMSMAZFfMpzR1e2q3qJDTna9uyTbcA4q8aV96A88Z2y3XSOAiR0il/dqqjr Cpy2kKQfw3twtOunPVBmBeGQbkwz4maxoWo9sPlPHbyrllHbUb0CLtqXlCgZjBtYafb/ QMCA== X-Gm-Message-State: AOAM532QYJMW0EB25JCQjtA/93q8wNOvPd+gELzZkV48HbOO5gPf0/8t M7ZP9i5EG4rFXkEzJIAdu/TKKA== X-Google-Smtp-Source: ABdhPJzYi7yrFd/vQE+EQoy+GKEp0n7xf+yKWXxRg7RK5IvG7FEYUrnoZ+VnxgncruH7e+Po2uxXKQ== X-Received: by 2002:a62:8454:: with SMTP id k81mr25620819pfd.140.1592933623092; Tue, 23 Jun 2020 10:33:43 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id ng12sm3193013pjb.15.2020.06.23.10.33.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2020 10:33:42 -0700 (PDT) Date: Tue, 23 Jun 2020 11:33:40 -0600 From: Mathieu Poirier To: Sai Prakash Ranjan Subject: Re: [PATCH] coresight: tmc: Fix TMC mode read in tmc_read_unprepare_etb() Message-ID: <20200623173340.GB1843779@xps15> References: <20200616045441.27483-1-saiprakash.ranjan@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200616045441.27483-1-saiprakash.ranjan@codeaurora.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, Stephen Boyd , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 16, 2020 at 10:24:41AM +0530, Sai Prakash Ranjan wrote: > Reading TMC mode register without proper coresight power > management can lead to exceptions like the one in the call > trace below in tmc_read_unprepare_etb() when the trace data > is read after the sink is disabled. So fix this by having > a check for coresight sysfs mode before reading TMC mode > management register in tmc_read_unprepare_etb() similar to > tmc_read_prepare_etb(). > > SError Interrupt on CPU6, code 0xbe000411 -- SError > pstate: 80400089 (Nzcv daIf +PAN -UAO) > pc : tmc_read_unprepare_etb+0x74/0x108 > lr : tmc_read_unprepare_etb+0x54/0x108 > sp : ffffff80d9507c30 > x29: ffffff80d9507c30 x28: ffffff80b3569a0c > x27: 0000000000000000 x26: 00000000000a0001 > x25: ffffff80cbae9550 x24: 0000000000000010 > x23: ffffffd07296b0f0 x22: ffffffd0109ee028 > x21: 0000000000000000 x20: ffffff80d19e70e0 > x19: ffffff80d19e7080 x18: 0000000000000000 > x17: 0000000000000000 x16: 0000000000000000 > x15: 0000000000000000 x14: 0000000000000000 > x13: 0000000000000000 x12: 0000000000000000 > x11: 0000000000000000 x10: dfffffd000000001 > x9 : 0000000000000000 x8 : 0000000000000002 > x7 : ffffffd071d0fe78 x6 : 0000000000000000 > x5 : 0000000000000080 x4 : 0000000000000001 > x3 : ffffffd071d0fe98 x2 : 0000000000000000 > x1 : 0000000000000004 x0 : 0000000000000001 > Kernel panic - not syncing: Asynchronous SError Interrupt > > Fixes: 4525412a5046 ("coresight: tmc: making prepare/unprepare functions generic") > Reported-by: Mike Leach > Signed-off-by: Sai Prakash Ranjan > --- > drivers/hwtracing/coresight/coresight-tmc-etf.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > And this one too. > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c > index 36cce2bfb744..6375504ba8b0 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c > @@ -639,15 +639,14 @@ int tmc_read_unprepare_etb(struct tmc_drvdata *drvdata) > > spin_lock_irqsave(&drvdata->spinlock, flags); > > - /* There is no point in reading a TMC in HW FIFO mode */ > - mode = readl_relaxed(drvdata->base + TMC_MODE); > - if (mode != TMC_MODE_CIRCULAR_BUFFER) { > - spin_unlock_irqrestore(&drvdata->spinlock, flags); > - return -EINVAL; > - } > - > /* Re-enable the TMC if need be */ > if (drvdata->mode == CS_MODE_SYSFS) { > + /* There is no point in reading a TMC in HW FIFO mode */ > + mode = readl_relaxed(drvdata->base + TMC_MODE); > + if (mode != TMC_MODE_CIRCULAR_BUFFER) { > + spin_unlock_irqrestore(&drvdata->spinlock, flags); > + return -EINVAL; > + } > /* > * The trace run will continue with the same allocated trace > * buffer. As such zero-out the buffer so that we don't end > > base-commit: 3d439a6c349778f129de19595db564a8366c3634 > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel