From: Shawn Guo <shawnguo@kernel.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: "Aisheng Dong" <aisheng.dong@nxp.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Leonard Crestez" <leonard.crestez@nxp.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] soc: imx: Kconfig: force using OF when COMPILE_TEST
Date: Wed, 24 Jun 2020 11:27:49 +0800 [thread overview]
Message-ID: <20200624032738.GA3578@dragon> (raw)
In-Reply-To: <DB6PR0402MB276093000043C74BD28F1B3288950@DB6PR0402MB2760.eurprd04.prod.outlook.com>
On Wed, Jun 24, 2020 at 01:54:42AM +0000, Peng Fan wrote:
> > > ok, I'll use __maybe_unused in v2, but it actually not make sense to
> > > compile this file for x86_64.
> >
> > This is wrong in a subtle way. It makes sense to compile the driver on
> > x86_64 (and other archs) for QA reasons. It doesn't make sense to use a
> > kernel on an x86 machine with this driver enabled. That's why we have
> > COMPILE_TEST which you disable if you want to create a kernel to actually
> > run it.
>
> Shawn,
>
> What's your idea? I am not very clear on which path to go.
I think we agreed on __maybe_unused. What Uwe was questioning is the
second part of your statement - "it actually not make sense to compile
this file for x86_64."
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-06-24 3:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 10:21 [PATCH] soc: imx: Kconfig: force using OF when COMPILE_TEST peng.fan
2020-06-16 2:41 ` Aisheng Dong
2020-06-16 15:59 ` Uwe Kleine-König
2020-06-16 16:40 ` Robin Murphy
2020-06-17 2:05 ` Peng Fan
2020-06-17 6:05 ` Uwe Kleine-König
2020-06-24 1:54 ` Peng Fan
2020-06-24 3:27 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624032738.GA3578@dragon \
--to=shawnguo@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=peng.fan@nxp.com \
--cc=robin.murphy@arm.com \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).