From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B1EC433DF for ; Wed, 24 Jun 2020 05:49:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9DBC20768 for ; Wed, 24 Jun 2020 05:49:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yS6xNils"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HItW1RBc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9DBC20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TbdoLatt0h+h3o2tJ1MfnRolWy/eK5BEtTFwNP48w28=; b=yS6xNilsmJYMV/JwEBvtTUpuv sHeuj/xOrmrQxd9EwV4Ze0tkAQM6o75LRm4l8rDi3gvPnmumMYIUJ+P7aZCCaWjhMngo088wDkCvn edENbkaU67xuDuyNJ88t1Bj6QscQ50D8/ZQH/1k/6NdgTurlftcOs56Y2G1wC80wKRNGNsotDcd4J hiEMmAjNXDmhqgfJXlxzz5cRDYyZhNMIxDexDZSgM4wwNLFRLcviUsJemdfwc1KkJJzpW7yVj5PLk tLoAN/QN9IryGUginZfvC8QtUcdg2jvo2nvGpzjnFiMEIEnng2UZqR/EzgWnOjnhsIvOnQ8wcY/Rn L/xXuggLQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jnyEd-0002k9-9x; Wed, 24 Jun 2020 05:46:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jnyEa-0002hL-7K for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 05:46:09 +0000 Received: from localhost (unknown [171.61.66.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9890520768; Wed, 24 Jun 2020 05:46:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592977567; bh=A9yszn8fIAIjZK8KBhcQX82+P0BFKY8MrSA2lz2ouXI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HItW1RBc2IXZV2kdlBL5KcEt32Z5z1YZr1wRYEqSMZsNA9fRZfKyTqVUokR1+9GRT aFcpfAZJOUIhwgral9ad6SPAU+XFgvP20o2Zpj1y4cCQr+7haXYkqGuJ3vgr3vC2P3 tM4jcEriQm4iOWXmqMfv+/tZEm6eCPJ1oksGYXkU= Date: Wed, 24 Jun 2020 11:16:01 +0530 From: Vinod Koul To: Fabio Estevam Subject: Re: [PATCH] dmaengine: imx-sdma: Fix: Remove 'always true' comparison Message-ID: <20200624054601.GV2324254@vkoul-mobl> References: <20200621155730.28766-1-festevam@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200621155730.28766-1-festevam@gmail.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmaengine@vger.kernel.org, linux-imx@nxp.com, frieder.schrempf@kontron.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21-06-20, 12:57, Fabio Estevam wrote: > event_id0 is defined as 'unsigned int', so it is always greater or > equal to zero. > > Remove the unneeded comparisons to fix the following W=1 build > warning: > > drivers/dma/imx-sdma.c: In function 'sdma_free_chan_resources': > drivers/dma/imx-sdma.c:1334:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] > 1334 | if (sdmac->event_id0 >= 0) > | ^~ > drivers/dma/imx-sdma.c: In function 'sdma_config': > drivers/dma/imx-sdma.c:1635:23: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] > 1635 | if (sdmac->event_id0 >= 0) { > | Applied, thanks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel