From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A2AC433DF for ; Wed, 24 Jun 2020 14:43:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1638320781 for ; Wed, 24 Jun 2020 14:43:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BytkMIO4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LdqUQaQQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1638320781 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5SSDw5IbGXY61DFI1VNLKWLfsYtOgyLgrRba1pYfW0c=; b=BytkMIO4erTsuDn4IRp5dIrfE 27MrN+ifHeh/2fXH9Uw29+efdKOQyE2JJXBEhIlLWdSBI+SmcKQ6bcp+oNXOwHp2X9C17VJNjp/0H X8Sy1cdCWD/CExJQQMOtW5suQ2NtBgNaN+59Jf5mGTcAg14C+hMnA8e2denv4WmL7VxqImbbwZKD2 ud0hnDA4tuMWV0dwM3c6cTP5g4/EBvpn1dhFd9S128EhmaG3iCKUoqr6paIR+61i90+Fgaog9ESz/ me8uzj7fzOZrNRpBYBFR4XJGQWzxV5HdaZ5nGvH851DCk4expTuhK0s4Nd2EnUYcjllAhNCEqispv j/S3NWlEw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6aY-0006IZ-B0; Wed, 24 Jun 2020 14:41:22 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6aW-0006GJ-Jj for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 14:41:21 +0000 Received: by mail-pl1-x642.google.com with SMTP id s14so1136055plq.6 for ; Wed, 24 Jun 2020 07:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Fbp7umasnXh+ke7N+beUAyOfPReUM2Tp6A+dzgB7eMs=; b=LdqUQaQQ73lvg2EH4zB5b0fAHY6pDsTgO5VkTlBIIFPTWFDt6KEfeGjsb0w6+bZ9Ow NITWE6F0NiNBcydTH1X5G5v/4LVNjJl2xkptnKSgFVRZwIBSdg7/4DIa9E/LMGsAb6fD enidR4CvnWPaAtnjb4zwOOo4tT4QsgRPZnifk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Fbp7umasnXh+ke7N+beUAyOfPReUM2Tp6A+dzgB7eMs=; b=OWiZb/RUE+SCx7vuDTR//hWX/lK4CCNszQq1OvNSCIUOXe1mnNEO2R6zAwEB18BcU4 2WpSy6TdSZZ/ebQa6YqicDHTqRbdBU1JvmMG1upu8AKQoLeN8ED7i7THxXJZIgqu5+5W BpyMt345PgpcNbJX4adohfD3Ws03ifukZ/FbJii1kDgj/n9KsqbsmvMF64uahv5Yd39i I6GJEyUS8j1mcPQwFukOE+rj/CvfrYhx/yz2+bAWdIBhyMf5emtp0MVCtB+8pNmoWlhU J+ZQDlj8o1m4sWO/iOqDDu0SNmmQoIdagiHMMQ2QF7DGpiJf762zoIuNT9eoz60KMLeG 2R2w== X-Gm-Message-State: AOAM532/hx3GUEU3Td5FjRtWROkWO56BN5xLCQFx9GIhzeJOp6cCsJfE CumdbuitbzMAPZgr+bD1TQ3Ghg== X-Google-Smtp-Source: ABdhPJyLzb6qwq/8MBqHXf8uzinIy/tV8mWrOCrHPE7Fwn5qlWt9b5nzHsWE+x0soPiCSmy2JH0LLA== X-Received: by 2002:a17:90a:7185:: with SMTP id i5mr2257473pjk.175.1593009678562; Wed, 24 Jun 2020 07:41:18 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s23sm15899769pfs.157.2020.06.24.07.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 07:41:17 -0700 (PDT) Date: Wed, 24 Jun 2020 07:41:16 -0700 From: Kees Cook To: Alexander Popov Subject: Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter Message-ID: <202006240740.5AF6369E53@keescook> References: <20200624123330.83226-1-alex.popov@linux.com> <20200624123330.83226-6-alex.popov@linux.com> <20200624125305.GG4332@42.do-not-panic.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, kernel-hardening@lists.openwall.com, Catalin Marinas , Masahiro Yamada , Vincenzo Frascino , Will Deacon , Naohiro Aota , Sven Schnelle , Masahiro Yamada , linux-kbuild@vger.kernel.org, Emese Revfy , PaX Team , Iurii Zaikin , Mathias Krause , Jann Horn , Alexander Monakov , Brad Spengler , Thomas Gleixner , Peter Collingbourne , Laura Abbott , linux-arm-kernel@lists.infradead.org, notify@kernel.org, Florian Weimer , gcc@gcc.gnu.org, Michal Marek , linux-kernel@vger.kernel.org, Miguel Ojeda , Luis Chamberlain , Jessica Yu , Andrew Morton , Thiago Jung Bauermann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 04:09:20PM +0300, Alexander Popov wrote: > On 24.06.2020 15:53, Luis Chamberlain wrote: > > On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote: > >> Add 'verbose' plugin parameter for stackleak gcc plugin. > >> It can be used for printing additional info about the kernel code > >> instrumentation. > >> > >> For using it add the following to scripts/Makefile.gcc-plugins: > >> gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STACKLEAK) \ > >> += -fplugin-arg-stackleak_plugin-verbose > > > > Would be nice if we instead could pass an argument to make which lets > > us enable this. > > This feature is useful only for debugging stackleak gcc plugin. > > The cflag that enables it is similar to -fplugin-arg-structleak_plugin-verbose, > which is used for debugging the structleak plugin. > > This debugging feature clutters the kernel build output, I don't think that many > people will use it. So IMO creating a separate argument for make is not really > needed. Yup, agreed. The precedent for plugin verbosity is via CONFIGs. They're not really general purpose enough to justify a "make" argument. -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel