From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7839C433E0 for ; Wed, 24 Jun 2020 14:53:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5B2E20768 for ; Wed, 24 Jun 2020 14:53:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="w5Pa+2t5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="oOpZTa5+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5B2E20768 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ubuhO+dmqq5GzBHrZq8QgJwQpCN5i6BSTlSllisrBu4=; b=w5Pa+2t5oZoQugxw7MwMNr7MX ptt1sKbAk/VykrIQ79XYCNT0Yyn+RRTWDBz4AjFVRrKI+ZHTe2wGZKbUeo+QdRBjnMNgO10Aii/xP lHn+13Cjtc5W4oR8lpISikZwfqaaTZNBy1pjMpJzz4cMhmQIhJ7AC0bTyvQgcF70CbtnRR7J/P6qJ qI62V3L6MeG+vNRHfdiqNifxYUU/ojaZonqAG8YmiqI+K20/UohHrU8SCxG1XvGiHQwaex9L+puy5 ml03G2uahDz+0m1c2BiYIZnjGzqp9uMLL/8/XK4RJG/2ICjJpi+1dhhogudQ0h0kHyke/SwuSMTV7 pZo5OTkHw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6l3-0003GA-J8; Wed, 24 Jun 2020 14:52:13 +0000 Received: from mail-pg1-x542.google.com ([2607:f8b0:4864:20::542]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6l0-0003Dp-2I for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 14:52:11 +0000 Received: by mail-pg1-x542.google.com with SMTP id p3so1539269pgh.3 for ; Wed, 24 Jun 2020 07:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+LYpavnNuYqsfOkUttYqicpUlIfIv5Cp3lganI3VZyY=; b=oOpZTa5+wogd5Zo5i06YBiLJFA99TNpd/R+dpAjxia0I1HX72p/pYJ8+r7FI6VpwER kzA4slLqc797d9hmoYdf7UkLvHZBonG0ASsGwrh3JEmkqkxa0R9ukdqOi+fcffkssEzd F5YHRwr3LVOa1RW5jvA3hKVCIR9zUCv3CwZ08= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+LYpavnNuYqsfOkUttYqicpUlIfIv5Cp3lganI3VZyY=; b=I6zO73Vv2q3cneilg6XXL187t/8MVD58L6e5IKFublQVaQD6UVemQtdDDs1tcEwSF7 GO4MDo8rglgJyHZAOE3SNEOOaVNXAGtjG0m2KF8rHTlDG/2wJc8Gpa18vdNqIbLE7lSz 0D6e/8qwKyQKYLT779d/GqrbzFd0Yu5Ps1K02olWKG5Va0fpPdGoIqMTi+0Cj6U3fR+0 jYD1uThzKZ1DV1otIMwh+wg/4aOj+32CqMx/peVqYb0KUNhr8jtjzoqDucjme0qKgl4L fLFtbpZfimjpVw1GZAboJLwgikCgRL6ANRAnQyc70k4sZcZgKd9S+CPRJSyXHs/f2duq ahQA== X-Gm-Message-State: AOAM533mhT6uRQjFKW3X5TtInUjcgmDoDyANW8HpDPkL6O5AQ3GuB1tQ Qzv06d0k821mWNLfN3qvLbrq9Q== X-Google-Smtp-Source: ABdhPJwjhADjsZkiUiV63C7UdjS0kr8znYCOvlhuYeRyXXM/eucbfSwVQB3WasGrTPrLaBRSEotjoQ== X-Received: by 2002:a63:8b42:: with SMTP id j63mr22776554pge.131.1593010327982; Wed, 24 Jun 2020 07:52:07 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id cm13sm5609737pjb.5.2020.06.24.07.52.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 07:52:07 -0700 (PDT) Date: Wed, 24 Jun 2020 07:52:06 -0700 From: Kees Cook To: Alexander Popov Subject: Re: [PATCH v2 1/5] gcc-plugins/stackleak: Don't instrument itself Message-ID: <202006240751.30293A1@keescook> References: <20200624123330.83226-1-alex.popov@linux.com> <20200624123330.83226-2-alex.popov@linux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624123330.83226-2-alex.popov@linux.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, kernel-hardening@lists.openwall.com, Catalin Marinas , Masahiro Yamada , Vincenzo Frascino , Will Deacon , Naohiro Aota , Sven Schnelle , Masahiro Yamada , linux-kbuild@vger.kernel.org, Emese Revfy , PaX Team , Iurii Zaikin , Mathias Krause , Jann Horn , Alexander Monakov , Brad Spengler , Thomas Gleixner , Peter Collingbourne , Laura Abbott , linux-arm-kernel@lists.infradead.org, notify@kernel.org, Florian Weimer , gcc@gcc.gnu.org, Michal Marek , linux-kernel@vger.kernel.org, Miguel Ojeda , Luis Chamberlain , Jessica Yu , Andrew Morton , Thiago Jung Bauermann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 03:33:26PM +0300, Alexander Popov wrote: > There is no need to try instrumenting functions in kernel/stackleak.c. > Otherwise that can cause issues if the cleanup pass of stackleak gcc plugin > is disabled. > > Signed-off-by: Alexander Popov > Acked-by: Kees Cook Thanks! Applied to for-next/gcc-plugins. -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel