From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65044C433E1 for ; Wed, 24 Jun 2020 13:00:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C8D620786 for ; Wed, 24 Jun 2020 13:00:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="g8/X5nXD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="g7LBBWk0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C8D620786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Pw4pdurBx7zmsEUf1SB3/3yAljP8lpCYr3EGkwGV+ek=; b=g8/X5nXDFzeT3eCvpGmZGAj37 w1ct9vhhqvXx5FIULBVME4+QjuArLaoh9v5MISaA+rXRTCIDmPKPBqL5ncAuOhVuRD3jfA8bDyv+/ 02ar9onKBu/JpTdhJzJokTAb3VeCrEk+rg3rbO6iu4T91RN28M1m97ATMENpFAJlDoMn+9pczZH8f RI06pZ+GlZG+rXYqyo4vvbl2yfF/KGZihtiQ4eukNmb9CMdsjXvKQ9yi8VkAT6pZk6oMGlM85rKSa T2O5qjgodODSIxmt8lpqBRGcdLfbb6YLQoCbyxMGKG6Tz6UILEQy5dTJqkNMZavocyjJpunkH8qB5 Buzm6a3XA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo4zQ-0008Jt-7C; Wed, 24 Jun 2020 12:58:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo4zM-0008Ij-IH for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 12:58:53 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC7F920706; Wed, 24 Jun 2020 12:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593003531; bh=wc5mxzVtIYH7yXtP0I4Y5L+JdMP9jb1MqWLgvygyC2Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g7LBBWk0hcjd9EWZt5yCOj+T1kx3Nm+H/7l/getRmdhgGbnYXcCS7OByq70ddLFLp c26IiFZtjdu0zSZHl/BF7aEBhL5FZ21TcitI3oJgebolD4iDQdMXOL2H/63jOWFhbl 1LguVB1N74FOG5WCRfQjYaROpMCGXIAihnhNJpsM= Date: Wed, 24 Jun 2020 13:58:46 +0100 From: Will Deacon To: Florian Fainelli Subject: Re: [PATCH stable 4.9] arm64: entry: Place an SB sequence following an ERET instruction Message-ID: <20200624125846.GD6270@willie-the-truck> References: <20200612044219.31606-1-f.fainelli@gmail.com> <2bcebe48-1218-403a-798c-da30d678fdd6@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2bcebe48-1218-403a-798c-da30d678fdd6@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:KERNEL VIRTUAL MACHINE \(KVM\)" , Radim =?utf-8?B?S3LEjW3DocWZ?= , Marc Zyngier , Catalin Marinas , Will Deacon , open list , stable@vger.kernel.org, Christoffer Dall , Paolo Bonzini , "open list:KERNEL VIRTUAL MACHINE FOR ARM64 \(KVM/arm64\)" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 23, 2020 at 11:46:37AM -0700, Florian Fainelli wrote: > On 6/11/20 9:42 PM, Florian Fainelli wrote: > > From: Will Deacon > > > > commit 679db70801da9fda91d26caf13bf5b5ccc74e8e8 upstream > > > > Some CPUs can speculate past an ERET instruction and potentially perform > > speculative accesses to memory before processing the exception return. > > Since the register state is often controlled by a lower privilege level > > at the point of an ERET, this could potentially be used as part of a > > side-channel attack. > > > > This patch emits an SB sequence after each ERET so that speculation is > > held up on exception return. > > > > Signed-off-by: Will Deacon > > [florian: Adjust hyp-entry.S to account for the label] > > Signed-off-by: Florian Fainelli > > --- > > Will, > > > > Can you confirm that for 4.9 these are the only places that require > > patching? Thank you! > > Hi Will, Catalin, > > Does this look good to you for a 4.9 backport? I would like to see this > included at some point since this pertains to CVE-2020-13844. I think you're missing one of the ERET instructions in hyp/entry.S Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel