From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94046C433DF for ; Wed, 24 Jun 2020 15:34:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EF2520706 for ; Wed, 24 Jun 2020 15:34:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xdkAhABB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="pmnY1/hR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EF2520706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EwPu/dyAQn9bAgzLX+pmBNTNbqeY7rQtPvx2v9ciqo4=; b=xdkAhABBLwj8r9i6g3N8KvTo4 Kt4xh0ZhpUZN0XyuuE5BbmGRWWuAd+8cVUghmLWdNTfA1v2rskMwn9ceyX1X1aMO1nXf2rZECP+KT pAlX2kd+QQEoekIsaXmPXLjCv+2VACKnL+QDzg8RSAwRvHi8KCHKf3rvLmGKGKBTTgXAqLOs6ol/F QZsTgEIGlOg0kM8WH5LANBNh4kGNkYQAeAhZfEOW8SpIAzx7H4IpXTSzi4QJRG8WhEfFvPH9Va0S5 FUhDDNaLTU/bAKNX4eTVsG/ZfCdlKVZPKtB4FAZkRa0RvWL1RVsIg8ooWPIXA1gep+2VQkEqJFPHt kFXm4WCGw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo7OI-0001di-5G; Wed, 24 Jun 2020 15:32:46 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo7OC-0001c0-Pm for linux-arm-kernel@merlin.infradead.org; Wed, 24 Jun 2020 15:32:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b2GFBpgO7lFGtn+y2ftyrZgz14rUuytA5E3QPq4rIKo=; b=pmnY1/hRECbLl3N+vsreymGDWR zzgBoPiIPylI8d5vGRBZBuE5vmPkMLvGD2hA9gatRGHGjHFngOYSEuC5DJBMEweHPlcp7rBH87aGA aFd09z1c2phmBANm4853ADGHwucQ4/Nk6H/0uEH3aRsjPMVZZgk6S0226Net605OKc+HXBVagYxe4 LQxt5WQqGLxowBU3zS8uXJivlw2WYuk+O9KMEfYYQbfn5yZ+uXhdRVSiO2AE4dgpcHmEq3esVubaF QWmAkUYp2su0YlUu1H90Qew+5KOnqIc0fUeDnrzzWni0u/VcWx6gFy9UJgZ8D4Oi5RnFBW1WMzGv7 K/17iRXw==; Received: from asavdk3.altibox.net ([109.247.116.14]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo7O9-00044x-7c for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:32:39 +0000 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id CF78F20043; Wed, 24 Jun 2020 17:32:17 +0200 (CEST) Date: Wed, 24 Jun 2020 17:32:16 +0200 From: Sam Ravnborg To: Lee Jones Subject: Re: [PATCH 0/8] Fix a bunch of W=1 warnings in Backlight Message-ID: <20200624153216.GA1814806@ravnborg.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=YMhH-mIloVz_U1S6btoA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200624_163237_515538_D1F964DE X-CRM114-Status: GOOD ( 16.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: daniel.thompson@linaro.org, jingoohan1@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lee. On Wed, Jun 24, 2020 at 03:57:13PM +0100, Lee Jones wrote: > Attempting to clean-up W=1 kernel builds, which are currently > overwhelmingly riddled with niggly little warnings. > > Lee Jones (8): > backlight: lms501kf03: Remove unused const variables > backlight: lcd: Add missing kerneldoc entry for 'struct device parent' > backlight: ili922x: Add missing kerneldoc descriptions for > CHECK_FREQ_REG() args > backlight: ili922x: Remove invalid use of kerneldoc syntax > backlight: ili922x: Add missing kerneldoc description for > ili922x_reg_dump()'s arg I wonder why these warnings show up as nothing pulls in this .c file. Anyway I would suggest to drop using kerneldoc syntax for single drivers like this - and the benefit here is low. Now they are typed, otherwise this ahd been fine in a single patch. > backlight: backlight: Supply description for function args in existing > Kerneldocs > backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0 > backlight: qcom-wled: Remove unused configs for LED3 and LED4 The other fixes looks good. They are all: Acked-by: Sam Ravnborg Sam > drivers/video/backlight/backlight.c | 2 ++ > drivers/video/backlight/ili922x.c | 8 ++++++-- > drivers/video/backlight/lcd.c | 1 + > drivers/video/backlight/lm3630a_bl.c | 4 ++-- > drivers/video/backlight/lms501kf03.c | 8 -------- > drivers/video/backlight/qcom-wled.c | 8 -------- > 6 files changed, 11 insertions(+), 20 deletions(-) > > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel