From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2A0AC433DF for ; Wed, 24 Jun 2020 15:41:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F74A20706 for ; Wed, 24 Jun 2020 15:41:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RUD/ZBns"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XvOvolok" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F74A20706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=alum.mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:Date:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=u4A/IQO14lbm1UBal6wPQH32dboNsAQyKXWWOK0cHBs=; b=RUD/ZBnsuwiBPhlI4U523Ymys ZDraxeZmKKdKI3E1vWz9ebNqq9DjD913VEsl9V2vzNmXUhX4ndUCYQCObvwa5zld63o9LmyrQziaC +anAmj6z3by/fXc7XsovxGSv5z5tR2lkeQwJIzuHa+ojYoomyKNGWYdnBtQ0eVGfTgBlj4gqtCtCR V8bRfUKR40yU3fKf/ceN8x9mhIG97NkpfthcRz+mcy6Avn/1zktF1MqjB95jqSzVdgVVsZq7YPT3b xd1Y1ZSD0gAdtcnacO8ZfW9w5S73R+/43H0WIEzovp/yrZpwZj0P1DYBb4RnEKjKYfdOtOqZmF5NO pJyZs7GSA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo7V1-00055x-SP; Wed, 24 Jun 2020 15:39:43 +0000 Received: from mail-qt1-x843.google.com ([2607:f8b0:4864:20::843]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo7Uu-00050g-A1 for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 15:39:38 +0000 Received: by mail-qt1-x843.google.com with SMTP id u17so2050655qtq.1 for ; Wed, 24 Jun 2020 08:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=w86BiXeWW0qXr0CkddcsMzd0Qk3FGLVo77ySYOXx/9Y=; b=XvOvolokMbI6BM9fwAWbp0DSocFt1o+A8uoY/Reo4LDwzU4hQMNEqsXUMCfFLmPpRt oCGEUO7LJxfBoH6B4ugepuzR+W4BODGMKcD7n1kE8A3WQ3SLB+IBcIoTnjNohCiQzyKt CBCdrmzky74TFEFrPd2Kfsr2+14tR9HsbJRf+0G5kDdkEtuuh73IrvlaLZwDuMTWfMdb b+KS8pKoeDZyEW9HiZwMnTpp9wrt1CTAjBBJL+PFTzvo0sggPInyyKPq+J2T92oK6+DA 9pwLFWMXKwWdX1Nk7yDVPqpI15TQlqEik3eyKHAU8SGeuJh/Z3+7WK6+QdceBuBfHG31 HCRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:date:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=w86BiXeWW0qXr0CkddcsMzd0Qk3FGLVo77ySYOXx/9Y=; b=A8Y25G6RxWDwgspZvTeLiK0OzexOlOV5GSMbF/L4boZvKm8Ytv4Q/3ohCwcrLyq3Ju gCLque0T+zUWC70RgH0gwNS7t68ppacOFXpbaTDQF99kE4RbFS0U7Qaw2RlrndKucGpG Gforrz4H7j/ELr5mvRejdWnDnPJ/BK7RZC0KsT5omXMSFZS8/mrE0YpTzYzLSy1t4hmk Ty24rfZFtEGvvFVqiWkb8ixRh9TjRtTvGJQe13pNaejNjgUIlK8n6JRYLXojATd+6KJC Ko8PuwOyeZzrIUQMDozd0A/gWVEBwy+Fpa8yieFYgZZtNLS32yQ3co2jrDd0rbGcecBL kaZQ== X-Gm-Message-State: AOAM533rvFGKUIT5COfd5lknoNfVxSHKsDMzkBm0S0zKXN3lNm/7qL01 3G8OhSaL4mmR9idnUIe0iFs= X-Google-Smtp-Source: ABdhPJzqJsdRmlzGOwYnHtzAydQW9Iu1ltabpuAtDnDhT9pt2nyjZR92f7BI3Glrce11dxNr8bQdzQ== X-Received: by 2002:ac8:51d5:: with SMTP id d21mr26957465qtn.154.1593013173114; Wed, 24 Jun 2020 08:39:33 -0700 (PDT) Received: from rani.riverdale.lan ([2001:470:1f07:5f3::b55f]) by smtp.gmail.com with ESMTPSA id l56sm4306072qtl.33.2020.06.24.08.39.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:39:32 -0700 (PDT) From: Arvind Sankar X-Google-Original-From: Arvind Sankar Date: Wed, 24 Jun 2020 11:39:30 -0400 To: Kees Cook Subject: Re: [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG Message-ID: <20200624153930.GA1337895@rani.riverdale.lan> References: <20200624014940.1204448-1-keescook@chromium.org> <20200624014940.1204448-3-keescook@chromium.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624014940.1204448-3-keescook@chromium.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-efi@vger.kernel.org, Catalin Marinas , Arvind Sankar , Will Deacon , Thomas Gleixner , linux-arch@vger.kernel.org, Fangrui Song , Masahiro Yamada , x86@kernel.org, Russell King , Ard Biesheuvel , clang-built-linux@googlegroups.com, Ingo Molnar , Borislav Petkov , Arnd Bergmann , Nathan Chancellor , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, Nick Desaulniers , linux-kernel@vger.kernel.org, James Morse Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 23, 2020 at 06:49:33PM -0700, Kees Cook wrote: > When linking vmlinux with LLD, the synthetic sections .symtab, .strtab, > and .shstrtab are listed as orphaned. Add them to the STABS_DEBUG section > so there will be no warnings when --orphan-handling=warn is used more > widely. (They are added above comment as it is the more common Nit 1: is "after .comment" better than "above comment"? It's above in the sense of higher file offset, but it's below in readelf output. Nit 2: These aren't actually debugging sections, no? Is it better to add a new macro for it, and is there any plan to stop LLD from warning about them? > order[1].) > > ld.lld: warning: :(.symtab) is being placed in '.symtab' > ld.lld: warning: :(.shstrtab) is being placed in '.shstrtab' > ld.lld: warning: :(.strtab) is being placed in '.strtab' > > [1] https://lore.kernel.org/lkml/20200622224928.o2a7jkq33guxfci4@google.com/ > > Reported-by: Fangrui Song > Reviewed-by: Fangrui Song > Signed-off-by: Kees Cook > --- > include/asm-generic/vmlinux.lds.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > index 1248a206be8d..8e71757f485b 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -792,7 +792,10 @@ > .stab.exclstr 0 : { *(.stab.exclstr) } \ > .stab.index 0 : { *(.stab.index) } \ > .stab.indexstr 0 : { *(.stab.indexstr) } \ > - .comment 0 : { *(.comment) } > + .comment 0 : { *(.comment) } \ > + .symtab 0 : { *(.symtab) } \ > + .strtab 0 : { *(.strtab) } \ > + .shstrtab 0 : { *(.shstrtab) } > > #ifdef CONFIG_GENERIC_BUG > #define BUG_TABLE \ > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel