From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B18C433E0 for ; Wed, 24 Jun 2020 16:18:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11D5F20738 for ; Wed, 24 Jun 2020 16:18:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="k1oL+Sh6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="IOKX5uP5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11D5F20738 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zvZB0bqPrJrBJbS+TM+LJ42fuRzPm32cQowkxVDQFm0=; b=k1oL+Sh6QUxErxk8bg4o7lcas Svp+Me0SHc44KlYIIYHP6vz1y/eJ0pFaZ87w3beB3wcazFOznujDGX2W96xvwo8OlknC/3RbIIzC2 8E6AE5osMo3IiH71TV8z1K+R9AsV4ixT9vSVzvjkkvpegU1jP/crUrenbO7DzDvI/wYKO5LjWOh6V FuqsmevvrV6f3B5Fuzs36iB8F1EtIYXoTgIL8eP/CG3Z+Gm2k1MNk/4XobmAygOizqw0RJO18JhnQ 71SHlG2xrUsnpsrj4w9xp6zA6FfUtqkwUNCPpPnxL++QvqcrmyYSCf9yJAjPCK+oJcYqSp9o6vMJV /+r1rF0QQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo84z-0003Oe-1L; Wed, 24 Jun 2020 16:16:53 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo84v-0003Ln-7d for linux-arm-kernel@lists.infradead.org; Wed, 24 Jun 2020 16:16:50 +0000 Received: by mail-pl1-x643.google.com with SMTP id bh7so1225928plb.11 for ; Wed, 24 Jun 2020 09:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r9Atz1n5S97FsyRtwbW9FxEwVR3HptLSj7YkFtdgBWc=; b=IOKX5uP5HrCSDaBldb1Tlqjq7QjS/iWV7iYPBJGBjm5MBfZlGZ65fHIb7gwqwcoeRw dpXx4RbkMXKmlmUkJyMmOhKjGP7uq2faKSrJkx0pPbJOJB7HDj5gJYJ2qr85eHA/cnXV H6UkqiZT7Hf4A7Y6EJAKS9VnW6TG4YJJIJmC+zN1+gKqnpwjbbJGFpXjQv5PDJQkvtpY D/il9Ds6lNa0aRabxw+vMLX7xAiBD/HhgWYaeid2aqPseFEPjLtTY//si6OJ/tdrxJqy ei45oSHSPuORVmZon0PcThpNgkP0FKv3aL/MUReCE1NqPG/qnNGcmVu2OID8z6Gczdpa L/Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r9Atz1n5S97FsyRtwbW9FxEwVR3HptLSj7YkFtdgBWc=; b=EFtTjOCfN2+LfNEnDTMPdfhr4ywsYXBM7ujB3YXZr06lmE+roc5xh6JuOMHGmcd3vD bvSlkJMQ0xIvEDm9xskY+tHXwvw2OtkZ4pJneziHoWqOj88g5KwOvCVNeTfkUDbxfasi DwrIrj0dXUA8/bTpwZT4KfX4i0OurcnVZqcLPG2l70IZq8snvJoBXW69Y1Amt+CNJCBs 6PS49AR2T63mI+Ruwt39AK3HsQ+zvaqkfsT14YAMBqBO51fq8XfWeZWV/pEKGauTx9cK orrKDovZFOYtR6UauBnGdFg6dTGdjjg3cZNASVF93ocUixSf+jfCOwj0irBq1FpIsAlW AJDw== X-Gm-Message-State: AOAM531Q2/Xq9G0BSEQR1lLHbJCth20gde4nXvv2ymzLb9oThhogKrnC 51zHlGrIK2gfgNry0cMutpi9tA== X-Google-Smtp-Source: ABdhPJzR5oxdlp9qxvLSBQa9QdrzRcyjkIYkFPOJwAujW1umQ1cg0Dv9Hmvl7bclAIhrUSrRff3SUA== X-Received: by 2002:a17:90a:7c4e:: with SMTP id e14mr29364901pjl.175.1593015406860; Wed, 24 Jun 2020 09:16:46 -0700 (PDT) Received: from google.com ([2620:15c:2ce:0:9efe:9f1:9267:2b27]) by smtp.gmail.com with ESMTPSA id oc6sm6480133pjb.43.2020.06.24.09.16.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 09:16:46 -0700 (PDT) Date: Wed, 24 Jun 2020 09:16:43 -0700 From: Fangrui Song To: Arvind Sankar Subject: Re: [PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG Message-ID: <20200624161643.73x6navnwryckuit@google.com> References: <20200624014940.1204448-1-keescook@chromium.org> <20200624014940.1204448-3-keescook@chromium.org> <20200624153930.GA1337895@rani.riverdale.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624153930.GA1337895@rani.riverdale.lan> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Arnd Bergmann , Peter Collingbourne , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, Nathan Chancellor , clang-built-linux@googlegroups.com, Ingo Molnar , James Morse , Thomas Gleixner , Borislav Petkov , Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-06-24, Arvind Sankar wrote: >On Tue, Jun 23, 2020 at 06:49:33PM -0700, Kees Cook wrote: >> When linking vmlinux with LLD, the synthetic sections .symtab, .strtab, >> and .shstrtab are listed as orphaned. Add them to the STABS_DEBUG section >> so there will be no warnings when --orphan-handling=warn is used more >> widely. (They are added above comment as it is the more common > >Nit 1: is "after .comment" better than "above comment"? It's above in the >sense of higher file offset, but it's below in readelf output. I mean this order:) .comment .symtab .shstrtab .strtab This is the case in the absence of a linker script if at least one object file has .comment (mostly for GCC/clang version information) or the linker is LLD which adds a .comment >Nit 2: These aren't actually debugging sections, no? Is it better to add >a new macro for it, and is there any plan to stop LLD from warning about >them? https://reviews.llvm.org/D75149 "[ELF] --orphan-handling=: don't warn/error for unused synthesized sections" described that .symtab .shstrtab .strtab are different in GNU ld. Since many other GNU ld synthesized sections (.rela.dyn .plt ...) can be renamed or dropped via output section descriptions, I don't understand why the 3 sections can't be customized. I created a feature request: https://sourceware.org/bugzilla/show_bug.cgi?id=26168 (If this is supported, it is a consistent behavior to warn for orphan .symtab/.strtab/.shstrtab There may be 50% chance that the maintainer decides that "LLD diverges" I would disagree: there is no fundamental problems with .symtab/.strtab/.shstrtab which make them special in output section descriptions or orphan handling.) >> order[1].) >> >> ld.lld: warning: :(.symtab) is being placed in '.symtab' >> ld.lld: warning: :(.shstrtab) is being placed in '.shstrtab' >> ld.lld: warning: :(.strtab) is being placed in '.strtab' >> >> [1] https://lore.kernel.org/lkml/20200622224928.o2a7jkq33guxfci4@google.com/ >> >> Reported-by: Fangrui Song >> Reviewed-by: Fangrui Song >> Signed-off-by: Kees Cook >> --- >> include/asm-generic/vmlinux.lds.h | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h >> index 1248a206be8d..8e71757f485b 100644 >> --- a/include/asm-generic/vmlinux.lds.h >> +++ b/include/asm-generic/vmlinux.lds.h >> @@ -792,7 +792,10 @@ >> .stab.exclstr 0 : { *(.stab.exclstr) } \ >> .stab.index 0 : { *(.stab.index) } \ >> .stab.indexstr 0 : { *(.stab.indexstr) } \ >> - .comment 0 : { *(.comment) } >> + .comment 0 : { *(.comment) } \ >> + .symtab 0 : { *(.symtab) } \ >> + .strtab 0 : { *(.strtab) } \ >> + .shstrtab 0 : { *(.shstrtab) } >> >> #ifdef CONFIG_GENERIC_BUG >> #define BUG_TABLE \ >> -- >> 2.25.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel