From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7CE5C433E0 for ; Thu, 25 Jun 2020 09:43:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95A8A20709 for ; Thu, 25 Jun 2020 09:43:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eeXc0MDI"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KHHYFSoy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95A8A20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BRcOyrAx4RuegSwaO5eJwoumFJPXnNT6ocR+fXFDLqg=; b=eeXc0MDIEFmHbFzyxGw8dSpJu snyyY3BpSl463la88lFDZSwgZKcyEDSV5OrpKopwumQ/PZE/YXVqU2nLNYLYULTf7wgho2r/mTApj EW0b/f47mQR9985ypC5w23jeiq78YlmGeShXrpdDVurwwq70/ZgEDhazrGqeB23Y9qFomhESigr2G RDBKbfKbKo54bpp5m45U/n5HfRUuHSyoXjz19uFw7xUoH1rVOkdm+FiZsaubSADCqEH9lGmBdiwT0 W7t3MlrkflrFskH/BeUfqpHtODqaVomI3hAbnvyoX7aEjOJ9S+cFL9sDcGu8qy3IDiJl4Z9m8IPuS 98hFa4rPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joONv-0006v5-Db; Thu, 25 Jun 2020 09:41:31 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joONt-0006ug-IN for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 09:41:30 +0000 Received: by mail-wr1-x442.google.com with SMTP id j4so2656576wrp.10 for ; Thu, 25 Jun 2020 02:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=o1jD7J8NDVqOQc9AKq7CATicHwQZYtpzJ7cR9sOfFqw=; b=KHHYFSoy24G/mXyVtLft9wFkNpYC2Pktesf5tHqTuFFWhOYFY1uLmbdKS9K7U4hBvQ n7iwkmWESbQO2d3LySeThLR8EMVDTCNtpIF/0NoRbndmxwkd59b0E0TEA+EScemuQz3w BUZ82dIyTxeMrB+/XJg38uVhDfKVznLpqjf27nHqgvNpoAAyXfuX13zFn/cepgtKDKVf gos2hUBI6fOo+KynmRO1otG/CrSzPyazUoownlH2w66Xl1P2qh4QDEfkz8iC7yhmbao2 hjyaIoRYWZwRMfSxsu5SExtGw8xmz9TPS5M3MyRUnRgnD5xIqmw7hKs5YJrpFIDnV4Uy gJ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=o1jD7J8NDVqOQc9AKq7CATicHwQZYtpzJ7cR9sOfFqw=; b=eZmVX6J7NkEBJnSFCyRLpQmBkGOegfuJCPQBFPKgjXfx/RPUjJULmVekGCxQo4QI0S +nxifUAs5/BhO+SeOql/BRQLgbOQGeZlyWPkpNJn5OYjQ0kty7yLjVOS/ZO4BENh+92i KziYAnTmWW7gzh+qF9KbeRZaxMK6A1OsfBOMfYY7sRej1PRoeM/+4vBI8cNADBllSvET mfBP8kTOneyRoKBP5pddQSBIMvB3oC0uCfBAP/Bwx3kAVG9DOnuu1niS8m8wodk5vJ+n YbuldYQe2iL248PzTpS8qMx6zCOWHL/YKiM15FShzqB2dDdhDsynt16LVjw49DP0Z59u f86Q== X-Gm-Message-State: AOAM5307ZPXpy3x4pRziOnC2nHqQPEgnSnCAauhlzmHtcm0/yZj4TXBN Qcodg1pQsILPZI1V3/fAzcIU8A== X-Google-Smtp-Source: ABdhPJwqVIF3U4RpHKFRh/x+HzkKFYCTnP8uQGV7G4OL1b+Bw0pR+kNSz0MBfG7un3od3TOn8lviaA== X-Received: by 2002:adf:8462:: with SMTP id 89mr20649914wrf.420.1593078088492; Thu, 25 Jun 2020 02:41:28 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id o7sm9921492wmb.9.2020.06.25.02.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 02:41:27 -0700 (PDT) Date: Thu, 25 Jun 2020 10:41:26 +0100 From: Daniel Thompson To: Lee Jones Subject: Re: [PATCH 4/8] backlight: ili922x: Remove invalid use of kerneldoc syntax Message-ID: <20200625094126.jp5e7x64sjdu7med@holly.lan> References: <20200624145721.2590327-1-lee.jones@linaro.org> <20200624145721.2590327-5-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200624145721.2590327-5-lee.jones@linaro.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , jingoohan1@gmail.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Software Engineering , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2020 at 03:57:17PM +0100, Lee Jones wrote: > Kerneldoc is for documenting function arguments and return values. > > Prevents warnings like: > > drivers/video/backlight/ili922x.c:127: warning: cannot understand function prototype: 'int ili922x_id = 1; ' > drivers/video/backlight/ili922x.c:136: warning: cannot understand function prototype: 'struct ili922x ' > > Cc: > Cc: Bartlomiej Zolnierkiewicz > Cc: Software Engineering > Signed-off-by: Lee Jones Reviewed-by: Daniel Thompson > --- > drivers/video/backlight/ili922x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c > index 8cb4b9d3c3bba..cd41433b87aeb 100644 > --- a/drivers/video/backlight/ili922x.c > +++ b/drivers/video/backlight/ili922x.c > @@ -123,7 +123,7 @@ > > #define set_tx_byte(b) (tx_invert ? ~(b) : b) > > -/** > +/* > * ili922x_id - id as set by manufacturer > */ > static int ili922x_id = 1; > @@ -132,7 +132,7 @@ module_param(ili922x_id, int, 0); > static int tx_invert; > module_param(tx_invert, int, 0); > > -/** > +/* > * driver's private structure > */ > struct ili922x { > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel