From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C562BC433DF for ; Thu, 25 Jun 2020 09:47:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9296920679 for ; Thu, 25 Jun 2020 09:47:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2q6kbjVT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nck4BtH5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9296920679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mI8cDaBYTrDbeBon/nAvRlUHjpaoRExTLrFUboHDGus=; b=2q6kbjVTeoZ2VpbEW80ck7TZO qI73DSXIirBIw5ouzb5ABOfBA0VcoFOIi4+BEO/NlSsYNu7nNkyOSSsTxeVe4QG5Mbv1TjkhAbII0 tQafL3ZYRDg85ThT2jFkggvmM0tPoYytRvNK6ztqbZibm2nBNBhS0tyoyzyB3B+AlXjvR61gp03of /UQzKu6hjAbji70g2XD4YluYJHOqV2j4j8/knaQWp48EOM5YAu6Nog6f6+ckNBcXBPI26efLBL/yU K+BFmKrO7AW7EPpyncBoJ56GGReh/WiM7YnOeZudSa9zj0EqMVN7cIv4LQnFoXPzBT2AsurrQ7yrW Uj59mzBZA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joORc-0008Nt-SL; Thu, 25 Jun 2020 09:45:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joORZ-0008LZ-Hh for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 09:45:18 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 353E320679; Thu, 25 Jun 2020 09:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593078316; bh=77zCTrVeRsOnQTM4A76BRsxjLVMeEVAnfEdbtBCzlcQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nck4BtH5Cr7Ue7pyhhz5oaV73t8bqxrX1iCmdvSpXXAPieNKo1SgPMjuBx0IedKMO BlnXvd/UbF1b3ywdWghUriIjnLh/lO4Ex6liYWv49cPBkY5YrhBsavS+b9T9tzSd8U aDP6tzGSU40vJLyo/JRDQNyV/EngGVs9cLp4oDVA= Date: Thu, 25 Jun 2020 11:45:13 +0200 From: Greg KH To: Lee Jones Subject: Re: [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args Message-ID: <20200625094513.GC3299764@kroah.com> References: <20200625064619.2775707-1-lee.jones@linaro.org> <20200625064619.2775707-2-lee.jones@linaro.org> <20200625065608.GB2789306@kroah.com> <20200625071313.GM954398@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625071313.GM954398@dell> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 25, 2020 at 08:13:13AM +0100, Lee Jones wrote: > On Thu, 25 Jun 2020, Greg KH wrote: > > > On Thu, Jun 25, 2020 at 07:46:10AM +0100, Lee Jones wrote: > > > Kerneldoc syntax is used, but not complete. Descriptions required. > > > > > > Prevents warnings like: > > > > > > drivers/mfd/wm8350-core.c:136: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_lock' > > > drivers/mfd/wm8350-core.c:165: warning: Function parameter or member 'wm8350' not described in 'wm8350_reg_unlock' > > > > > > Cc: > > > Cc: patches@opensource.cirrus.com > > > Signed-off-by: Lee Jones > > > --- > > > drivers/mfd/wm8350-core.c | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/drivers/mfd/wm8350-core.c b/drivers/mfd/wm8350-core.c > > > index 42b16503e6cd1..fbc77b218215c 100644 > > > --- a/drivers/mfd/wm8350-core.c > > > +++ b/drivers/mfd/wm8350-core.c > > > @@ -131,6 +131,8 @@ EXPORT_SYMBOL_GPL(wm8350_block_write); > > > * The WM8350 has a hardware lock which can be used to prevent writes to > > > * some registers (generally those which can cause particularly serious > > > * problems if misused). This function enables that lock. > > > + * > > > + * @wm8350: pointer to local driver data structure > > > */ > > > int wm8350_reg_lock(struct wm8350 *wm8350) > > > { > > > @@ -160,6 +162,8 @@ EXPORT_SYMBOL_GPL(wm8350_reg_lock); > > > * problems if misused). This function disables that lock so updates > > > * can be performed. For maximum safety this should be done only when > > > * required. > > > + * > > > + * @wm8350: pointer to local driver data structure > > > */ > > > int wm8350_reg_unlock(struct wm8350 *wm8350) > > > { > > > > Why are all of these documentation fixes for stable? > > Because they fix compiler warnings. When you type 'make' these warnings show up? We don't do documentation builds as part of a normal build... If for some reason we ever get rid of all of the thousands of current warnings, then yes, I will be glad to consider stuff like this then. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel