From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 892E3C433E0 for ; Fri, 26 Jun 2020 11:53:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4131D2078D for ; Fri, 26 Jun 2020 11:53:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0+/SrSpK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ewyhl2qH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="ff8pJTwL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4131D2078D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lSoOoA4Oe3WeJ1ASxRGZfdt+/F7AqzDkWV472JAo2S0=; b=0+/SrSpKX0qqIpRRbzeEq2wzd oroX994ppNGLmiSUu6zl43JTnvCe05SV8lOkR83gmZArstpGRnJXQs0A7ipR2NZn3FuZZDpBwx7uk gaV7lwqKqyist7McMrLx7+rI1KtkfDPpgQpJQpQUqaAOCSKk+Y57M6ilfARSpCxCjg/mqy2XG10C4 4Fc3C9siU4FLpEK9UvUhjqMwPU/VeAcwVDFHM+QYO14ogiuS4xUaT2HWrlskWeBWgJqynHBhzE6U5 F02oZs1f1N6TIjSwbHxeFOD9kyKsvbrgT3sr8v2Czdyi3LV9FMnmmdK55qRVxiWtj5CPb1JPlupNn iQVpuhe6w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomu9-0006PE-4h; Fri, 26 Jun 2020 11:52:25 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolOO-0002eU-5o for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:15:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+df13v+AvbHRI+0q7hSJ2DFnkMwltHAJzFloMEs+1FI=; b=Ewyhl2qHs21+AwG6fE6iyojmV7 vNVHB3X6wBthrKj0640q+Ym/lMy7M4o7YWIQ0dMVHl8FrCk7BL5Oak/PzqroaK1sWRz/iIMo3JK1a +xJ8puZCMiL/KAnwB+Orbkxh3ZaI/EkmVNN4wVo+ORkoPhZ7UwejtrSgv5JBtXn1ngN42+1fNZiFo uNpLxTyEneSeFXPKgcvttWmvO/VP8BrPl/CzFzdSLUjHld5DcUV1jnMlWYImwr7yiQszQxOYetnjJ zHwo/B+ZaaBdz1Ga2ZIeXpdW8pXTjgdH5IsYCE6H+D6/EFdPZ2FbDkw66MPtk4gCxZEchJqQVqlmF RZj75Pfg==; Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1job45-0005Wj-4o for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 23:13:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+df13v+AvbHRI+0q7hSJ2DFnkMwltHAJzFloMEs+1FI=; b=ff8pJTwLFHOxuLoV2FtHmAGtv Sf2fkGNbigss0aeXBRx5PHD2LTkdASaEarZAWFoIeihoyJBSMTFesT54Ou2UxgDHgiZYR2Msj3zrY ojzZ67bwf2raqyhWhUTPHLkNBpnSed0G9GhM3v6Wau2DvWi40YIyIhnF4uAj7UfidxsHYJCVY06L6 uoaGwU+Bxsx3LES1EVTRKP+vJ2TELzzNmv4T8ESLYYG8AziYCI9Wd+ofeiGK/Ram/bm8SZysWWTwL i1iqkYoCRzcrDrzyNlTkyr5NgidasoYt8UvgdAnaKe3I/kIuKMBjlTWTzZ5bRku9X/6cFDxcwnbUz hdZwTBbPg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59774) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1job0x-0004mx-8F; Fri, 26 Jun 2020 00:10:39 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1job0n-0003Sj-6B; Fri, 26 Jun 2020 00:10:29 +0100 Date: Fri, 26 Jun 2020 00:10:29 +0100 From: Russell King - ARM Linux admin To: Christophe JAILLET Subject: Re: [PATCH] scsi: cumana_2: Fix different dev_id between 'request_irq()' and 'free_irq()' Message-ID: <20200625231029.GN1551@shell.armlinux.org.uk> References: <20200530073555.577414-1-christophe.jaillet@wanadoo.fr> <20200625204730.943520-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625204730.943520-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_001353_355167_622BDD84 X-CRM114-Status: GOOD ( 17.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, jejb@linux.ibm.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 25, 2020 at 10:47:30PM +0200, Christophe JAILLET wrote: > The dev_id used in 'request_irq()' and 'free_irq()' should match. > Use 'info' in both cases. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Christophe JAILLET Acked-by: Russell King Thanks Christophe. > --- > V2: update free_irq instead of request_irq in order not to obviously break > code > --- > drivers/scsi/arm/cumana_2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/arm/cumana_2.c b/drivers/scsi/arm/cumana_2.c > index 65691c21f133..29294f0ef8a9 100644 > --- a/drivers/scsi/arm/cumana_2.c > +++ b/drivers/scsi/arm/cumana_2.c > @@ -450,7 +450,7 @@ static int cumanascsi2_probe(struct expansion_card *ec, > > if (info->info.scsi.dma != NO_DMA) > free_dma(info->info.scsi.dma); > - free_irq(ec->irq, host); > + free_irq(ec->irq, info); > > out_release: > fas216_release(host); > -- > 2.25.1 > > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel