From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_ADSP_ALL, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95249C433DF for ; Fri, 26 Jun 2020 11:43:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BF85208B6 for ; Fri, 26 Jun 2020 11:43:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TvUNTKqk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="kgOyAj/D"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=megous.com header.i=@megous.com header.b="YU+RBJh1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BF85208B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=megous.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yZj9bc94BTIPC2P9V2sRCmbXYD1jrOkNDosmrPs3FdU=; b=TvUNTKqkcO6YoW6pmS0mHW/tr V8RT52Z6JOvu6Aq2bGqXHvK+vKg9dfgJV/D2VS5VUgC92Hk/N5uFEMVDssBTq6xvwUhDKgaYyt39J WSl+8uuGkLA9E/TCmcukT8UFPC285USxI18nToxQWOOMzxtZJHjx4hHCCWYft7GxlVDjjoCVY+gwb ww+o87cFDPjf4qW1VgOiTmYxZztfJsjpQ/V5dzfgcH+l6yHAOii/6CtuiX4ye94WhzkgDXpDsKelH uKgI+/LxXsGd5KxEfFNkjtjcfRwVqmlEr/E+wRFEaNbxq7JZ7ZHyqj5YkbzQ9lJsPLGIlT9DfzICh 60SKxwkAg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomkQ-0001Mv-Pn; Fri, 26 Jun 2020 11:42:22 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolLZ-0002eU-UW for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:12:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=PNt8Jc261lxo8AGjK7vuWdmhP48WiKsDybQIcFbkk4s=; b=kgOyAj/DdwAG0ZnvNuwagp5jAF FF3Vmy4QiFhQdmcS4JlKIURncZEYAIK9uiKW7Atu+BaO8gqjAYusind4iaCrP+1I85bsw85EIC+wR q38C1Jlb28zsyDUJ305USYrY0DLEh/1XTwsNC/RIRPa6X4FaPGSiknvJUJPP2fFuYaYTxjrqQIUji gMw/kopBlld1FApaV7IYJdKhEEEhqtkNer+ebWk02es5varwNA8NfA+X91h7gWvW+QrgRwGwZSvOg dNZ9E7RebNcE+fQ34L/HNgzlxQGtaRLe8eKeFZYym9fz2wKb7xOmYn386jgrDZNzAWyHItue82Kz5 otUll80g==; Received: from vps.xff.cz ([195.181.215.36]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jocfD-0003ZP-TQ for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 00:56:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megous.com; s=mail; t=1593132969; bh=N2+51FLSxUgYRTfkXppkmskKeBdxuh3L5G/ggCgw7IU=; h=From:To:Cc:Subject:Date:References:From; b=YU+RBJh1BuD/O0pZTuUclupCY0WwQbwCu7LwnIsZ9fPLnfxBKXxeNefY3Ju6DjE1f +oomT5n3OGj1k/gML4Nobh8D0ib0BdJVSzYpLTkzf1P39N/lftJ5Kvy1VLx73X0paN QohLdX6hy/qdRtXWDCD20Wew0lgTsbDK4+8s/zGA= From: Ondrej Jirman To: linux-sunxi@googlegroups.com, Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , =?UTF-8?q?Guido=20G=C3=BCnther?= , Purism Kernel Team , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Linus Walleij , Icenowy Zheng Subject: [PATCH v5 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators Date: Fri, 26 Jun 2020 02:55:59 +0200 Message-Id: <20200626005601.241022-12-megous@megous.com> In-Reply-To: <20200626005601.241022-1-megous@megous.com> References: <20200626005601.241022-1-megous@megous.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_015620_780593_C8C677D4 X-CRM114-Status: UNSURE ( 9.60 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ondrej Jirman , devicetree@vger.kernel.org, Samuel Holland , Bhushan Shah , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Luca Weiss , Martijn Braam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The reset pin is inverted, so if we don't assert reset, the actual gpio will be high and may keep driving the IO port of the panel. Signed-off-by: Ondrej Jirman --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c index e771281eb547..92930e127559 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c @@ -416,6 +416,7 @@ static int st7703_unprepare(struct drm_panel *panel) if (!ctx->prepared) return 0; + gpiod_set_value_cansleep(ctx->reset_gpio, 1); regulator_disable(ctx->iovcc); regulator_disable(ctx->vcc); ctx->prepared = false; -- 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel