From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C43BC433DF for ; Fri, 26 Jun 2020 11:25:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9506F206C0 for ; Fri, 26 Jun 2020 11:25:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WhLNiS14"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="KgBZNZRB"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nvdBEZ7r" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9506F206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mH3ZGBD81sRNckqMISQ0GjnnhpLohX++apwVFCjgVnQ=; b=WhLNiS14Q3Bk+W1sIy3b4d9kM oEngIp6BWFcjBBskOyQkx8j3e/YkwgP4HC9UjLs89tVSXx5AOQTTAGEc0WhRarnOAUl4GsLXBYa3k 34WVEgczru7IBqjAP+xbpAk6+R6XzAn5A3E0k4NA6jZSPk2Xoc8PCsbwOxrH2U3jwRcrJrMMHb49j 1cqFAdffIZTpMK1buFz15vXEoNIEJO0jRshrYs0kpkdANbKxlHiyrzh9TZi86OVpoXNWWR8nAOdLN Nk4qeeVWozx+xVc3Lc22jroeLPxsoxeoX3mVIO0mBK7kmhxU8Sb0ZccE6WDa+MN2pYwsYYNXnfV6C wQ35y47iQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jomSQ-00019F-58; Fri, 26 Jun 2020 11:23:46 +0000 Received: from casper.infradead.org ([90.155.50.34]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jolDy-0000aR-56 for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 10:04:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jPjxTeB7DcZFNvR4lCQsdqpTCmjL1iaR4x39hd7bSd4=; b=KgBZNZRBFTkFzSpvt9uBc+6h/t f7pbKJYzcJMWLHGlg2xbJHVKGsh40Rxtke34f8kgNcHoJysBopBIdM2D9bloZR/mOUZDzLZUQJjxj FIz3l+iQ3MZUO7jYLspgYT0v3XmdiNf4wjDR0cjzt1z+eow3kXmxmUtItTJcjFnWu9p01kydRiPsO qx2mGXC3W3a/6d0b3hLY6rA2WNzdmnffcb2cXePDp6ThSImtqEsExiKigj1GIM1CH49pLFPlvjMDu gq5rBVDtzviBsEvHkzsPv779BP0q58dYnL0lf/qaNFa2rmijrC1ZeET/z/IidbWCr9uX4xjPbpUgm Cq+2JZsw==; Received: from mail-pl1-f195.google.com ([209.85.214.195]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jol5j-0001ZW-20 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 09:56:20 +0000 Received: by mail-pl1-f195.google.com with SMTP id x11so4093176plo.7 for ; Fri, 26 Jun 2020 02:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jPjxTeB7DcZFNvR4lCQsdqpTCmjL1iaR4x39hd7bSd4=; b=nvdBEZ7rHAbq4p48jarp/krSDKhwuZMDK25DPWCRh4Q47iMgknYwYuYQjoMAtA0XHF eS+/+dFsEOA5xX9cxSK6uYMAsvGVRYDRVUTtkUWGff6WbS9RRsTAW2mAeIIFrEFL10MD 9x8gbRb0RVmXdpL0sWICjveFCkg11iuLkA0a+nc+1PWlfOINJ/7WzIQYZcBhIYMlmuOm 6n+edET86wnicxODQilAASlhvhAbTfxIsvPfJKvcV3/mrONLkIbYLh2abBkxBqfjfeER tPLWn+dPhU5P9d1IoIQI9NQabEbs4n0tvwOa3C/dqVhAqFERhlFxcRP2yAzHQ7yV2OmR oyyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jPjxTeB7DcZFNvR4lCQsdqpTCmjL1iaR4x39hd7bSd4=; b=Im3NA+iOGRuizeb2mMvsQSxPWI5CV24kLH2QriPifULBsdTk7OGrlpuWA5ZgdkmNFd RqLgweYbD6isYN4a6U8oWebSzUwfSDbMZMvZMr0DLI09InNCQIO9CNuyF8Szxhcir/lX pdDoUtVTTselyZjCEFZPXYml/lJ4Xomj+nfIqpbRQGhNjOFAfM9DeM2xyTCIvd6iewVc CuPDEVkS4ps1GW+bPTbT4sAQBb4Yl8TFurnDudKqWbKQehhrqqx2w076nd5dQAVmYlH7 rRGpRM9SsB1TsfwPlQuVm9++WjdJ+RnA58y2g40tHELfOU9bXaORwo5mcrkBcp75DcVb HmiQ== X-Gm-Message-State: AOAM531CkcmmDbOfWuNd/pSLLZnXpOOAUINCBfZBfN86vK1W4mjiZfPd abAlm1BvtKV2U22ciyUawKsOn33RGdU= X-Google-Smtp-Source: ABdhPJxh4m7dx47I/UYghsbYaLrbQLLj/RfDd1kukrzDy0jInIROjoornub6OBEtA1HErZokevwI6w== X-Received: by 2002:aa7:98c1:: with SMTP id e1mr1576927pfm.318.1593156084235; Fri, 26 Jun 2020 00:21:24 -0700 (PDT) Received: from builder.lan (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id w30sm7638826pjj.3.2020.06.26.00.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 00:21:23 -0700 (PDT) Date: Fri, 26 Jun 2020 00:18:45 -0700 From: Bjorn Andersson To: Lee Jones Subject: Re: [PATCH 2/9] regulator: qcom-rpmh-regulator: Repair dodgy kerneldoc header formatting Message-ID: <20200626071845.GC388985@builder.lan> References: <20200626065738.93412-1-lee.jones@linaro.org> <20200626065738.93412-3-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200626065738.93412-3-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_105616_330560_DF98F9D1 X-CRM114-Status: GOOD ( 19.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, broonie@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, Andy Gross , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu 25 Jun 23:57 PDT 2020, Lee Jones wrote: > W=1 kernel builds report a lack of descriptions for various > enum properties and function arguments. In reality they are > documented, but the formatting was not as expected '@.*:'. > Instead, some weird arg identifiers were used or none at all. > > This change fixes the following warnings: > > drivers/regulator/qcom-rpmh-regulator.c:33: warning: Enum value 'VRM' not described in enum 'rpmh_regulator_type' > drivers/regulator/qcom-rpmh-regulator.c:33: warning: Enum value 'XOB' not described in enum 'rpmh_regulator_type' > drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'vreg' not described in 'rpmh_regulator_init_vreg' > drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'dev' not described in 'rpmh_regulator_init_vreg' > drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'node' not described in 'rpmh_regulator_init_vreg' > drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'pmic_id' not described in 'rpmh_regulator_init_vreg' > drivers/regulator/qcom-rpmh-regulator.c:416: warning: Function parameter or member 'pmic_rpmh_data' not described in 'rpmh_regulator_init_vreg' > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: linux-arm-msm@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Bjorn Andersson Thanks, Bjorn > --- > drivers/regulator/qcom-rpmh-regulator.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c > index 79bdc129cb504..08dcc614efa7f 100644 > --- a/drivers/regulator/qcom-rpmh-regulator.c > +++ b/drivers/regulator/qcom-rpmh-regulator.c > @@ -22,9 +22,9 @@ > > /** > * enum rpmh_regulator_type - supported RPMh accelerator types > - * %VRM: RPMh VRM accelerator which supports voting on enable, voltage, > + * @VRM: RPMh VRM accelerator which supports voting on enable, voltage, > * and mode of LDO, SMPS, and BOB type PMIC regulators. > - * %XOB: RPMh XOB accelerator which supports voting on the enable state > + * @XOB: RPMh XOB accelerator which supports voting on the enable state > * of PMIC regulators. > */ > enum rpmh_regulator_type { > @@ -399,13 +399,13 @@ static const struct regulator_ops rpmh_regulator_xob_ops = { > > /** > * rpmh_regulator_init_vreg() - initialize all attributes of an rpmh-regulator > - * vreg: Pointer to the individual rpmh-regulator resource > - * dev: Pointer to the top level rpmh-regulator PMIC device > - * node: Pointer to the individual rpmh-regulator resource > + * @vreg: Pointer to the individual rpmh-regulator resource > + * @dev: Pointer to the top level rpmh-regulator PMIC device > + * @node: Pointer to the individual rpmh-regulator resource > * device node > - * pmic_id: String used to identify the top level rpmh-regulator > + * @pmic_id: String used to identify the top level rpmh-regulator > * PMIC device on the board > - * pmic_rpmh_data: Pointer to a null-terminated array of rpmh-regulator > + * @pmic_rpmh_data: Pointer to a null-terminated array of rpmh-regulator > * resources defined for the top level PMIC device > * > * Return: 0 on success, errno on failure > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel