From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABBBFC433E0 for ; Fri, 26 Jun 2020 15:28:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A177207E8 for ; Fri, 26 Jun 2020 15:28:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ij+dlm9r"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OV2MEBsV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A177207E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y1tv4JHO/9tDfbi0llu+38gHbGKST0esA54NOTlnh1Y=; b=Ij+dlm9rt4KFyORTHTUvV3Fnl btKFrE+xgLvBzXKc8RZaxO7nqlSnF2KGs99thhc8P080eGS7O/2HwdSmFlWkW/RFWMajMuhKrcrI+ 5YiTIYIqgy1zZum8yJZWo6iDpua9NrbVQzIm2PU2mh3/l1Y0OJn7eUl/9ou8IEVHNbPL0EAa8U2cx NLYxOfln2sOSZE06rdx2o7SGXeF1owb72guh2Odn7UNT6mi2eFvnI/haH4IC5dmq0nN+8i6u8gStv TarjnotnFQo2G1xWgdqlF4jt6PS1TyoJZNgWqZpfL4NPmPLbP6ty6/eDjN7HR2HNNbJQTJjET4YhM dEcE4ZTnQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joqFU-0007Xo-68; Fri, 26 Jun 2020 15:26:40 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joqFO-0007Wv-Sg for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 15:26:35 +0000 Received: by mail-pf1-x444.google.com with SMTP id u185so2755204pfu.1 for ; Fri, 26 Jun 2020 08:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=SGbBcZmi7JWYkcmSuZuMkDkOvcG69EpOPP88SAzNvdw=; b=OV2MEBsVbbgFRgkfsg3gKcIyAxzhOi9e+yhzWHyd2zWOkn+XiOwkOJNz/2sSZiG2kh W3cMGtcu+UuLnsjvQFu1OYF2TJKX8Ziw751JowQOGuMZM8+sq8293ctqbMzYo9oiPBpd GQ7RVsECGWGMaD7YzKmvcbZr6A5ALg98qHxhQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=SGbBcZmi7JWYkcmSuZuMkDkOvcG69EpOPP88SAzNvdw=; b=FVu9Et6LX30c0lfrlo4h00ciLOCAqfwJwrEObjDdSAzPzvrzBq9Fj47l4p0yCcubr/ hIZ7g+F9w3z3/2J3BGLbly/fnV8e8YBzS4uitH2glu1OJBY/EjABK+8YEUWBDK0vEI5y 4pw0+VmHTf5XlBgtE5WY/wgARczLUgkiVbCaLCzZRRqmyDKFFPsLCYsl/KwI/g+F6YaG 4jrJxCh/t1DEbPDLZXR744nnaR0a4W/oK7B9+ZUEaAwyK7BZAljPPpZ0BWNFBE4uIL65 sO5WqGtUDHXmYlGA0dwFPMnkMWpLJ+iXBYcwGMkZ7UrDRTS98cfqoxNFC97h6UuNRkSM 7EUA== X-Gm-Message-State: AOAM532w18vM2L9THnl3tCrmFXlQAv6SDbUXldk1g8DkiMNhk59aVv3L zF4r+XaV6zR6M1+9eKNNCM9Gzg== X-Google-Smtp-Source: ABdhPJxLbmD5CwIezukq172Xja4wW7yqyiCldoMg6FYFakPoVpwRnS+OWs2h0At9c0wzp83W2w2szQ== X-Received: by 2002:a63:5013:: with SMTP id e19mr3254551pgb.68.1593185193063; Fri, 26 Jun 2020 08:26:33 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h17sm21791916pgv.41.2020.06.26.08.26.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 08:26:32 -0700 (PDT) Date: Fri, 26 Jun 2020 08:26:31 -0700 From: Kees Cook To: Lee Jones Subject: Re: [PATCH 04/10] misc: lkdtm: bugs: At least try to use popuated variable Message-ID: <202006260825.F530851198@keescook> References: <20200626130525.389469-1-lee.jones@linaro.org> <20200626130525.389469-5-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200626130525.389469-5-lee.jones@linaro.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdW4gMjYsIDIwMjAgYXQgMDI6MDU6MTlQTSArMDEwMCwgTGVlIEpvbmVzIHdyb3Rl Ogo+IFRoZSByZXN1bHQgbWF5IG5vdCBiZSBpbnRlcmVyZXN0aW5nLCBidXQgbm90IHVzaW5nIGEg c2V0IHZhcmlhYmxlCj4gaXMgYmFkIGZvcm0gYW5kIGNhdXNlcyBXPTEga2VybmVsIGJ1aWxkcyB0 byBjb21wbGFpbi4KPiAKPiBGaXhlcyB0aGUgZm9sbG93aW5nIFc9MSB3YXJuaW5nKHMpOgo+IAo+ ICBkcml2ZXJzL21pc2MvbGtkdG0vYnVncy5jOiBJbiBmdW5jdGlvbiDigJhsa2R0bV9TVEFDS19H VUFSRF9QQUdFX0xFQURJTkfigJk6Cj4gIGRyaXZlcnMvbWlzYy9sa2R0bS9idWdzLmM6MzMxOjI1 OiB3YXJuaW5nOiB2YXJpYWJsZSDigJhieXRl4oCZIHNldCBidXQgbm90IHVzZWQgWy1XdW51c2Vk LWJ1dC1zZXQtdmFyaWFibGVdCj4gIDMzMSB8IHZvbGF0aWxlIHVuc2lnbmVkIGNoYXIgYnl0ZTsK PiAgfCBefn5+Cj4gIGRyaXZlcnMvbWlzYy9sa2R0bS9idWdzLmM6IEluIGZ1bmN0aW9uIOKAmGxr ZHRtX1NUQUNLX0dVQVJEX1BBR0VfVFJBSUxJTkfigJk6Cj4gIGRyaXZlcnMvbWlzYy9sa2R0bS9i dWdzLmM6MzQ1OjI1OiB3YXJuaW5nOiB2YXJpYWJsZSDigJhieXRl4oCZIHNldCBidXQgbm90IHVz ZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4gIDM0NSB8IHZvbGF0aWxlIHVuc2lnbmVk IGNoYXIgYnl0ZTsKPiAgfCBefn5+Cj4gCj4gQ2M6IEtlZXMgQ29vayA8a2Vlc2Nvb2tAY2hyb21p dW0ub3JnPgo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+ CgpBaCB5ZWFoLCB0aGlzIGxvb2tzIGxpa2UgYSByZWFzb25hYmxlIHdheSB0byBkZWFsIHdpdGgg aXQuIFRoYW5rcyEKCkFja2VkLWJ5OiBLZWVzIENvb2sgPGtlZXNjb29rQGNocm9taXVtLm9yZz4K Ci0tIApLZWVzIENvb2sKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK