From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F609C433DF for ; Fri, 26 Jun 2020 14:35:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13A3E2070A for ; Fri, 26 Jun 2020 14:35:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rnfjqlAG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13A3E2070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8Jgo3KO6tCJo4SiNkScJLUsoSV/BXHPPyRelDLmRqYQ=; b=rnfjqlAGuyGAm8z2tcSpSGV/V 2TovTE9QofVVbv+vfDbVotgpJC1S4FrEfEuA7y+A7Ym5MNZSLyt+RfuUGNDsRJqoV00mYO3IaiY3H n05lYbssA6LltFF4yrtzFvx5v+9mybkJfscvPMCVtNhvylBwxpcot0AnfgX3yItyXkarJ0t39bWCb aHDyQG/LmPY7aO5WNRmhpMZ7OIqPUwag+xtjvcJk35yueIr17s5+MxkrEGLs9c9rYcYRfpRV9Ngss XqibJD9OsOoZOJrZ3E4qs2/NnIg4kuNFhhD3X35yQUF4zILjaTU1g5BvhK2CqoiXOOr08+8eirRHV NqHwthfCg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jopQd-0000zp-F2; Fri, 26 Jun 2020 14:34:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jopQa-0000yI-B3 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 14:34:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 40B201FB; Fri, 26 Jun 2020 07:34:01 -0700 (PDT) Received: from bogus (unknown [10.37.12.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2AB3E3F6CF; Fri, 26 Jun 2020 07:33:57 -0700 (PDT) Date: Fri, 26 Jun 2020 15:33:55 +0100 From: Sudeep Holla To: Ulf Hansson Subject: Re: [PATCH 1/5] cpuidle: psci: Fail cpuidle registration if set OSI mode failed Message-ID: <20200626143355.GC27140@bogus> References: <20200615152054.6819-1-ulf.hansson@linaro.org> <20200615152054.6819-2-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200615152054.6819-2-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Vincent Guittot , Benjamin Gaignard , Saravana Kannan , linux-pm@vger.kernel.org, Stephen Boyd , Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 15, 2020 at 05:20:50PM +0200, Ulf Hansson wrote: > Currently we allow the cpuidle driver registration to succeed, even if we > failed to enable the OSI mode when the hierarchical DT layout is used. This > means running in a degraded mode, by using the available idle states per > CPU, while also preventing the domain idle states. > Is that not better than not registering itself ? I tend to disagree here. > Moving forward, this behaviour looks quite questionable to maintain, as > complexity seems to grow around it, especially when trying to add support > for deferred probe, for example. > I thought the sync_state in the driver must deal with that. > Therefore, let's make the cpuidle driver registration to fail in this > situation, thus relying on the default architectural cpuidle backend for > WFI to be used. > CPU level states work w/o the need of OSI, and better than WFI. That was the original aim. If that is not working, we must make it work instead of falling back on WFI IMO. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel