From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32291C433DF for ; Fri, 26 Jun 2020 21:37:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0D622088E for ; Fri, 26 Jun 2020 21:37:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xLSnSuSj"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YEN4h/JS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0D622088E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HeOsnbOC7HFI9fk/RzwINMrepic9i7e6pIFb0+62zf4=; b=xLSnSuSjHh8SJl4wQ9GCHBj+T 0gifHeHdoUUHI57hXgQjH/xOYEJMWtSuprH7D4ko1f3vA6fq42WkbqbImTmPd1O3buiY6uQi6v+uF /9Y2bKNiXYGon2xr7KvSjoDMzKsg27RMymaRauvxja12o7Z7c/r5hyXVsXgfLho7zknHEWdtBy/Ad hWUrf59Q93RQLtqYXZBet/6AggsbgBK/qSR9Xe5OH9fBl7MiwfbNvjLM8sXzP+6O8KA5QGzqcpT+y Nu5TvyaI3Nm+fIZijvsOTK952rnZJ0MLo1hGWkQNxD+HzYPu4b+JSicE42HNQ5qKGar8N+jUql3GJ PtLbstf+w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jow0j-0004YK-Ik; Fri, 26 Jun 2020 21:35:49 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jow0h-0004Xf-86 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 21:35:48 +0000 Received: by mail-pf1-x443.google.com with SMTP id f9so5186308pfn.0 for ; Fri, 26 Jun 2020 14:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DqOaaV58EjOIY1VepCG+GQtVeu6B1YTzNiLFMCCxxtU=; b=YEN4h/JS6rsbM2TA8UohIHdNyG9IbIr7SJGjr/bFVHhrG/Xom9uuW4VVJlxpjCalyc VzYDhmbP8IO2Aln4UuRyuqd6Tgy9Qku2VWWKJ3oZdsqEk7RJQDbYUlIcQKhd+fpKbBRk cijP8DnapIIWZQIeC0Y6ZFYLszmtMLfDZQXr0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DqOaaV58EjOIY1VepCG+GQtVeu6B1YTzNiLFMCCxxtU=; b=miKY2VeymAa3J42xXGOY0/VoFlRdsnKewRcKaoBsCcK/VF/2fofdeYkFBzBMMNZrY9 IqMlnhtuarXBJHG1C7809IsbIFB1G744vIN240Mqll1Sm9DTnPbb9sJi5fjisAwp3LY/ yNk2SZaxO7iElwZBl0WkI966bphiEVBSqSCEsi5v3tQUIZfrUwQ/0gkgBkv/hc8Itdm+ YQuQS5fdZ1e2TWnp+h0f25aqB6ypbydTcLZfAjid5ws7i7kRZF091ScCOuL1IINmqPot uuLisTh2ognhWgtbwgcaIP3FSmuUaxURYrox5DyJ3eDH9UldS1aLpEVWXhZae77UY98c cEng== X-Gm-Message-State: AOAM530PgSx8rCR43+YVnXq4fQt831lB/+2sgZxjoO5XsRQ0NuaP12t9 xSMrBS0lpYB385KfWUJFrIZRMQ== X-Google-Smtp-Source: ABdhPJzxc7cz1MJJ6rNuO5CPPtEcoMO4+f1C1i4DCl9wrVYJnO0GAsRDswfDPhhwjkUn/N4AdYEJaA== X-Received: by 2002:a63:371c:: with SMTP id e28mr692197pga.114.1593207345125; Fri, 26 Jun 2020 14:35:45 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id w135sm7739381pfc.106.2020.06.26.14.35.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 14:35:43 -0700 (PDT) Date: Fri, 26 Jun 2020 14:35:43 -0700 From: Kees Cook To: Brendan Higgins Subject: Re: [PATCH v5 09/12] kunit: test: add test plan to KUnit TAP format Message-ID: <202006261434.119AE33DBB@keescook> References: <20200626210917.358969-1-brendanhiggins@google.com> <20200626210917.358969-10-brendanhiggins@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200626210917.358969-10-brendanhiggins@google.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, catalin.marinas@arm.com, jcmvbkbc@gmail.com, will@kernel.org, paulus@samba.org, linux-kselftest@vger.kernel.org, frowand.list@gmail.com, anton.ivanov@cambridgegreys.com, linux-arch@vger.kernel.org, richard@nod.at, rppt@linux.ibm.com, benh@kernel.crashing.org, yzaikin@google.com, linux-xtensa@linux-xtensa.org, arnd@arndb.de, jdike@addtoit.com, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, davidgow@google.com, skhan@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com, chris@zankel.net, monstr@monstr.eu, sboyd@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, alan.maguire@oracle.com, mpe@ellerman.id.au, akpm@linux-foundation.org, logang@deltatee.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 26, 2020 at 02:09:14PM -0700, Brendan Higgins wrote: > TAP 14 allows an optional test plan to be emitted before the start of > the start of testing[1]; this is valuable because it makes it possible > for a test harness to detect whether the number of tests run matches the > number of tests expected to be run, ensuring that no tests silently > failed. > > Link[1]: https://github.com/isaacs/testanything.github.io/blob/tap14/tap-version-14-specification.md#the-plan > Signed-off-by: Brendan Higgins > Reviewed-by: Stephen Boyd Look good, except... > diff --git a/tools/testing/kunit/test_data/test_is_test_passed-all_passed.log b/tools/testing/kunit/test_data/test_is_test_passed-all_passed.log > index 62ebc0288355c4b122ccc18ae2505f971efa57bc..bc0dc8fe35b760b1feb74ec419818dbfae1adb5c 100644 > GIT binary patch > delta 28 > jcmbQmGoME|#4$jjEVZaOGe1wk(1goSPtRy09}gP > delta 23 > ecmbQwGmD2W#4$jjEVZaOGe1wk&}5@94;uhhkp{*9 > > diff --git a/tools/testing/kunit/test_data/test_is_test_passed-crash.log b/tools/testing/kunit/test_data/test_is_test_passed-crash.log > index 0b249870c8be417a5865bd40a24c8597bb7f5ab1..4d97f6708c4a5ad5bb2ac879e12afca6e816d83d 100644 > GIT binary patch > delta 15 > WcmX>hepY;fFN>j`p3z318g2k9Uj*m? > > delta 10 > RcmX>renNbL@5Z2NZU7lr1S$Xk > > diff --git a/tools/testing/kunit/test_data/test_is_test_passed-failure.log b/tools/testing/kunit/test_data/test_is_test_passed-failure.log > index 9e89d32d5667a59d137f8adacf3a88fdb7f88baf..7a416497e3bec044eefc1535f7d84ee85703ba97 100644 > GIT binary patch > delta 28 > jcmZ3&yOLKp#4$jjEVZaOGe1wk(1goSPtRy0-!wJ=eKrU$ > > delta 23 > ecmZ3