From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DDC1C433DF for ; Fri, 26 Jun 2020 21:54:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BE362089D for ; Fri, 26 Jun 2020 21:54:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nRMVFcFF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VIGOIHNE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BE362089D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GPe10npEpZZJfjPJkOsvjH3NQrTb02Vy9Igb+8Z3Di8=; b=nRMVFcFFliJb4fKpbcLhG0jpd /NxoKpnrbbgib/WF/cQrEEfmAdxiQ6bUuiLhPtIY8QiRJJ9wx44mbtkkiIjjGxg5KBjLAL2KW1KYE 84VDnWKJkVT4wf5KLcVpwTL7fX8iRDF4lh5JdsaLPM+U4nJiY2x6dlFgxRRdMgGvnOn4JzzDhJ+yD emgV7POoZ1kBs3gfZmxksdOaMSIn1X1v5a2rg2kYvO1wG1CsuFmCeOh5EaBhy7ZAfNoJXaUwl9VNX d0Fu0gMYoxbuY1ZxKAy2mbWB77wHjoxJq1x7CaL9N4zi1x2tNDdfFRHESF+45B9CthiUlWO4Ydt/C EA81FnUOw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jowH5-0006he-OP; Fri, 26 Jun 2020 21:52:43 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jowH3-0006gv-KP for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 21:52:42 +0000 Received: by mail-pf1-x443.google.com with SMTP id b5so5181301pfp.9 for ; Fri, 26 Jun 2020 14:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Q757IDXyRukGvX5SZOHlJdoHJ/1n6S14vTGyo4zvXBQ=; b=VIGOIHNEEU9j/QBCfkBjGdBcqAkDVMSPH2V6E9pYYKa7w0oI1NtGdugkcB6s2J7djs DSZ85QWa+gMBeGdBreMiRKvPJcdHicHe0ZZZe3JPNlhdZodj/p1tvl8Xip3Cc2IPrr+s lsiie+VLCThaSSaloZS5eYhO67RiKTuNXrYns= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Q757IDXyRukGvX5SZOHlJdoHJ/1n6S14vTGyo4zvXBQ=; b=CbGlfpJs29mHNx9gD7ExzfqkrDMlivpgE+QNSmbfWhKMFQPvtOhmv6uWtjUW5Y2Ob3 Nyw8DRdDCK9TuPc0K9gReuYDFmMO8fXquqdqX1H9u6G6pvA9Zl5y968VLWjYrqzhh3TW 7IPLZ77vCF7JeI2jAVkV1RtpojBLJ6t0Zwf6HxVzbWfzbUyLqceQDSJM8Ksizhf3lGsu 7MTghUL8C56yEZeZo4Ly10MyeEkjPj9wCVj/9TapgXVr25bK+s4Mho0x8y8ufl/NIsg8 K2r4HqUmidGSPWS3BVCB+bHkD2GvvJE9Zs6JVtp7Zo36uJDp4BxWflC2g6RsYB4gDHuQ dDUA== X-Gm-Message-State: AOAM5316ItWAr7bx0DTCJQGxqOOd2+itMGyxzjtb+ISQPPa9szZ32L4M sAkBHwRa9Z2dHHnHmQ9BE6UpOA== X-Google-Smtp-Source: ABdhPJxjew6vuVd8xK7z4Or0D8mu7tCMflIKF0q/SKBZ2je3Uo1yszhe7quUG/VVVAWRTDES/M5wNg== X-Received: by 2002:a62:ea0b:: with SMTP id t11mr4824646pfh.276.1593208359728; Fri, 26 Jun 2020 14:52:39 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o16sm23597011pgg.57.2020.06.26.14.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 14:52:38 -0700 (PDT) Date: Fri, 26 Jun 2020 14:52:37 -0700 From: Kees Cook To: Brendan Higgins Subject: Re: [PATCH v5 00/12] kunit: create a centralized executor to dispatch all KUnit tests Message-ID: <202006261442.5C245709@keescook> References: <20200626210917.358969-1-brendanhiggins@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200626210917.358969-1-brendanhiggins@google.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-doc@vger.kernel.org, catalin.marinas@arm.com, jcmvbkbc@gmail.com, will@kernel.org, paulus@samba.org, linux-kselftest@vger.kernel.org, frowand.list@gmail.com, anton.ivanov@cambridgegreys.com, linux-arch@vger.kernel.org, richard@nod.at, rppt@linux.ibm.com, benh@kernel.crashing.org, yzaikin@google.com, linux-xtensa@linux-xtensa.org, arnd@arndb.de, jdike@addtoit.com, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, davidgow@google.com, skhan@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com, chris@zankel.net, monstr@monstr.eu, sboyd@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, alan.maguire@oracle.com, mpe@ellerman.id.au, akpm@linux-foundation.org, logang@deltatee.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 26, 2020 at 02:09:05PM -0700, Brendan Higgins wrote: > This patchset adds a centralized executor to dispatch tests rather than > relying on late_initcall to schedule each test suite separately along > with a couple of new features that depend on it. So, the new section looks fine to me (modulo the INIT_DATA change). The plumbing to start the tests, though, I think is redundant. Why not just add a sysctl that starts all known tests? That way you don't need the plumbing into init/main.c, and you can have a mode where builtin tests can be started on a fully booted system too. i.e. boot with "sysctl.kernel.kunit=start" or when fully booted with "echo start > /proc/sys/kernel/kunit" And instead of the kunit-specific halt/reboot stuff, how about moving /proc/sysrq-trigger into /proc/sys instead? Then you (or anything) could do: sysctl.kernel.kunit=start sysctl.kernel.sysrq-trigger=b -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel