From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 754DCC433DF for ; Fri, 26 Jun 2020 14:44:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B56D20768 for ; Fri, 26 Jun 2020 14:44:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y0CtEqbv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B56D20768 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+WhtwKTxb+T2ocArceSoFb+PCBpiDGeqDGUPsDUaR50=; b=Y0CtEqbvJomKlFtksm9RYvrSs q0Lfv92nzS02f/A56jQccvodVWg/MWM747mz0gAQQI8jkHTKKX4NktU30nl4n5ll4O2lnuHbBzHhQ HYRWRdQ7WWfzV36+L6I286wUDUI0xQ654SNJNvQ0O+LN3SX7TOZvxFmfqgEUjM6N4Ht6hLKzpbcN5 +SAVBy015iPfd0MYZ8pMYL57kV7p7ZfdnF47GScXmLtEGnLeJRAhK/54ne27hl0q8wOGQ56uwsTs5 LOVZUh/8Eg+JvIRNN3ggqoCBq///ugddVq3gJR5cZSK2euC3U027q7HjvRvSRT6OZLb191Tl9DbSU JSHvDc8LA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jopYh-00031P-R0; Fri, 26 Jun 2020 14:42:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jopYe-0002yl-QP for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 14:42:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0C2FC1FB; Fri, 26 Jun 2020 07:42:24 -0700 (PDT) Received: from bogus (unknown [10.37.12.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 292E63F6CF; Fri, 26 Jun 2020 07:42:20 -0700 (PDT) Date: Fri, 26 Jun 2020 15:42:18 +0100 From: Sudeep Holla To: Ulf Hansson Subject: Re: [PATCH 2/5] cpuidle: psci: Fix error path via converting to a platform driver Message-ID: <20200626144218.GD27140@bogus> References: <20200615152054.6819-1-ulf.hansson@linaro.org> <20200615152054.6819-3-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200615152054.6819-3-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Vincent Guittot , Benjamin Gaignard , Saravana Kannan , linux-pm@vger.kernel.org, Stephen Boyd , Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 15, 2020 at 05:20:51PM +0200, Ulf Hansson wrote: > The current error paths for the cpuidle-psci driver, may leak memory or > possibly leave CPU devices attached to their PM domains. These are quite > harmless issues, but still deserves to be taken care of. > > Although, rather than fixing them by keeping track of allocations that > needs to be freed, which tends to become a bit messy, let's convert into a > platform driver. In this way, it gets easier to fix the memory leaks as we > can rely on the devm_* functions. > > Moreover, converting to a platform driver also enables support for deferred > probe, which subsequent changes takes benefit from. > Though I don't have strong opinion, I don't like platform device for cpuidle. But that's not main issue. I am more worried about the need for whole deferred probe for cpuidle. Is this due to OSI and Qcom dependencies ? Ideally, the firmware is already to accept suspend calls soon after they are powered on in psci f/w. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel