From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A337EC433DF for ; Fri, 26 Jun 2020 20:35:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 740FD2075D for ; Fri, 26 Jun 2020 20:35:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0CzfIYWW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sG5YmGiL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 740FD2075D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iozYHyHKRqu18r7Ndmha/fyJByhGJOyhvPlmIGhksRE=; b=0CzfIYWWinfSvnXRivXqYMvb0 LVhT5/aenh5gU8+e4uxMkaHPpD3yi/F0dkLWR//2LdbZ7oTDSZiXTgwU3b6KheeIs8qo5frzGQk02 H13fXMiX69aTCHgsW3JrO4OzBipK8Bszu+eCE041n0MEvJk0eEkIFCUk1FZu/gTUV5whC20s+0iZh c+BdfI0/3364EkvcGPey03/IT2Q8H8HBT/0U0ZGwtxxt9qt1UgvO+F3fJSFvX43IirazZ7KvFYK7S CioLliv/rgtSpRVqLO/xPTuujuBx80s11NsrTZaEDJDwIcrG51r3+prYtBDPk7vH+qHsTd+y/YCW5 82DGq+TZw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jov2k-0008S6-Na; Fri, 26 Jun 2020 20:33:50 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jov2j-0008Ro-1J for linux-arm-kernel@merlin.infradead.org; Fri, 26 Jun 2020 20:33:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=muCBI7s65fCu6XvFDeyL7ajjwHqOVhy/VA4aAMDGFFY=; b=sG5YmGiLIgq1FkTAp3MEVjRvoI BHYW35ZaaKgT987/tzq02hbhvJq/roGKEgVGVqLls+Al+7/INW1PB8T2RCoiduYumQNXxBy79xJ92 VnTvA6tdt+eIQVky0Y9hafTSLWlsi7LEKS96RzDaejeuvijQFW41ySv9QCYwExE6cN1wkTNvAMD9f 6GRiqd6hN448owCEv1ddU8upEAFv/M0yBbVs5euXiwNDVcE8bBQ2v0A7TQW0y015b3ROG+yofcjsD 4gejqchhf6XmY2x3r5TkTxGZiJKPBRj8Uw2bREtqKEpB9DmDBmsYILgWrs12o8nDiGtNAZe7zS6H2 i8wotdTg==; Received: from vps0.lunn.ch ([185.16.172.187]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jov2X-0001N4-I1 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 20:33:46 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1jov2J-002PkS-VC; Fri, 26 Jun 2020 22:33:23 +0200 Date: Fri, 26 Jun 2020 22:33:23 +0200 From: Andrew Lunn To: Daniel =?iso-8859-1?Q?Gonz=E1lez?= Cabanelas Subject: Re: [PATCH] ARM: dts: dlink-dns327l: fix reg-init PHY Message-ID: <20200626203323.GH535869@lunn.ch> References: <10150060.RLU44xrj3c@tool> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <10150060.RLU44xrj3c@tool> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200626_213340_057350_E92D95F0 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, jason@lakedaemon.net, gregory.clement@bootlin.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 26, 2020 at 08:39:05PM +0200, Daniel Gonz=E1lez Cabanelas wrote: > The marvell PHY reg-init registers for the D-Link DNS-327L are wrong. > Currently the first field is used to set the page 2, but this is > pointless. The usage is not correct, and we are setting the wrong > registers. > = > Fix it. > = > Signed-off-by: Daniel Gonz=E1lez Cabanelas > --- > arch/arm/boot/dts/armada-370-dlink-dns327l.dts | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > = > diff --git a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts b/arch/arm/bo= ot/dts/armada-370-dlink-dns327l.dts > index baa459dd5..2008c6eaa 100644 > --- a/arch/arm/boot/dts/armada-370-dlink-dns327l.dts > +++ b/arch/arm/boot/dts/armada-370-dlink-dns327l.dts > @@ -247,9 +247,8 @@ &uart1 { > &mdio { > phy0: ethernet-phy@0 { /* Marvell 88E1318 */ > reg =3D <0>; > - marvell,reg-init =3D <0x0 0x16 0x0 0x0002>, Interesting. That is writing to the page register, to change to page 2! So this might of worked with an earlier implementation. But not now. > - <0x0 0x19 0x0 0x0077>, > - <0x0 0x18 0x0 0x5747>; > + marvell,reg-init =3D <0x2 0x19 0x0 0x0077>, > + <0x2 0x18 0x0 0x5747>; Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel