From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD20BC433DF for ; Fri, 26 Jun 2020 20:58:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C0CA2070A for ; Fri, 26 Jun 2020 20:58:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fAlbwmcM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C0CA2070A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DwuqCMiRl6X+X1AWvRw0h1dIcVDkBETv96YPbpo7T0k=; b=fAlbwmcM/Y/LG77R9o/2m2UJp ZvoowZTgUunYH8XxrX1DhQ8oN2Jl6I5F/CUpFd/vT6rwPoX3LZCiYPe6JfDZA96HdhxI4Ig/0Ircy NTE+kZC9SDPl+M8R58ErO9SVjAplpIC67xOqTwOk50eGeL+5YPJDh+zNMAVFlxifDHTY3jTSva5iL q3IZccsT5hNSSW921uIyhkBOIm2Y9SuzVK1480TNlA4FRorX8kIA/ogM68xFkA/k2ous4YSX6GFAm 0+fwQqSKez+apOfoouMnJlCLYi02NxowR2baOtoEio/gHaQYtsSYeQ6PaAtWNzmWd+Na3RNxTPVXe 6/GsYhVrA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jovPD-0003pS-GU; Fri, 26 Jun 2020 20:57:03 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jovPA-0003oZ-C7 for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2020 20:57:02 +0000 X-Originating-IP: 86.202.110.81 Received: from localhost (lfbn-lyo-1-15-81.w86-202.abo.wanadoo.fr [86.202.110.81]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 0016520002; Fri, 26 Jun 2020 20:56:58 +0000 (UTC) Date: Fri, 26 Jun 2020 22:56:58 +0200 From: Alexandre Belloni To: Lee Jones Subject: Re: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments Message-ID: <20200626205658.GV131826@piout.net> References: <20200625064619.2775707-1-lee.jones@linaro.org> <20200625064619.2775707-10-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200625064619.2775707-10-lee.jones@linaro.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Boris Brezillon , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Ludovic Desroches , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/06/2020 07:46:18+0100, Lee Jones wrote: > Kerneldoc valication gets confused if syntax isn't "@.*: ". > > Adding the missing colons squashes the following W=1 warnings: > > drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not described in 'atmel_smc_cs_conf_apply' > drivers/mfd/atmel-smc.c:268: warning: Function parameter or member 'conf' not described in 'atmel_hsmc_cs_conf_apply' > Reviewed-by: Alexandre Belloni > Cc: > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Ludovic Desroches > Cc: Boris Brezillon > Signed-off-by: Lee Jones > --- > drivers/mfd/atmel-smc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c > index 17bbe9d1fa740..4aac96d213369 100644 > --- a/drivers/mfd/atmel-smc.c > +++ b/drivers/mfd/atmel-smc.c > @@ -237,7 +237,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_cycle); > * atmel_smc_cs_conf_apply - apply an SMC CS conf > * @regmap: the SMC regmap > * @cs: the CS id > - * @conf the SMC CS conf to apply > + * @conf: the SMC CS conf to apply > * > * Applies an SMC CS configuration. > * Only valid on at91sam9/avr32 SoCs. > @@ -257,7 +257,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_apply); > * @regmap: the HSMC regmap > * @cs: the CS id > * @layout: the layout of registers > - * @conf the SMC CS conf to apply > + * @conf: the SMC CS conf to apply > * > * Applies an SMC CS configuration. > * Only valid on post-sama5 SoCs. > -- > 2.25.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel