From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 399F4C433E0 for ; Sun, 28 Jun 2020 07:30:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F279320768 for ; Sun, 28 Jun 2020 07:30:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ejJYI7pG"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="uOXm1rRx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F279320768 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Tq0aWd65NOHV3RD1f3En9vIXGyw/TGTIyLNCrAjWc44=; b=ejJYI7pGymtDezfrgMs7ZTM1g m80kto8p8ZBw6DBiVw0myuVLyTyKgsywTtEWYkMkUzNiTWDJqg9QpXhMnTqHQUxPbdb8ym45t9cun uFQrFHjWsXBmYJ2r9Qvxv1sbICJ1YWTfOswM1urdyOy33SVl2ABdTPrS8xRexD0kGDmzhObiezI2n GWCsfJp7lwlWMMS3OL42Bwq49ku/bHpb8dg3wdGuvKBT2jkq6X0C/cuZGxiCS9U+KIywVLj3QUqac FnmmaVdXaenR8/Eua78MDaa/SQnJqtlG16u62xJvxykoDC0E52vaIG8fUbauiZHZYJESXjy6nleEo mgXCBKTVQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpRkD-0003EG-6N; Sun, 28 Jun 2020 07:28:53 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpRkB-0003DX-4p for linux-arm-kernel@lists.infradead.org; Sun, 28 Jun 2020 07:28:51 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C030C4FB; Sun, 28 Jun 2020 09:28:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1593329301; bh=ck+LjAkxjFbi+T46BUzZf+XpAk4V6f33vhP8DfWZQHI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uOXm1rRxayXR+zKQy3KRDZgAUKQTQRWl8eKer9/zKORUNd5yFoInZcCU7aBUs+y6Y YOr58xIXYiNhUT0myqyZxMLrTlYE7PeBX/ITh9unu3mm08hj0KPhRkuDwGD1NnIT71 ZdSA1chOyEZIx1s1yK9BircekQKa03LFbtHav0iw= Date: Sun, 28 Jun 2020 10:28:19 +0300 From: Laurent Pinchart To: Pascal Roeleven Subject: Re: [PATCH v2 2/5] drm: panel: Add Starry KR070PE2T Message-ID: <20200628072819.GB8391@pendragon.ideasonboard.com> References: <20200320112205.7100-1-dev@pascalroeleven.nl> <20200320112205.7100-3-dev@pascalroeleven.nl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200320112205.7100-3-dev@pascalroeleven.nl> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , Mark Brown , linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , Rob Herring , Thierry Reding , dri-devel@lists.freedesktop.org, Daniel Vetter , Sam Ravnborg , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Pascal, On Fri, Mar 20, 2020 at 12:21:33PM +0100, Pascal Roeleven wrote: > The KR070PE2T is a 7" panel with a resolution of 800x480. > > KR070PE2T is the marking present on the ribbon cable. As this panel is > probably available under different brands, this marking will catch > most devices. > > As I can't find a datasheet for this panel, the bus_flags are instead > from trial-and-error. The flags seem to be common for these kind of > panels as well. > > Signed-off-by: Pascal Roeleven > --- > drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index e14c14ac6..b3d257257 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2842,6 +2842,32 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > }; > > +static const struct drm_display_mode starry_kr070pe2t_mode = { > + .clock = 33000, > + .hdisplay = 800, > + .hsync_start = 800 + 209, > + .hsync_end = 800 + 209 + 1, > + .htotal = 800 + 209 + 1 + 45, > + .vdisplay = 480, > + .vsync_start = 480 + 22, > + .vsync_end = 480 + 22 + 1, > + .vtotal = 480 + 22 + 1 + 22, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc starry_kr070pe2t = { > + .modes = &starry_kr070pe2t_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 152, > + .height = 86, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, > + .connector_type = DRM_MODE_CONNECTOR_LVDS, I'm trying to fix inconsistencies in the panel-simple driver, and this caught my eyes. MEDIA_BUS_FMT_RGB888_1X24 isn't a correct format for LVDS panels. MEDIA_BUS_FMT_RGB666_1X7X3_SPWG, MEDIA_BUS_FMT_RGB888_1X7X4_SPWG or MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA should be used instead. As I couldn't find documentation for the panel, I can't tell which format is correct. Could you please help ? > +}; > + > static const struct drm_display_mode starry_kr122ea0sra_mode = { > .clock = 147000, > .hdisplay = 1920, > @@ -3474,6 +3500,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "shelly,sca07010-bfn-lnn", > .data = &shelly_sca07010_bfn_lnn, > + }, { > + .compatible = "starry,kr070pe2t", > + .data = &starry_kr070pe2t, > }, { > .compatible = "starry,kr122ea0sra", > .data = &starry_kr122ea0sra, -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel