From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A271C433DF for ; Mon, 29 Jun 2020 09:53:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9FD423730 for ; Mon, 29 Jun 2020 09:53:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DNlIbk0P"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="SBvp+p2J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9FD423730 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e+zYsaxgyirE1gh6tEcG4f0O4QsJyBqKuIHEqF9cbD8=; b=DNlIbk0PDqNvgAJ8I3aH8xrqs PkVbrXHrUXZDAOnLV8h+TFnXe72Dxwl2fgzGbEE45sf3zqXc8KrfyC0NfQwRSaQFGQ3M4DQcQX1mu UK30abYm+Yy6kza0Zq/nT6YX6zevwt6UnUoU//QCWtcB8clzI0zcLbAIEAdiDloW1Wn68LhmIxcP+ 6ZPOhjfZFkD9lmDEAPH6yYtetkw/K/vYBTFpylpZYTtWruX0DNlxJ8mhdbsmEU1zKjh7ictP3Dp77 g9zOYWmLusdq+eok0rArw6vFoBslF3kdLgQWc42HZdKmiisYgwbTNvx0sg12paxuk3TYXuOY2rOZI VhBBX5+6Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpqSV-0002YC-Rr; Mon, 29 Jun 2020 09:52:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpqST-0002Xy-90; Mon, 29 Jun 2020 09:52:13 +0000 Received: from localhost (unknown [122.182.251.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 994E1235FF; Mon, 29 Jun 2020 09:52:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593424331; bh=FvnI01MrqwrGCSn1pXUy+BedbEZpbcC56ZDWbIF8mFk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SBvp+p2JVOK+mbuCO0DyD4m6cTuqvLnfQwf0MoDwwc8qToNCpesGe8dGwvR4NHuwO Um0wpFOI/f3glHy7M5ECcY13Z3m0pS1xZjX2DpfInnFAL2wXMZ7j9bYOC/Yc/h/5lx oe0ArLBMZ0u5XA50l1TuR2YiQ+bH3SrCAP+UPgQ0= Date: Mon, 29 Jun 2020 15:22:07 +0530 From: Vinod Koul To: Amit Tomer Subject: Re: [PATCH v4 02/10] dmaengine: Actions: Add support for S700 DMA engine Message-ID: <20200629095207.GG2599@vkoul-mobl> References: <1591697830-16311-1-git-send-email-amittomer25@gmail.com> <1591697830-16311-3-git-send-email-amittomer25@gmail.com> <20200624061529.GF2324254@vkoul-mobl> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andre Przywara , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, cristian.ciocaltea@gmail.com, Manivannan Sadhasivam , dmaengine@vger.kernel.org, dan.j.williams@intel.com, Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29-06-20, 13:49, Amit Tomer wrote: > Hi Vinod, > > Thanks for having a look and providing the comments. > > > Is the .compatible documented, Documentation patch should come before > > the driver use patch in a series > > Yes, this new compatible string is documented in patch (05/10). > I would make it as a patch (1/10). > > > > static int owl_dma_probe(struct platform_device *pdev) > > > { > > > struct device_node *np = pdev->dev.of_node; > > > struct owl_dma *od; > > > int ret, i, nr_channels, nr_requests; > > > + const struct of_device_id *of_id = > > > + of_match_device(owl_dma_match, &pdev->dev); > > > > You care about driver_data rather than of_id, so using > > of_device_get_match_data() would be better.. > > Okay. would take care of it in next version. > > > > od = devm_kzalloc(&pdev->dev, sizeof(*od), GFP_KERNEL); > > > if (!od) > > > @@ -1083,6 +1116,8 @@ static int owl_dma_probe(struct platform_device *pdev) > > > dev_info(&pdev->dev, "dma-channels %d, dma-requests %d\n", > > > nr_channels, nr_requests); > > > > > > + od->devid = (enum owl_dma_id)(uintptr_t)of_id->data; > > > > Funny casts, I dont think you need uintptr_t! > > But without this cast, clang compiler emits following warning: > > warning: cast to smaller integer type 'enum owl_dma_id' from 'const void *' > [-Wvoid-pointer-to-enum-cast] If you use of_device_get_match_data() you will not fall into this :) -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel