From: Tony Lindgren <tony@atomide.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND 07/10] regulator: cpcap-regulator: Remove declared and set, but never used variable 'ignore'
Date: Mon, 29 Jun 2020 11:26:22 -0700 [thread overview]
Message-ID: <20200629182622.GC37466@atomide.com> (raw)
In-Reply-To: <20200625191708.4014533-8-lee.jones@linaro.org>
* Lee Jones <lee.jones@linaro.org> [200625 19:18]:
> It's okay to not check the return value that you're not conserned
> about, however it is not okay to assign a variable and not check or
> use the result.
>
> Fixes W=1 warnings(s):
>
> drivers/regulator/cpcap-regulator.c:172:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable]
> 172 | int error, ignore;
> | ^~~~~~
> drivers/regulator/cpcap-regulator.c: In function ‘cpcap_regulator_disable’:
> drivers/regulator/cpcap-regulator.c:196:13: warning: variable ‘ignore’ set but not used [-Wunused-but-set-variable]
> 196 | int error, ignore;
Acked-by: Tony Lindgren <tony@atomide.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-29 18:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 19:16 [RESEND 00/10] Fix a bunch of W=1 warnings in Regulator Lee Jones
2020-06-25 19:16 ` [RESEND 01/10] regulator: consumer: Supply missing prototypes for 3 core functions Lee Jones
2020-06-25 19:17 ` [RESEND 02/10] regulator: devres: Fix issues with kerneldoc headers Lee Jones
2020-06-25 19:17 ` [RESEND 03/10] regulator: of_regulator: Add missing colon for rdev kerneldoc argument Lee Jones
2020-06-25 19:17 ` [RESEND 04/10] regulator: dbx500-prcmu: Remove unused function dbx500_regulator_testcase() Lee Jones
2020-07-07 12:41 ` Linus Walleij
2020-06-25 19:17 ` [RESEND 05/10] regulator: ab8500: Remove unused embedded struct expand_register Lee Jones
2020-07-07 12:42 ` Linus Walleij
2020-06-25 19:17 ` [RESEND 06/10] regulator: wm8350-regulator: Repair odd formatting in documentation Lee Jones
2020-06-26 10:42 ` Charles Keepax
2020-06-25 19:17 ` [RESEND 07/10] regulator: cpcap-regulator: Remove declared and set, but never used variable 'ignore' Lee Jones
2020-06-29 18:26 ` Tony Lindgren [this message]
2020-06-25 19:17 ` [RESEND 08/10] regulator: cpcap-regulator: Demote kerneldoc header to standard comment Lee Jones
2020-06-25 19:17 ` [RESEND 09/10] regulator: da9063-regulator: Fix .suspend 'initialized field overwritten' warnings Lee Jones
2020-06-26 8:49 ` Adam Thomson
2020-06-25 19:17 ` [RESEND 10/10] regulator: max14577-regulator: Demote kerneldoc header to standard comment Lee Jones
2020-06-25 19:48 ` [RESEND 00/10] Fix a bunch of W=1 warnings in Regulator Mark Brown
2020-06-26 9:36 ` Lee Jones
2020-06-26 13:35 ` Mark Brown
2020-06-26 15:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629182622.GC37466@atomide.com \
--to=tony@atomide.com \
--cc=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).