From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 846BDC433DF for ; Mon, 29 Jun 2020 23:54:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52452206B6 for ; Mon, 29 Jun 2020 23:54:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MtBZDZ8l"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xh/Vue0q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52452206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZlWx8tpS5MB0TSZb3gN6yedixr7+sAY8Ej7oWCcy8eg=; b=MtBZDZ8lfOncJ04iR2jAKEdvX LCYVPhevAbS/RClBOwiWmfH1Kf64xeIT6M/U/mVCXWbDBSohm8nJEGFD2jm5dkJ5Beg+DzXKU6eRa bTLIZVZ3NmiY9NI/E2CGnRcl3WhuWk1ovWW03DtmOv5cyRmz5QX491Gwp+kSH7EAP/od6O7+VsIve WLvHhQURqbPuDPLw2MB2LDU9JEHXG/NiSaf7m7GbdYOVLM/sJuzSrXjVFe4Fd5uQuAL7HaxaNd67s 2K8k85Fi2v4zgvbEBu3LHKRSfO16yyCxcI893P3q40+6hB3sSIlvAf5n+dIakiPoGLyZuxRMjcpAQ vYLNAKpOQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jq3a8-0000Xa-6K; Mon, 29 Jun 2020 23:53:00 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jq3a5-0000Wr-OV for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 23:52:58 +0000 Received: by mail-pg1-x543.google.com with SMTP id p3so9057558pgh.3 for ; Mon, 29 Jun 2020 16:52:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZGfMUVHQlxfLiTJM1WLol0nRk5sgJRj1wqf4MkKus5s=; b=Xh/Vue0q76LlXZ1IVtyp0plcHCg+yS3sou6eCNEplyeHb1RBascLD5jXemJu3z6ioE PEQnSUC8EAaBfx1BtSvvbgAwQNJJ2ucrQrroIdlGPAQQv/7jpS25OnRr1gUi9wsK/b8D RXvb9lS0v+ikbVT8ubeL0uwKOXgpuTQlKgq3cZGlJyHIg97a4iDob4bDoRx23oRNdD4r xS4iFrH3Nj5YbxJ5wrinYNGmgIzT/kcoFq6Q4gZt8F4LDM8PTotHdQ34JLVbDkoMMSoG EZmJRILAhOY7EzQ4a7o/NpFeYhXMbTo5ogcOKUxCV0/o/kqWxbIp7d4kZl3BvTlhgcMg 2qdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZGfMUVHQlxfLiTJM1WLol0nRk5sgJRj1wqf4MkKus5s=; b=l/AMfEV9LgHZMTaOrzSG+G9IJHkJVKYed7XgxWjoJ94Jb78T+DCjKT0Ct7kA3K3pE4 0Kxk5HD1GWjRKBIrLsPOf3x1AtNF3NlAHnvSnxVLiAuJogaM8tqtEiHn2YLEsXxPFxIm zA3wswDSM4KJe9Il96UZGDf/wKF7yeKu2Pux6nubbTpvvgcjRCM9ZeXwuD3A0A3xd216 55boZQ7rNvH7pke+iVJpDTpXq4Onefew+hgGG73gkBp81ZVhZce/xLTaOTRfgtt+fwe5 xijrnKRGqlJZMj1VsVgRU14lxMU98BA54YF+G38sXPumd58AmY5kV0nGfj1FORqZ1IIA qMJg== X-Gm-Message-State: AOAM532CC7wpcWPXmNpfT5g3uVuLuF0UXLUCbtct3HsG7JCQ7yc8Tu7w 42Lqvz3Zmak2lGIBFV9ojVA= X-Google-Smtp-Source: ABdhPJyHRiIXYw7M7C5K2woDsZLaiq4jmATiThuvEjJzM6tygMJ9vTs50c26tg/Ye6SHSxXi2HFHdA== X-Received: by 2002:aa7:988f:: with SMTP id r15mr7658817pfl.2.1593474775473; Mon, 29 Jun 2020 16:52:55 -0700 (PDT) Received: from Asurada-Nvidia (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id y18sm662361pff.10.2020.06.29.16.52.54 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Jun 2020 16:52:55 -0700 (PDT) Date: Mon, 29 Jun 2020 16:52:20 -0700 From: Nicolin Chen To: Krishna Reddy Subject: Re: [PATCH v7 1/3] iommu/arm-smmu: add NVIDIA implementation for dual ARM MMU-500 usage Message-ID: <20200629235219.GA14616@Asurada-Nvidia> References: <20200629022838.29628-1-vdumpa@nvidia.com> <20200629022838.29628-2-vdumpa@nvidia.com> <20200629215124.GD27967@Asurada-Nvidia> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sachin Nikam , Mikko Perttunen , Bryan Huntsman , "will@kernel.org" , "joro@8bytes.org" , "linux-kernel@vger.kernel.org" , Pritesh Raithatha , Timo Alho , "iommu@lists.linux-foundation.org" , Nicolin Chen , "linux-tegra@vger.kernel.org" , Yu-Huan Hsu , Thierry Reding , "robin.murphy@arm.com" , "linux-arm-kernel@lists.infradead.org" , Bitan Biswas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2020 at 10:49:31PM +0000, Krishna Reddy wrote: > >> + if (!nvidia_smmu->bases[0]) > >> + nvidia_smmu->bases[0] = smmu->base; > >> + > >> + return nvidia_smmu->bases[inst] + (page << smmu->pgshift); } > > >Not critical -- just a nit: why not put the bases[0] in init()? > > smmu->base is not available during nvidia_smmu_impl_init() call. It is set afterwards in arm-smmu.c. > It can't be avoided without changing the devm_ioremap() and impl_init() call order in arm-smmu.c. I see...just checked arm_ssmu_impl_init(). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel