From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C95AC433E1 for ; Tue, 30 Jun 2020 21:09:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CBCF2053B for ; Tue, 30 Jun 2020 21:09:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Bdr0xPEU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oQ+3Bpe1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CBCF2053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VqM3t+GnNFdoZg0L+q1k9FK5yNzvJ5WbmFhf9jhUU4Q=; b=Bdr0xPEU9NIJ6OX37Mcssg5F5 fDI9+rWIBHipUsi606kswlznU4vSY0ARh8X+k0TaLikw2gx9eZHr3QN1glAZcUH4QlYhaAAWTBDC6 V/+U65CR19eiLewdL/flaIK4NHzjuXdQnUvqn42tEfHb/3RpYySCgHap1YrCIA8hR7nh18hTHLm7d dcqeIQjWV+7eLHM+CG40P+EiggKOVMZ5ia74mxDbiWzvk+Z3uVUZaP0W6QXDZq19ErJixprLzbDCj apCvPSduiW/zyNk8SLC8elHQR/PCRJdwTihXkr/kqQk4UJ5x2DlvgDAKBnm59Ef5WR7XEDbv3M8a/ hEO46ENNA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqNUA-0006zW-Dj; Tue, 30 Jun 2020 21:08:10 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqNU7-0006ys-So for linux-arm-kernel@lists.infradead.org; Tue, 30 Jun 2020 21:08:08 +0000 Received: by mail-pf1-x444.google.com with SMTP id q17so9946504pfu.8 for ; Tue, 30 Jun 2020 14:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TztK3Rxr7Fn5cSwLph8w89UZSXGdiaGuD8YdgAZBLhc=; b=oQ+3Bpe1J49+YLFni4XKFQ3sa+QK/5kDOZgXHaTp/mNo/nfT4Jl8WEoDZoGiqe2yqY ztdhanr9s4Em/BqMGX5oakTrwq22JKROPHNQHFkPnhIUEMxk3eg1TQViyJtSnP5gEcmC NHLbYmEGMn9WmX3NI2dl+MGasn+a6NsvaEl5/w0gyCrQmWIq6SbbNKalnU08ZxlgE5Fm vuZ4lT6Q0V/jBEFPYU+2Eh04WgRyaxmAgtU7zBejXK3+O0bNACuLgAAzHfIeFFlPA89s 5PMCVE2hyQhbSCnqR3L++ETZb7lAJ4ZhydHlk0E5mQCGnZaxHA8Mm3QIj//j3xKCBD7h 4ZiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TztK3Rxr7Fn5cSwLph8w89UZSXGdiaGuD8YdgAZBLhc=; b=tZawv5ujahvPiNM32xjNphti1CyMPJCgK8bg09FQKQvrY/gkqlthiKQN8GAJ+pFGSc ioQ6nfiYDSFFKZUhJ0POKI/dFu7R3P/QcPSIF2BN5kVYfLPlgJyC28robjSof5gnmcBB PwRh0H8ZzyVKLSdKB0dYRa5iuAguy81QIw5sy+PlQyVgf7j30pihxlxX1E4m88Qs5sAi D3A/q2xVIdRK4gDSMR2ZJhjg9ZuWhBiuErWwAjmUvCvqgQmGpcojebKNtMEEI998VXfQ A4rvpUeaC01BVn0JX6jFU5/ZJd7fSmC8F4TW8dtAmvrUCGAPYgkg0ko2D3JvtCPXQLtF wOMA== X-Gm-Message-State: AOAM533zO+WbdaVBAxbWnK26jYsS4MM4LtZJZCaG1rIq8rEDT3HMdXVv DEHU1Gfz1BTOQG0muf2z0w8= X-Google-Smtp-Source: ABdhPJzIJ1W4d01lMXP9WUjf+Cym20TVKfnvze08MwIPXiAPLCLsDGxc/7HfWssoCd2lnMp6OOM7nA== X-Received: by 2002:a65:67d0:: with SMTP id b16mr2083343pgs.60.1593551283634; Tue, 30 Jun 2020 14:08:03 -0700 (PDT) Received: from ubuntu-s3-xlarge-x86 ([2604:1380:1000:7a00::1]) by smtp.gmail.com with ESMTPSA id s15sm3548300pfm.129.2020.06.30.14.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 14:08:03 -0700 (PDT) Date: Tue, 30 Jun 2020 14:08:01 -0700 From: Nathan Chancellor To: Aisheng Dong Subject: Re: [PATCH] mailbox: imx: Mark PM functions as __maybe_unused Message-ID: <20200630210801.GA3920527@ubuntu-s3-xlarge-x86> References: <20200623010403.517691-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200630_170807_976689_E7E09018 X-CRM114-Status: GOOD ( 16.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anson Huang , Shawn Guo , Sascha Hauer , Jassi Brar , "linux-kernel@vger.kernel.org" , dl-linux-imx , Pengutronix Kernel Team , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 23, 2020 at 02:14:05AM +0000, Aisheng Dong wrote: > > From: Nathan Chancellor > > Sent: Tuesday, June 23, 2020 9:04 AM > > > > When CONFIG_PM and CONFIG_PM_SLEEP are unset, the following warnings > > occur: > > > > drivers/mailbox/imx-mailbox.c:638:12: warning: 'imx_mu_runtime_resume' > > defined but not used [-Wunused-function] > > 638 | static int imx_mu_runtime_resume(struct device *dev) > > | ^~~~~~~~~~~~~~~~~~~~~ > > drivers/mailbox/imx-mailbox.c:629:12: warning: 'imx_mu_runtime_suspend' > > defined but not used [-Wunused-function] > > 629 | static int imx_mu_runtime_suspend(struct device *dev) > > | ^~~~~~~~~~~~~~~~~~~~~~ > > drivers/mailbox/imx-mailbox.c:611:12: warning: 'imx_mu_resume_noirq' > > defined but not used [-Wunused-function] > > 611 | static int imx_mu_resume_noirq(struct device *dev) > > | ^~~~~~~~~~~~~~~~~~~ > > drivers/mailbox/imx-mailbox.c:601:12: warning: 'imx_mu_suspend_noirq' > > defined but not used [-Wunused-function] > > 601 | static int imx_mu_suspend_noirq(struct device *dev) > > | ^~~~~~~~~~~~~~~~~~~~ > > > > Mark these functions as __maybe_unused, which is the standard procedure for > > PM functions. > > > > Fixes: bb2b2624dbe2 ("mailbox: imx: Add runtime PM callback to handle MU > > clocks") > > Signed-off-by: Nathan Chancellor > > Thanks for catching this. > > Reviewed-by: Dong Aisheng > > Regards > Aisheng Thank you for the review :) These warnings were introduced by a patch in this merge window, it would be nice if this patch could be fixed up as a fix for that but I understand if it is too late for that. Cheers, Nathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel