From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F78C433DF for ; Wed, 1 Jul 2020 11:24:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 000A820722 for ; Wed, 1 Jul 2020 11:24:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mPta1UGK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 000A820722 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ri62IP8JXEI0CccfY9EUij51b0VQFXq5pZNCEl41Q8I=; b=mPta1UGKgyBYgvc1br93slQuk DB8LZ2uCGu5CLUBeqqsq/EUoBz8G5IhVRPQwxkBqcooEVT7KiHyjK47FcRNlCQ0BZDtumMge5qFV9 lr091JDpbXFv8t0ItkSsXyXwabuybEOrabptUbLd2qkKT1WvX7Ghf+gREOKXzRB/WMe2WlyvN5wkR YRZbRtD2WKL+JkLGe54yCOoDAD2tpw8jmvgO7xI/s9zDXVk/x6r7KLa32ZGZtNaBOZjtcTq2sEhz9 0NkLxjjnyZH7ad73R/uVIWp+fO5112CWTwFvKnWukoiH15uqxt02Hv9cFSXrhf0gaZbmRZjaO6O0k wrOdjZxbA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqapb-0003qy-KO; Wed, 01 Jul 2020 11:23:11 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqapZ-0003qR-Hx; Wed, 01 Jul 2020 11:23:10 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 3BBDA27DAFB; Wed, 1 Jul 2020 12:23:06 +0100 (BST) Date: Wed, 1 Jul 2020 13:23:03 +0200 From: Boris Brezillon To: Enric Balletbo i Serra Subject: Re: [RESEND PATCH 1/3] drm/mediatek: mtk_dpi: Rename bridge to next_bridge Message-ID: <20200701132303.047ea605@collabora.com> In-Reply-To: <20200518173909.2259259-2-enric.balletbo@collabora.com> References: <20200518173909.2259259-1-enric.balletbo@collabora.com> <20200518173909.2259259-2-enric.balletbo@collabora.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_072309_696881_58F29507 X-CRM114-Status: GOOD ( 20.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , drinkcat@chromium.org, Philipp Zabel , narmstrong@baylibre.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, a.hajda@samsung.com, linux-mediatek@lists.infradead.org, laurent.pinchart@ideasonboard.com, Daniel Vetter , hsinyi@chromium.org, matthias.bgg@gmail.com, Collabora Kernel ML , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 18 May 2020 19:39:07 +0200 Enric Balletbo i Serra wrote: > This is really a cosmetic change just to make a bit more readable the > code after convert the driver to drm_bridge. The bridge variable name > will be used by the encoder drm_bridge, and the chained bridge will be > named next_bridge. > > Signed-off-by: Enric Balletbo i Serra > Reviewed-by: Chun-Kuang Hu > --- > > drivers/gpu/drm/mediatek/mtk_dpi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 7fbfa95bab09..7112125dc3d1 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -61,7 +61,7 @@ enum mtk_dpi_out_color_format { > struct mtk_dpi { > struct mtk_ddp_comp ddp_comp; > struct drm_encoder encoder; > - struct drm_bridge *bridge; > + struct drm_bridge *next_bridge; Did you consider moving the drm_of_find_panel_or_bridge() call to mtk_dpi_bind() so you can get rid of this field? This makes we realize there's no refcounting on bridges, which means the bridge can vanish between the drm_of_find_panel_or_bridge() and drm_bridge_attach() calls :-/. > void __iomem *regs; > struct device *dev; > struct clk *engine_clk; > @@ -607,7 +607,7 @@ static int mtk_dpi_bind(struct device *dev, struct device *master, void *data) > /* Currently DPI0 is fixed to be driven by OVL1 */ > dpi->encoder.possible_crtcs = BIT(1); > > - ret = drm_bridge_attach(&dpi->encoder, dpi->bridge, NULL, 0); > + ret = drm_bridge_attach(&dpi->encoder, dpi->next_bridge, NULL, 0); > if (ret) { > dev_err(dev, "Failed to attach bridge: %d\n", ret); > goto err_cleanup; > @@ -747,11 +747,11 @@ static int mtk_dpi_probe(struct platform_device *pdev) > } > > ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > - NULL, &dpi->bridge); > + NULL, &dpi->next_bridge); > if (ret) > return ret; > > - dev_info(dev, "Found bridge node: %pOF\n", dpi->bridge->of_node); > + dev_info(dev, "Found bridge node: %pOF\n", dpi->next_bridge->of_node); > > comp_id = mtk_ddp_comp_get_id(dev->of_node, MTK_DPI); > if (comp_id < 0) { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel