From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D70C433E2 for ; Wed, 1 Jul 2020 13:57:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B322020663 for ; Wed, 1 Jul 2020 13:57:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GLytyTzh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="McqG19/F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B322020663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3D/oTFLxOK7FLaij45ZxWP78RkuPTW3tW0u0FPJhsF8=; b=GLytyTzh7M6NY4jmQ5sC2CFm1 7DuOZY/XN0aUPgzJQN4oAGlhDVJuy/op8jJKKTPVPun8/JTHsr0SB8FexNRFfMII0IKkWNxx0MEc1 CuyKp3n/zTetIiMw9j764Z9u9/cNwB/fEPzPxqTd/309hYinDs+D2lRDsi82ruMMau1Xr+fJTFYfS J3e3p4iwFCG6xDMDY7Bnm2oiEhIr1jfR3A4riGkhz1gEp9OMDh8VLoPO9u3jBAS2Laumno1OaSuRy 5Z8iRjch9VlRfQLZd0XaMEtQl8SRks5QXEXGUaFH1OGAQEWRKQh+ih9k7rmVH+OdKh7TidGKvbTeo VGr93Zf9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqdDK-0004Ot-Qm; Wed, 01 Jul 2020 13:55:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqdDI-0004O2-I1 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 13:55:49 +0000 Received: from localhost (unknown [122.182.251.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC66D207BB; Wed, 1 Jul 2020 13:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593611747; bh=9ZMBOmEsNNbmda5wTJJt2w3hw5mgWBnq6kQdLlk1rMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=McqG19/F06d2c71ulZIQP7lyRRslCz3AfxniwHs4SxukSr0Uwl28n/tEM1ihTh7fK ocb0+p3URXbtNwodO8D6Zd+cSWmwmNIq9VS2iB0w6EWGt4stNKeWjLCrK0OgVDpe3q DKdckN4ohzZcf7e75slrPRuQn5amfPOJEamQ4z3c= Date: Wed, 1 Jul 2020 19:25:43 +0530 From: Vinod Koul To: Laurent Pinchart Subject: Re: [PATCH] phy: zynqmp: Fix unused-function compiler warning Message-ID: <20200701135543.GA2599@vkoul-mobl> References: <20200701090438.21224-1-tklauser@distanz.ch> <20200701131902.GC27013@pendragon.ideasonboard.com> <20200701133643.GZ2599@vkoul-mobl> <20200701134443.GE27013@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701134443.GE27013@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_095548_657479_0848310F X-CRM114-Status: UNSURE ( 9.19 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anurag Kumar Vulisha , linux-kernel@vger.kernel.org, Michal Simek , Tobias Klauser , Kishon Vijay Abraham I , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Laurent, On 01-07-20, 16:44, Laurent Pinchart wrote: > > How about marking it as __maybe_unused instead? > > I don't mind either, I'll let Tobias decide, but his patch seems fine, > is there a drawback in his approach ? If it's just a matter of personal > preference, I'd rather not require a v2. __maybe_unused is the preferred way to do as Documented in Documentation/process/coding-style.rst and makes code look neater.. Thanks -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel