From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA75C433DF for ; Wed, 1 Jul 2020 16:03:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1E7C206C3 for ; Wed, 1 Jul 2020 16:03:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MoAVhprn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1E7C206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=puri.sm Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HHRlxY7DP+RqRnI7xz4SfI0LqQ7z0kClEuDmiwvbEG4=; b=MoAVhprn4CAk3Rsa0LBQMirLN RCT0dtMiibcj/iwabdHVgefXJNdcwo47MW+Ywn1L58yKGQZEggNOCcKqq8qUKHAjpstErIGCBiedg zSqXGNWjsoMwfueWJ95vbvHz33yg2FX5rDy6LppM3WRilIgXEQcbqYgdrttYk/lBfLQCswj4Q7x15 E5jVPvAGKJytQupM59BWKmW2MoQbzPj/3DYa5OcSz2LBUvMrlu4+47Vv/MAVk67l33MzBSETz3Ogw EJrlwiI+9opRHtratDLxEdGhTIPanYybYXyNN7DI7xBrPC65duf7hIl/gbJn5H6klD9PEMraJnJC1 60r6soVJA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqfBs-0007tp-P8; Wed, 01 Jul 2020 16:02:28 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqfBp-0007sh-RT for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 16:02:26 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 9CCCFFB04; Wed, 1 Jul 2020 18:02:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vPbvHeupN1Nh; Wed, 1 Jul 2020 18:02:23 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 3891B40972; Wed, 1 Jul 2020 18:02:23 +0200 (CEST) Date: Wed, 1 Jul 2020 18:02:23 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Ondrej Jirman Subject: Re: [PATCH v6 07/13] drm/panel: st7703: Move code specific to jh057n closer together Message-ID: <20200701160223.GF174356@bogon.m.sigxcpu.org> References: <20200701103126.1512615-1-megous@megous.com> <20200701103126.1512615-8-megous@megous.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701103126.1512615-8-megous@megous.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_120226_012720_DFC6EDF0 X-CRM114-Status: GOOD ( 16.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Purism Kernel Team , Samuel Holland , David Airlie , Linus Walleij , Bhushan Shah , Chen-Yu Tsai , Rob Herring , linux-kernel@vger.kernel.org, Martijn Braam , linux-sunxi@googlegroups.com, Thierry Reding , Maxime Ripard , Daniel Vetter , Sam Ravnborg , Luca Weiss , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jul 01, 2020 at 12:31:20PM +0200, Ondrej Jirman wrote: > It's better than having it spread around the driver. Reviewed-by: Guido G=FCnther = > = > Signed-off-by: Ondrej Jirman > Reviewed-by: Linus Walleij > --- > drivers/gpu/drm/panel/panel-sitronix-st7703.c | 50 +++++++++---------- > 1 file changed, 25 insertions(+), 25 deletions(-) > = > diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/= drm/panel/panel-sitronix-st7703.c > index 08cbc316266c..d03aab10cfef 100644 > --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c > +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c > @@ -153,6 +153,31 @@ static int jh057n_init_sequence(struct st7703 *ctx) > return 0; > } > = > +static const struct drm_display_mode jh057n00900_mode =3D { > + .hdisplay =3D 720, > + .hsync_start =3D 720 + 90, > + .hsync_end =3D 720 + 90 + 20, > + .htotal =3D 720 + 90 + 20 + 20, > + .vdisplay =3D 1440, > + .vsync_start =3D 1440 + 20, > + .vsync_end =3D 1440 + 20 + 4, > + .vtotal =3D 1440 + 20 + 4 + 12, > + .vrefresh =3D 60, > + .clock =3D 75276, > + .flags =3D DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > + .width_mm =3D 65, > + .height_mm =3D 130, > +}; > + > +struct st7703_panel_desc jh057n00900_panel_desc =3D { > + .mode =3D &jh057n00900_mode, > + .lanes =3D 4, > + .mode_flags =3D MIPI_DSI_MODE_VIDEO | > + MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_VIDEO_SYNC_PULSE, > + .format =3D MIPI_DSI_FMT_RGB888, > + .init_sequence =3D jh057n_init_sequence, > +}; > + > static int st7703_enable(struct drm_panel *panel) > { > struct st7703 *ctx =3D panel_to_st7703(panel); > @@ -226,31 +251,6 @@ static int st7703_prepare(struct drm_panel *panel) > return ret; > } > = > -static const struct drm_display_mode jh057n00900_mode =3D { > - .hdisplay =3D 720, > - .hsync_start =3D 720 + 90, > - .hsync_end =3D 720 + 90 + 20, > - .htotal =3D 720 + 90 + 20 + 20, > - .vdisplay =3D 1440, > - .vsync_start =3D 1440 + 20, > - .vsync_end =3D 1440 + 20 + 4, > - .vtotal =3D 1440 + 20 + 4 + 12, > - .vrefresh =3D 60, > - .clock =3D 75276, > - .flags =3D DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC, > - .width_mm =3D 65, > - .height_mm =3D 130, > -}; > - > -struct st7703_panel_desc jh057n00900_panel_desc =3D { > - .mode =3D &jh057n00900_mode, > - .lanes =3D 4, > - .mode_flags =3D MIPI_DSI_MODE_VIDEO | > - MIPI_DSI_MODE_VIDEO_BURST | MIPI_DSI_MODE_VIDEO_SYNC_PULSE, > - .format =3D MIPI_DSI_FMT_RGB888, > - .init_sequence =3D jh057n_init_sequence, > -}; > - > static int st7703_get_modes(struct drm_panel *panel, > struct drm_connector *connector) > { > -- = > 2.27.0 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel