From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9030FC433E0 for ; Wed, 1 Jul 2020 16:06:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62C2920760 for ; Wed, 1 Jul 2020 16:06:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hz8BG/5y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62C2920760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=puri.sm Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qg23SiplrjEzuX/55mal9IkMqTejUpMP7sgAD4sTy2Y=; b=hz8BG/5ynBBH/sj8Q6Bo9nlK2 n/KOZuqA0ngUAFaB2JSXikV6sbFCFv8RcvAz887jUBPfsXVqAc/aue5umhMlecuEFhq7orSv1LvVd 4U+sLoksqoWViXaRTGXkNZrGKHvzxhnqz588yvYkY+21M+X329EEA8urhwhgmgpoRK+SSsWXms3ag rXHknq3RIpB13RowL9uYgAlVCUF6258Zw1Nci5Pnr0lRGMsV7wbMGtdV3xC4thgW1qI8mDtNAqSDN H9EWD3GUT5wawwRaZqa+OGt/4rFp5jGhvREcWzOkut0m5DCV4ct5VYMe4xAaRcS6JFHRlLAeI/rG2 dWRuA7iZw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqfDj-0000Gm-O5; Wed, 01 Jul 2020 16:04:23 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqfDh-0000F7-8y for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 16:04:22 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id B872FFB03; Wed, 1 Jul 2020 18:04:19 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mCQhS3pQ3pkg; Wed, 1 Jul 2020 18:04:18 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id 9117340972; Wed, 1 Jul 2020 18:04:18 +0200 (CEST) Date: Wed, 1 Jul 2020 18:04:18 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Ondrej Jirman Subject: Re: [PATCH v6 10/13] drm/panel: st7703: Enter sleep after display off Message-ID: <20200701160418.GI174356@bogon.m.sigxcpu.org> References: <20200701103126.1512615-1-megous@megous.com> <20200701103126.1512615-11-megous@megous.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701103126.1512615-11-megous@megous.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_120421_448244_4A671E95 X-CRM114-Status: GOOD ( 17.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Purism Kernel Team , Samuel Holland , David Airlie , Linus Walleij , Bhushan Shah , Chen-Yu Tsai , Rob Herring , linux-kernel@vger.kernel.org, Martijn Braam , linux-sunxi@googlegroups.com, Thierry Reding , Maxime Ripard , Daniel Vetter , Sam Ravnborg , Luca Weiss , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jul 01, 2020 at 12:31:23PM +0200, Ondrej Jirman wrote: > The datasheet suggests to issue sleep in after display off > as a part of the panel's shutdown sequence. Out of curiosity: which exact datasheet did you use? Reviewed-by: Guido G=FCnther = > = > Signed-off-by: Ondrej Jirman > Reviewed-by: Linus Walleij > --- > drivers/gpu/drm/panel/panel-sitronix-st7703.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/= drm/panel/panel-sitronix-st7703.c > index 5cd5503f894f..0c4167994d01 100644 > --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c > +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c > @@ -395,8 +395,19 @@ static int st7703_disable(struct drm_panel *panel) > { > struct st7703 *ctx =3D panel_to_st7703(panel); > struct mipi_dsi_device *dsi =3D to_mipi_dsi_device(ctx->dev); > + int ret; > + > + ret =3D mipi_dsi_dcs_set_display_off(dsi); > + if (ret < 0) > + DRM_DEV_ERROR(ctx->dev, > + "Failed to turn off the display: %d\n", ret); > = > - return mipi_dsi_dcs_set_display_off(dsi); > + ret =3D mipi_dsi_dcs_enter_sleep_mode(dsi); > + if (ret < 0) > + DRM_DEV_ERROR(ctx->dev, > + "Failed to enter sleep mode: %d\n", ret); > + > + return 0; > } > = > static int st7703_unprepare(struct drm_panel *panel) > -- = > 2.27.0 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel