From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44C34C433DF for ; Wed, 1 Jul 2020 16:06:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13FA620760 for ; Wed, 1 Jul 2020 16:06:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xiIubZnC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13FA620760 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=puri.sm Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RrEwbOMtXQSVkqxuh/xkEbOMpACA+DfuXKlhHbDijAI=; b=xiIubZnC73vTrdsJfoftteU0B Pco/tfPm7c6GQkEnZ9KEfoMsftintjAEJhZ5IUgeE4m/iqxz8S2q6L1nq/iJyIdMuLu1kjJy92CE3 7o+eJToTboW/4pwQQOIefpw1XvFZ5gQnaAaRdzgHkTgSGP6UB1diRQkiA2JaIOIY8Hna2JU3lcySu prawLkHEk7/7UaMlZ0ANMifAjMtDjk38vq2fAnjipDxOzyoFwuwkSY66R1/vhG59ihHLkqrowDndY 0CnFFA/Xrd1wXO8SYUk3Nct5Mm2Vl7qFaZ3o/3tIkcgTkMGunHqmlmng7jEsfRjiTx6facPacs+w6 t9pffQmrw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqfEA-0000To-CP; Wed, 01 Jul 2020 16:04:50 +0000 Received: from honk.sigxcpu.org ([24.134.29.49]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqfE7-0000S4-88 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 16:04:48 +0000 Received: from localhost (localhost [127.0.0.1]) by honk.sigxcpu.org (Postfix) with ESMTP id 0AA3BFB03; Wed, 1 Jul 2020 18:04:46 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at honk.sigxcpu.org Received: from honk.sigxcpu.org ([127.0.0.1]) by localhost (honk.sigxcpu.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d51v51hIpkHm; Wed, 1 Jul 2020 18:04:45 +0200 (CEST) Received: by bogon.sigxcpu.org (Postfix, from userid 1000) id E33D740972; Wed, 1 Jul 2020 18:04:44 +0200 (CEST) Date: Wed, 1 Jul 2020 18:04:44 +0200 From: Guido =?iso-8859-1?Q?G=FCnther?= To: Ondrej Jirman Subject: Re: [PATCH v6 11/13] drm/panel: st7703: Assert reset prior to powering down the regulators Message-ID: <20200701160444.GJ174356@bogon.m.sigxcpu.org> References: <20200701103126.1512615-1-megous@megous.com> <20200701103126.1512615-12-megous@megous.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701103126.1512615-12-megous@megous.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_120447_444262_D4110D77 X-CRM114-Status: GOOD ( 15.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Purism Kernel Team , Samuel Holland , David Airlie , Linus Walleij , Bhushan Shah , Chen-Yu Tsai , Rob Herring , linux-kernel@vger.kernel.org, Martijn Braam , linux-sunxi@googlegroups.com, Thierry Reding , Maxime Ripard , Daniel Vetter , Sam Ravnborg , Luca Weiss , linux-arm-kernel@lists.infradead.org, Icenowy Zheng Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jul 01, 2020 at 12:31:24PM +0200, Ondrej Jirman wrote: > The reset pin is inverted, so if we don't assert reset, the actual gpio > will be high and may keep driving the IO port of the panel. Reviewed-by: Guido G=FCnther > = > Signed-off-by: Ondrej Jirman > Reviewed-by: Linus Walleij > --- > drivers/gpu/drm/panel/panel-sitronix-st7703.c | 1 + > 1 file changed, 1 insertion(+) > = > diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/= drm/panel/panel-sitronix-st7703.c > index 0c4167994d01..e303b7b1a215 100644 > --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c > +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c > @@ -417,6 +417,7 @@ static int st7703_unprepare(struct drm_panel *panel) > if (!ctx->prepared) > return 0; > = > + gpiod_set_value_cansleep(ctx->reset_gpio, 1); > regulator_disable(ctx->iovcc); > regulator_disable(ctx->vcc); > ctx->prepared =3D false; > -- = > 2.27.0 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel