From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3769CC433DF for ; Wed, 1 Jul 2020 16:47:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0419F2067D for ; Wed, 1 Jul 2020 16:47:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NoYFPlyP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="P7m4gpyK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0419F2067D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XelzsDMeWmuLzbVXplFAN33rQW94HEpjTaEsitFFzVw=; b=NoYFPlyPW1tfLONxSIRb/sFLe KKk4+sMRqE1fUU0wDvWNM50sMJjKTmut4sDiIGDotrspyYqzIA6FJ4ZWjPUvZkC73FkZ1NheYfak9 OQUJXO1R2DWmqB2LLYu8pl00bX4RYIFq5MfsnAAxn/2ghhbIbeVSOmxRfqJZfR6V7VOcLdhaXssRm NxS0jmGV17Zr1/j4U/vO2JuZxfi5BfYtzfqrvTrN5YwKntwQGoP3XowNieqtuYFLy1vwXAQAIDAkK d/NcXmoPqkhFuNAIBc9zUQZRgUyWvfvXyUZ37vDqh3tZ42tZMSZFhsY8r1mELkorsCAnl6Dcq+GVS k8jtoJetQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqfrn-0003vk-Ac; Wed, 01 Jul 2020 16:45:47 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqfrl-0003vC-99 for linux-arm-kernel@lists.infradead.org; Wed, 01 Jul 2020 16:45:46 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D44392067D; Wed, 1 Jul 2020 16:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593621944; bh=898OmLg4aGbCe4bv4S8YUlDltty9sKmJivxapfKNN/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=P7m4gpyKqG/1oiThn7E+JjTgP+aTqC9G1D85yjAjlgf1t8W0olWw6AhgwNgw7Gi6i bzIhCuTqTPC015HYUlj/LJPrrA1s7Qw9coX+hnOY6YxZkZZAbWUF01FPbxZBHm/3tE koMzj6yPqkPWzo6UK+7MGDqgM1/DPNrYoBDE0cJ4= Date: Wed, 1 Jul 2020 18:45:30 +0200 From: Greg KH To: Mathieu Poirier Subject: Re: [PATCH 2/2] coresight: etmv4: Fix CPU power management setup in probe() function Message-ID: <20200701164530.GA3172565@kroah.com> References: <20200701160852.2782823-1-mathieu.poirier@linaro.org> <20200701160852.2782823-3-mathieu.poirier@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200701160852.2782823-3-mathieu.poirier@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200701_124545_399200_BE7804C4 X-CRM114-Status: GOOD ( 16.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, dan.carpenter@oracle.com, mike.leach@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 01, 2020 at 10:08:52AM -0600, Mathieu Poirier wrote: > From: Mike Leach > > The current probe() function calls a pair of cpuhp_xxx API functions to > setup CPU hotplug handling. The hotplug lock is held for the duration of > the two calls and other CPU related code using cpus_read_lock() / > cpus_read_unlock() calls. > > The problem is that on error states, goto: statements bypass the > cpus_read_unlock() call. This code has increased in complexity as the > driver has developed. > > This patch introduces a pair of helper functions etm4_pm_setup_cpuslocked() > and etm4_pm_clear() which correct the issues above and group the PM code a > little better. > > The two functions etm4_cpu_pm_register() and etm4_cpu_pm_unregister() are > dropped as these call cpu_pm_register_notifier() / ..unregister_notifier() > dependent on CONFIG_CPU_PM - but this define is used to nop these functions > out in the pm headers - so the wrapper functions are superfluous. > > Fixes: f188b5e76aae ("coresight: etm4x: Save/restore state across CPU low power states") > Fixes: e9f5d63f84fe ("hwtracing/coresight-etm4x: Use cpuhp_setup_state_nocalls_cpuslocked()") > Fixes: 58eb457be028 ("etm4x: Convert to hotplug state machine") That should be: Fixes: 58eb457be028 ("hwtracing/coresight-etm4x: Convert to hotplug state machine") I'll go fix it up, but be careful, I don't know where you got that from... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel