From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C5DC433DF for ; Thu, 2 Jul 2020 06:01:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F4012070C for ; Thu, 2 Jul 2020 06:01:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="3BXr3kty" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F4012070C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JwVYq5b0lGsRfoRI2MbycYP0qLncc7SIXtquUpeSREQ=; b=3BXr3ktyuNWUYxXW2bCs1l/eS Swn+H687VnArhA3dI5YCKStR5UHKWsrbvaoFd2uU1ByGjs1DmwOL1C6kFd4CkCREz4Kht/pZhozeZ wCaDB6bm011qMWLBNFrtN1QvRLhHP2Io9N9SD1Mj7dTYN36S0tJMlnITQ8WKLQzKQ68mozv2b35Mg PZNLg+pNpLhniyz3hik0BswW8Yp6cgLmZp2zG9mOwQIFsqdk37ffq6WHhVCeqt6b3YLkQwAHZccKC W4onOh/fbuDVAW1UoMcpvqwulPr56+/jSMB9OK5YP5GMvARqFBXhAyS6+MzjacMJFKDbyIcLp/MDU /3Q1FHwRw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqsGa-0000VK-CA; Thu, 02 Jul 2020 06:00:12 +0000 Received: from mail-ej1-f66.google.com ([209.85.218.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqsGW-0000Ur-Gy for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 06:00:10 +0000 Received: by mail-ej1-f66.google.com with SMTP id n26so13834388ejx.0 for ; Wed, 01 Jul 2020 23:00:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=k+0TJgtyGdUFAif3iB9nD6dvgm5MlSiy6/23tSnNTIE=; b=i7KZDk89JH65j+ST87CaIWueZ0A/n4Je2jCWaJ4ZdSfwN24/Lz39XT/LzCwfgHfZjD BDfDQwsMT59jmzcUntTeecv0E4g0yZbojZpJjJzi19ZCKROLRuK3uvs5vNKk/OsomAfq z5qGc2PF15bhjZuF1mTcZSiL9okUpqIU41rU+WBj3NRm9K866ub7Pu2pXjPozeYCMd9b zSSOm4NgztTAfQpKi+l0nmPuFnj30GF0oaJJIKQyxq+VHaZuSfEON0AxJhaSINLTxsby e6heSdBTEcD0TG2CZQ65EeOaTF8EcTgiTOcqopUSstm2GKvcojs/q2Aq4rGSwK8AKbns wp4w== X-Gm-Message-State: AOAM532rlcPYH/EphcTWpf88d+5MNjvDI/qv3W/DcKxCmTp9TOV+uW2G u08fU70uRArVB4J2xmDnlX8= X-Google-Smtp-Source: ABdhPJx+92owXVBEj1k0uFeSCkezcOnNF9loDGUYXY+ITfPZQt/zwwOX52FKrdde00pwe9p9ip6TWQ== X-Received: by 2002:a17:906:a1c7:: with SMTP id bx7mr20452601ejb.388.1593669605407; Wed, 01 Jul 2020 23:00:05 -0700 (PDT) Received: from kozik-lap ([194.230.155.195]) by smtp.googlemail.com with ESMTPSA id a37sm8647592edf.86.2020.07.01.23.00.04 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Jul 2020 23:00:04 -0700 (PDT) Date: Thu, 2 Jul 2020 08:00:02 +0200 From: 'Krzysztof Kozlowski' To: Alim Akhtar Subject: Re: [PATCH 1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7 Message-ID: <20200702060002.GA4175@kozik-lap> References: <20200629204442.17336-1-krzk@kernel.org> <001101d64ef2$8f824620$ae86d260$@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <001101d64ef2$8f824620$ae86d260$@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_020008_584111_043C10C1 X-CRM114-Status: GOOD ( 19.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, 'Bartlomiej Zolnierkiewicz' , 'Sylwester Nawrocki' , 'Pankaj Dubey' , linux-kernel@vger.kernel.org, 'Chanwoo Choi' , 'Rob Herring' , 'Kukjin Kim' , linux-arm-kernel@lists.infradead.org, 'Marek Szyprowski' Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 30, 2020 at 08:54:28PM +0530, Alim Akhtar wrote: > Hi Krzysztof, > > > -----Original Message----- > > From: Krzysztof Kozlowski > > Sent: 30 June 2020 02:15 > > To: Rob Herring ; Kukjin Kim ; > > Krzysztof Kozlowski ; devicetree@vger.kernel.org; > linux-arm- > > kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux- > > kernel@vger.kernel.org > > Cc: Marek Szyprowski ; Bartlomiej Zolnierkiewicz > > ; Sylwester Nawrocki ; > > Alim Akhtar ; Chanwoo Choi > > ; Pankaj Dubey > > Subject: [PATCH 1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7 > > > > Add required interrupts to PWM node on Exynos7. This fixes DT schema > > warning: > > > > pwm@136c0000: 'interrupts' is a required property > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > Not tested > > --- > > arch/arm64/boot/dts/exynos/exynos7.dtsi | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi > > b/arch/arm64/boot/dts/exynos/exynos7.dtsi > > index f590891efe25..523547b3d539 100644 > > --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi > > +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi > > @@ -581,6 +581,11 @@ > > pwm: pwm@136c0000 { > > compatible = "samsung,exynos4210-pwm"; > > reg = <0x136c0000 0x100>; > > + interrupts = , > > + , > > + , > > + , > > + ; > PWM IRQs are from 449 ~ 453 for PWM[0] ~ PWM[4] on this SoC. > 444 ~ 447 are for HSI2C and 448 is for ADC. Ah, indeed. > Please see the exynos7.dtsi > Also drivers/pwm/pwm-samsung.c does not uses interrupt at all, still we need > interrupts property to be added here? That's a good point. For S3C SoCs the PWM timer was used also as a clocksource so it required interrupts. But since Exynos this is not used. I don't know why the bindings introduced required interrupts... It seems it would be better just to remove them from bindings and DTS. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel