From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 302A7C433E0 for ; Thu, 2 Jul 2020 11:43:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFA8020780 for ; Thu, 2 Jul 2020 11:43:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QKlw7drs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFA8020780 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xnnNIMyFemZAtiOw2ka+kSQJIldHgYcMDKkR4tGXltg=; b=QKlw7drsxbRMhUfkDQTYtn6M9 8nEFCGllNatzFaanbRtTksYaFC6pTeivv6UK9ApZ/YsCQV4rLgz9HluXapA8a8atZUtz+VyQE1GIq 7jp2g+XE2LbiU+2sV8EyZnK/wKIuXMyCv21+nZgV1rfatX3gdsA8pFug2KDWY9aR8VvVrK9i5glD6 61Mg8Pcl1yBV+HRYk8DlkSmimpva4dqM06ugmKu4cAfrp+2IpvzDRP73FVfSaTWW566OTkeOdXKjU 6dsVnNGjq5jYmeCsO9iC+6kBRcyuM+FPhArwq4BjH03NYPSJJuMZkxk9BDkxba8WgslxFYC7kgwmf zpv/pYq0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqxbN-00068D-Ag; Thu, 02 Jul 2020 11:42:01 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jqxbK-00066o-Qm for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 11:41:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 829D41FB; Thu, 2 Jul 2020 04:41:54 -0700 (PDT) Received: from localhost (unknown [10.1.198.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 239563F71E; Thu, 2 Jul 2020 04:41:54 -0700 (PDT) Date: Thu, 2 Jul 2020 12:41:52 +0100 From: Ionela Voinescu To: Viresh Kumar Subject: Re: [PATCH 4/8] cpufreq,vexpress-spc: fix Frequency Invariance (FI) for bL switching Message-ID: <20200702114123.GA28120@arm.com> References: <20200701090751.7543-1-ionela.voinescu@arm.com> <20200701090751.7543-5-ionela.voinescu@arm.com> <20200701095414.2wjcnyhndgcedk2q@vireshk-i7> <20200701140735.GB32736@arm.com> <20200702030551.p4cevaahgfvpum4o@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200702030551.p4cevaahgfvpum4o@vireshk-i7> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_074158_940196_F1881988 X-CRM114-Status: GOOD ( 18.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, rjw@rjwysocki.net, linux@armlinux.org.uk, dietmar.eggemann@arm.com, mingo@redhat.com, sudeep.holla@arm.com, Liviu Dudau , will@kernel.org, valentin.schneider@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Thursday 02 Jul 2020 at 08:35:51 (+0530), Viresh Kumar wrote: > On 01-07-20, 15:07, Ionela Voinescu wrote: > > On Wednesday 01 Jul 2020 at 16:16:19 (+0530), Viresh Kumar wrote: > > > Is there anyone who cares for this driver and EAS ? I will just skip doing the > > > FIE thing here and mark it skipped. > > > > That is a good question. The vexpress driver is still used for TC2, but > > I don't know of any users of this bL switcher functionality that's part > > of the driver. I think there were a few people wondering recently if > > it's still used [1]. > > Even if it is used by some, there is no need, I believe, to enable > freq-invariance for it, which wasn't enabled until now. > It was enabled until now, but it was partially broken. If you look over the driver you'll see arch_set_freq_scale() being called for both is_bL_switching_enabled() and for when it's not [1]. For !is_bL_switching_enabled() this is fine. But for is_bL_switching_enabled(), it is broken as described in 4/8. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/cpufreq/vexpress-spc-cpufreq.c?h=v5.8-rc3#n203 > And considering that we are going to enable the flag only for the > interested parties now, as from the discussion on 1/8, this shouldn't > be required. > If we just don't want frequency invariance for is_bL_switching_enabled(), I can just guard the setting of the flag suggested by Rafael at 1/8 by !CONFIG_BL_SWITCHER. I'll proceed to do that and remove the fix at 4/8. Many thanks! Ionela. > -- > viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel