From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50AA0C433DF for ; Thu, 2 Jul 2020 22:41:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CE122075D for ; Thu, 2 Jul 2020 22:41:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="csohgRkF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="flMT1sP+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CE122075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nIj91mRCyZTGxf6r2sG/4nKKXl7OZ1kDI0aYWB1pnfg=; b=csohgRkFz2vTRxqu+gwYyf/kS eQMc0c+rH8OLUts68nCcU2pIRajkzVtaDgBl+3gAelRDOiCibW6zxGaDtJG0TvsVOTccWyBC1u3Cs hSaVLuu8miva0LLL+AJ6f40qZnlPpjOIexwdthOPlq15EGWQXF/nTTfbVdz7OePCYoNVtuxC4Gix1 xGXT9HHiVJOu0PHUhcl1LpPFLSPU8O2kDQqxC27Ty2sO1qIBKSUoVxCsGMl9SToV9g59IbSeWagbW EuSiG6X+8tEEaOA4/TazaniLhF7yOpmXQtUCiVL0pCfVv3/aJg1QESaVDh3BKgJLhbbXkjzFtlcEd A+Tv/C2qg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr7s8-0002fr-AL; Thu, 02 Jul 2020 22:40:00 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr7s5-0002f5-A7 for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 22:39:58 +0000 Received: by mail-pf1-x442.google.com with SMTP id x72so3710655pfc.6 for ; Thu, 02 Jul 2020 15:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hpu8XAwtmw+kOkLZIDuQrqRUjCpHBHdYp8QrdsSt1UY=; b=flMT1sP+tqTMlnOZZkcn0W4Ha4XYoXoL/dPj0adpgOuDpi+GIqKpb2CAl7SwumpXo3 1sfAWsDzrxpzuwDGfxIa3l3TiwUb+YhcaR4+rtCC7VooizGww9W9jA3yuHQ1jtSsyuBY /EY29vYYv0bpCjtizpWHWOyMApzwLqY0Wn8Gcpdg8OcXcrUjWNxxhL6vkRiUh2ddJ424 4N+NuueT+jkgZQg1Z98KrIf+HlKPjBOdnNHeG2BsmwN3jhyBVuVwjsqwITg+qiSKrNrF teGCQGmIYsWo0C2UH0s85xK8J9RLGqsztEPxSMvNsk5WHebrOscwPNdHphEb0D8vHWlY zKbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hpu8XAwtmw+kOkLZIDuQrqRUjCpHBHdYp8QrdsSt1UY=; b=hLN1OpT3qZX2vN/7C3uuX8dFqq3jcizy5qUP1oFFyfcYyqhav3bkJk5CwnDMkOBQlp T4I8qhzbRtIbQpzwD/3h9BiXUcf2fZdmMiPYGZvuZcU4FhnbhJA8RJbAIEsZ3wnkDD0Y tZdg4zJVVmgL/SUJeYlZfscdLB4TRyBmQNR/cn6fRcLXot5ePzueNk3bdcNIMUDRLxdx X5s6QJ7OyVb2KBJLRCXEBiNUM8yM81cOR0gIOCGwJboIsn+u4gQw2zAGS5tGE0yibZ0F oxiYHf8Tv8Qk/RLrVsdQYilijpnFqesIEKPXYf2wMTiPSmiKv1JU8JCLIWgrJnjZMHMJ vBVA== X-Gm-Message-State: AOAM5323goEDB01kpK638YSbp9D/3TnOqG4GF1BXNmcXRlSk0YheJu4R 6OTPL+h6+12lu3M407j3ubQNPg== X-Google-Smtp-Source: ABdhPJw9sBmZpW6b/xmF9uf5wIzxYbJiz9XfJS95WdRI7TvRVNnoc0HEZU0ltp/2qita2GXq82Z4MA== X-Received: by 2002:a62:7bc9:: with SMTP id w192mr28293570pfc.255.1593729592836; Thu, 02 Jul 2020 15:39:52 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id m68sm169126pje.24.2020.07.02.15.39.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 15:39:52 -0700 (PDT) Date: Thu, 2 Jul 2020 16:39:50 -0600 From: Mathieu Poirier To: Wei Li Subject: Re: [PATCH 1/2] perf tools: ARM SPE code cleanup Message-ID: <20200702223950.GA471976@xps15> References: <20200623123141.27747-1-liwei391@huawei.com> <20200623123141.27747-2-liwei391@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200623123141.27747-2-liwei391@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_183957_384674_4744A028 X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kim Phillips , Suzuki K Poulose , Alexander Shishkin , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 23, 2020 at 08:31:40PM +0800, Wei Li wrote: > Remove the useless check code to make it clear. > > Signed-off-by: Wei Li > --- > tools/perf/arch/arm/util/auxtrace.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/arch/arm/util/auxtrace.c b/tools/perf/arch/arm/util/auxtrace.c > index 0a6e75b8777a..62b7b03d691a 100644 > --- a/tools/perf/arch/arm/util/auxtrace.c > +++ b/tools/perf/arch/arm/util/auxtrace.c > @@ -57,7 +57,7 @@ struct auxtrace_record > struct evsel *evsel; > bool found_etm = false; > bool found_spe = false; > - static struct perf_pmu **arm_spe_pmus = NULL; > + static struct perf_pmu **arm_spe_pmus; > static int nr_spes = 0; > int i = 0; > > @@ -65,9 +65,7 @@ struct auxtrace_record > return NULL; > > cs_etm_pmu = perf_pmu__find(CORESIGHT_ETM_PMU_NAME); > - > - if (!arm_spe_pmus) > - arm_spe_pmus = find_all_arm_spe_pmus(&nr_spes, err); > + arm_spe_pmus = find_all_arm_spe_pmus(&nr_spes, err); Reviewed-by: Mathieu Poirier > > evlist__for_each_entry(evlist, evsel) { > if (cs_etm_pmu && > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel