From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C620AC433DF for ; Thu, 2 Jul 2020 23:05:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FDD220780 for ; Thu, 2 Jul 2020 23:05:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qKNtxJp5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fvYkB0Gr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FDD220780 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JcguzkiRBNWByVhfG+IGZkaBiGAbe1aGPGpsbceMkMI=; b=qKNtxJp5fjNE/go/592MJ8oju awdSDwltc4t8T05ULfqcVYJb45SIkBKw6PSJ5/Dd3KxvjDazlnHb+/bHFLzPqmvpcqP50Ast3/HZi QJ9SXNYWQfrxq3nSVtwcKf4Zje/8zx+6mAo+SWmYtqAKR3dYlCEdv+jAadzWY9qyjkIt1Ny2gJHvT MBGh7XHlmpMK+OGPekm5aDuFv+RNiHGxfmQgH9K8l7Bekvkoh79n6ChotAjVebNS+jnTiwNLn24rv hNFCihRiz5W2qMXxMPmsTiejV3qhIwfeCVO/WOKaAFhxDagq+pt1EwzyL4O7HZqjkbzza1ssp4gb3 fqF/hFPaA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr8Ev-0004Ew-3w; Thu, 02 Jul 2020 23:03:33 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr8Es-0004Dv-4J for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 23:03:31 +0000 Received: by mail-pl1-x641.google.com with SMTP id o1so5307869plk.1 for ; Thu, 02 Jul 2020 16:03:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=C/wKxCmAp8P5+IuEDReF1PhHjU6934D3J4Spbsakypw=; b=fvYkB0GrlRYeSsqKY8DfBsHb5+EpJsR1WxZhgotr27Mz85gEm8Z5BsTJde29nk/h1E BHK7QPSGOx7VZRR+JfzAmGcukkWdp28+cMSOWMccRubKzRkU0/N7mewl+2fR/9jC7LO3 dyXtLDDoH+t6Wj0OwsEMiRc3V5sg8zZaOc0TiIrFy59Q9BrPS5FnSNawmGBLpvH2Gxsj xxh4j5Ftf5qhMv07igHdA+38g5zACOzhHOynpFMZaDfu55MVUZ6mtDkLIl3P03ukK+Ga vM6LSUFknrixnYs9VBRakxbwjk24jelKI4MuTaKLnUOoZzufz0x+7S1Dr+wwgGY5EpHH slAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=C/wKxCmAp8P5+IuEDReF1PhHjU6934D3J4Spbsakypw=; b=nrWdcqtKmG9WC0AaYSVQVZpUERvde7yXooAKaCQSpZnyLRynDNbmr9PeADRLTKuPBg IHEuK6unb1jr0kuZaNIOMOTNrusK8Pa7IuEIF+/aiIDiTNzny/f4+6Nu5sqxg+6+pJsl cH0FQMZy/kR1Gemz1RpawNVFoO3psPKdRqbxrWLF+cZnhFA8qeUBkHjMxnOiwNRhlV5s 2kywMdRy8mHujA740ePBcetUSkem1yqYMQE+7mEaCh0n4XgjThiJfdszsRjjqtZOOFIY pkSc1S1qS+NCVQf3u33lGuxllBboctJFgkdckYsIddhQDoat45JlMJlNU/zqFtsa5sVX +Czw== X-Gm-Message-State: AOAM5329J/A8ZBvMN/HRai+dDuSQ41t/uxcIi2OaLjsYX/oXofsjFVLB 2wdzv4ReTwE1aTu0cDbyhA8Now== X-Google-Smtp-Source: ABdhPJyF1ykGkpqefsktD2Yx+ekgyRNvo0wT3Zm5a/e/Nie0V2q0Tu814ppuAKsBilsKAUqwbstdQA== X-Received: by 2002:a17:90b:19d4:: with SMTP id nm20mr12314798pjb.206.1593731005454; Thu, 02 Jul 2020 16:03:25 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id 198sm10316727pfb.27.2020.07.02.16.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 16:03:24 -0700 (PDT) Date: Thu, 2 Jul 2020 17:03:22 -0600 From: Mathieu Poirier To: Wei Li Subject: Re: [PATCH 2/2] perf tools: Fix record failure when mixed with ARM SPE event Message-ID: <20200702230322.GB471976@xps15> References: <20200623123141.27747-1-liwei391@huawei.com> <20200623123141.27747-3-liwei391@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200623123141.27747-3-liwei391@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_190330_527141_43B5D03D X-CRM114-Status: GOOD ( 31.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kim Phillips , Suzuki K Poulose , Alexander Shishkin , linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Peter Zijlstra , Ingo Molnar , leo.yan@linaro.org, Namhyung Kim , Jiri Olsa , linux-arm-kernel@lists.infradead.org, Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Li, On Tue, Jun 23, 2020 at 08:31:41PM +0800, Wei Li wrote: > When recording with cache-misses and arm_spe_x event, i found that > it will just fail without showing any error info if i put cache-misses > after arm_spe_x event. > > [root@localhost 0620]# perf record -e cache-misses -e \ > arm_spe_0/ts_enable=1,pct_enable=1,pa_enable=1,load_filter=1,\ > jitter=1,store_filter=1,min_latency=0/ sleep 1 > [ perf record: Woken up 1 times to write data ] > [ perf record: Captured and wrote 0.067 MB perf.data ] > [root@localhost 0620]# perf record -e \ > arm_spe_0/ts_enable=1,pct_enable=1,pa_enable=1,load_filter=1,jitter=1,\ > store_filter=1,min_latency=0/ -e cache-misses sleep 1 > [root@localhost 0620]# > > Finally, i found the reason is that the parameter 'arm_spe_pmu' passed to > arm_spe_recording_init() in auxtrace_record__init() is wrong. When the > arm_spe_x event is not the last event, 'arm_spe_pmus[i]' will be out of > bounds. Yes, this indeed broken. The current code can only work if the only event to be traced is an arm_spe_X, or if it is the last event to be specified. Otherwise the last event type will be checked against all the arm_spe_pmus[i]->types, none will match and an out of bound i index will be used in arm_spc_recording_init(). Since this problem is not easy to figure out please include the above explanation in the changelog. > > It seems that the code can't support concurrent multiple different > arm_spe_x events currently. So add the code to check and record the > found 'arm_spe_pmu' to fix this issue. > > In fact, we don't support concurrent multiple same arm_spe_x events either, > that is checked in arm_spe_recording_options(), and it will show the > relevant info. > > Fixes: ffd3d18c20b8d ("perf tools: Add ARM Statistical Profiling Extensions (SPE) support") > Signed-off-by: Wei Li > --- > tools/perf/arch/arm/util/auxtrace.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/arch/arm/util/auxtrace.c b/tools/perf/arch/arm/util/auxtrace.c > index 62b7b03d691a..7bb6f29e766c 100644 > --- a/tools/perf/arch/arm/util/auxtrace.c > +++ b/tools/perf/arch/arm/util/auxtrace.c > @@ -58,6 +58,7 @@ struct auxtrace_record > bool found_etm = false; > bool found_spe = false; > static struct perf_pmu **arm_spe_pmus; > + static struct perf_pmu *arm_spe_pmu; As far as I can tell the "static" doesn't do anything. > static int nr_spes = 0; > int i = 0; > > @@ -77,6 +78,13 @@ struct auxtrace_record > > for (i = 0; i < nr_spes; i++) { > if (evsel->core.attr.type == arm_spe_pmus[i]->type) { > + if (found_spe && (arm_spe_pmu != arm_spe_pmus[i])) { > + pr_err("Concurrent multiple SPE operation not currently supported\n"); > + *err = -EOPNOTSUPP; > + return NULL; > + } Instead of the above, which as you rightly pointed out, is also done in arm_spe_recording_options() it might be best to just fix the "if (!nr_spes)" condition: if (!nr_spes || arm_spe_pmu) continue Furthermore, instead of having a new arm_spe_pmu variable you could simply make found_spe a struct perf_pmu. That would be one less variable to take care of. > + > + arm_spe_pmu = arm_spe_pmus[i]; > found_spe = true; Last but not least do you know where the memory allocated for array arm_spe_pmus is released? If you can't find it either then we have a memory leak and it would be nice to have that fixed. Regards Mathieu PS: Leo Yan has spent a fair amount of time in the SPE code - please CC him on your next revision. > break; > } > @@ -94,7 +102,7 @@ struct auxtrace_record > > #if defined(__aarch64__) > if (found_spe) > - return arm_spe_recording_init(err, arm_spe_pmus[i]); > + return arm_spe_recording_init(err, arm_spe_pmu); > #endif > > /* > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel