From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ADEFC433E0 for ; Fri, 3 Jul 2020 06:45:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAF54208C7 for ; Fri, 3 Jul 2020 06:44:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lzNHdRTr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAF54208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lv8t+hxYdI69trw3+ymt90ZnPvKtsOHePTH2onREvAI=; b=lzNHdRTrmQbsYgv52Gd9XpAU3 9Xd1v34R/LunKD/BbpS56I5ogaKmpnadbEZtGVOXiggy4UhNWUgioheAMg1/eGbL1ggWLmdtZH1VO w2kkskwtsU6PZDJ+A8fHdSoKXAyUdjgw5MK53RGJmGa43eNRynuYQN/l4OnsLOkC4SYsE/xNWtXEQ wFG75mXC1LLR8I9mo4mW9r0316/8J+UJERWa0CclASAHnX0wPY7p0Na7PxHvgs9gpytITxPg+1et+ YMS/6z11GiKVF48TNTgq28XSoCg8VvJAcW4tOan6n3FvU047IJV4HC6pVSpfI8TDid7OcYhL7fCrv e88a/kbnA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrFPx-0007eS-Gx; Fri, 03 Jul 2020 06:43:25 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrFPu-0007dX-Uc; Fri, 03 Jul 2020 06:43:23 +0000 Received: by mail-ed1-f67.google.com with SMTP id n2so17671826edr.5; Thu, 02 Jul 2020 23:43:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HpfdR+Nz+v/JEE+ucLnGmelRBm4qsJ9pvagHJ29kthQ=; b=K1zWb1/+35/GqhYRUN0wTYiwxGv2zRdfTnN/P19U+vTZ4pkVHQBLHd2FbaEo0X9aAi JRjByXat3nHVoqLOpEVKf9LwJh2FpHqgzRrfHldJWn6uOyyK9sccFksFgmHpDgKB2OG0 MjDfmq0o0+hemXL4CSQwqEt0IIIFHpgcensQ8lAUJ4m9HA82j6g7aVoEVQeUqK4QOZYi 7uObhFAU7CEuTj3WCKnDJn8EzP0D55t4wX8ej2Zt4drJGSt+vheeJlllfvaDcY1bb0LZ Fb+lxvRJF8N6mN7BNQnNrGwalvkqeE5IrDrk78QPYzE3kO6CjAyHFEytN2Su3iDzmwYX 4lOg== X-Gm-Message-State: AOAM530GVXGk/ntwOhTSiQWTm9+Lpr0u7zkkf6JZRK/CmaIekvQ0OP79 pmrRP6a5W3UdDjxOun546pZSsztX X-Google-Smtp-Source: ABdhPJzIbM1HDccc2+Gu9mfkPL6JsrAMgw+HPHk5MHQoT5Fi3KlkQtt6vK8FLBLUpPzyNfwb9V1APw== X-Received: by 2002:a50:9f22:: with SMTP id b31mr39686145edf.24.1593758599991; Thu, 02 Jul 2020 23:43:19 -0700 (PDT) Received: from localhost (ip-37-188-168-3.eurotel.cz. [37.188.168.3]) by smtp.gmail.com with ESMTPSA id f16sm8608536ejr.0.2020.07.02.23.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 23:43:19 -0700 (PDT) Date: Fri, 3 Jul 2020 08:43:18 +0200 From: Michal Hocko To: Bhupesh Sharma Subject: Re: [PATCH 1/2] mm/memcontrol: Fix OOPS inside mem_cgroup_get_nr_swap_pages() Message-ID: <20200703064318.GN18446@dhcp22.suse.cz> References: <1593641660-13254-1-git-send-email-bhsharma@redhat.com> <1593641660-13254-2-git-send-email-bhsharma@redhat.com> <20200702060024.GA18446@dhcp22.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200702060024.GA18446@dhcp22.suse.cz> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200703_024323_004214_163D94F2 X-CRM114-Status: GOOD ( 29.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Catalin Marinas , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, James Morse , Vladimir Davydov , Johannes Weiner , cgroups@vger.kernel.org, Andrew Morton , bhupesh.linux@gmail.com, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [Cc Andrew - the patch is http://lkml.kernel.org/r/1593641660-13254-2-git-send-email-bhsharma@redhat.com] On Thu 02-07-20 08:00:27, Michal Hocko wrote: > On Thu 02-07-20 03:44:19, Bhupesh Sharma wrote: > > Prabhakar reported an OOPS inside mem_cgroup_get_nr_swap_pages() > > function in a corner case seen on some arm64 boards when kdump kernel > > runs with "cgroup_disable=memory" passed to the kdump kernel via > > bootargs. > > > > The root-cause behind the same is that currently mem_cgroup_swap_init() > > function is implemented as a subsys_initcall() call instead of a > > core_initcall(), this means 'cgroup_memory_noswap' still > > remains set to the default value (false) even when memcg is disabled via > > "cgroup_disable=memory" boot parameter. > > > > This may result in premature OOPS inside mem_cgroup_get_nr_swap_pages() > > function in corner cases: > > > > [ 0.265617] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000188 > > [ 0.274495] Mem abort info: > > [ 0.277311] ESR = 0x96000006 > > [ 0.280389] EC = 0x25: DABT (current EL), IL = 32 bits > > [ 0.285751] SET = 0, FnV = 0 > > [ 0.288830] EA = 0, S1PTW = 0 > > [ 0.291995] Data abort info: > > [ 0.294897] ISV = 0, ISS = 0x00000006 > > [ 0.298765] CM = 0, WnR = 0 > > [ 0.301757] [0000000000000188] user address but active_mm is swapper > > [ 0.308174] Internal error: Oops: 96000006 [#1] SMP > > [ 0.313097] Modules linked in: > > <..snip..> > > [ 0.331384] pstate: 00400009 (nzcv daif +PAN -UAO BTYPE=--) > > [ 0.337014] pc : mem_cgroup_get_nr_swap_pages+0x9c/0xf4 > > [ 0.342289] lr : mem_cgroup_get_nr_swap_pages+0x68/0xf4 > > [ 0.347564] sp : fffffe0012b6f800 > > [ 0.350905] x29: fffffe0012b6f800 x28: fffffe00116b3000 > > [ 0.356268] x27: fffffe0012b6fb00 x26: 0000000000000020 > > [ 0.361631] x25: 0000000000000000 x24: fffffc00723ffe28 > > [ 0.366994] x23: fffffe0010d5b468 x22: fffffe00116bfa00 > > [ 0.372357] x21: fffffe0010aabda8 x20: 0000000000000000 > > [ 0.377720] x19: 0000000000000000 x18: 0000000000000010 > > [ 0.383082] x17: 0000000043e612f2 x16: 00000000a9863ed7 > > [ 0.388445] x15: ffffffffffffffff x14: 202c303d70617773 > > [ 0.393808] x13: 6f6e5f79726f6d65 x12: 6d5f70756f726763 > > [ 0.399170] x11: 2073656761705f70 x10: 6177735f726e5f74 > > [ 0.404533] x9 : fffffe00100e9580 x8 : fffffe0010628160 > > [ 0.409895] x7 : 00000000000000a8 x6 : fffffe00118f5e5e > > [ 0.415258] x5 : 0000000000000001 x4 : 0000000000000000 > > [ 0.420621] x3 : 0000000000000000 x2 : 0000000000000000 > > [ 0.425983] x1 : 0000000000000000 x0 : fffffc0060079000 > > [ 0.431346] Call trace: > > [ 0.433809] mem_cgroup_get_nr_swap_pages+0x9c/0xf4 > > [ 0.438735] shrink_lruvec+0x404/0x4f8 > > [ 0.442516] shrink_node+0x1a8/0x688 > > [ 0.446121] do_try_to_free_pages+0xe8/0x448 > > [ 0.450429] try_to_free_pages+0x110/0x230 > > [ 0.454563] __alloc_pages_slowpath.constprop.106+0x2b8/0xb48 > > [ 0.460366] __alloc_pages_nodemask+0x2ac/0x2f8 > > [ 0.464938] alloc_page_interleave+0x20/0x90 > > [ 0.469246] alloc_pages_current+0xdc/0xf8 > > [ 0.473379] atomic_pool_expand+0x60/0x210 > > [ 0.477514] __dma_atomic_pool_init+0x50/0xa4 > > [ 0.481910] dma_atomic_pool_init+0xac/0x158 > > [ 0.486220] do_one_initcall+0x50/0x218 > > [ 0.490091] kernel_init_freeable+0x22c/0x2d0 > > [ 0.494489] kernel_init+0x18/0x110 > > [ 0.498007] ret_from_fork+0x10/0x18 > > [ 0.501614] Code: aa1403e3 91106000 97f82a27 14000011 (f940c663) > > [ 0.507770] ---[ end trace 9795948475817de4 ]--- > > [ 0.512429] Kernel panic - not syncing: Fatal exception > > [ 0.517705] Rebooting in 10 seconds.. > > > > Cc: Johannes Weiner > > Cc: Michal Hocko > > Cc: Vladimir Davydov > > Cc: James Morse > > Cc: Mark Rutland > > Cc: Will Deacon > > Cc: Catalin Marinas > > Cc: cgroups@vger.kernel.org > > Cc: linux-mm@kvack.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > Cc: kexec@lists.infradead.org > > Fixes: eccb52e78809 ("mm: memcontrol: prepare swap controller setup for integration") > > > Reported-by: Prabhakar Kushwaha > > Signed-off-by: Bhupesh Sharma > > This is subtle as hell, I have to say. I find the ordering in the init > calls very unintuitive and extremely hard to follow. The above commit > has introduced the problem but the code previously has worked mostly by > a luck because our default was flipped. > > Acked-by: Michal Hocko > > > --- > > mm/memcontrol.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 19622328e4b5..8323e4b7b390 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -7186,6 +7186,13 @@ static struct cftype memsw_files[] = { > > { }, /* terminate */ > > }; > > > > +/* > > + * If mem_cgroup_swap_init() is implemented as a subsys_initcall() > > + * instead of a core_initcall(), this could mean cgroup_memory_noswap still > > + * remains set to false even when memcg is disabled via "cgroup_disable=memory" > > + * boot parameter. This may result in premature OOPS inside > > + * mem_cgroup_get_nr_swap_pages() function in corner cases. > > + */ > > static int __init mem_cgroup_swap_init(void) > > { > > /* No memory control -> no swap control */ > > @@ -7200,6 +7207,6 @@ static int __init mem_cgroup_swap_init(void) > > > > return 0; > > } > > -subsys_initcall(mem_cgroup_swap_init); > > +core_initcall(mem_cgroup_swap_init); > > > > #endif /* CONFIG_MEMCG_SWAP */ > > -- > > 2.7.4 > > -- > Michal Hocko > SUSE Labs -- Michal Hocko SUSE Labs _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel