From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A6AC433DF for ; Fri, 3 Jul 2020 07:34:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9333320890 for ; Fri, 3 Jul 2020 07:34:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b+sxwk7V"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1e8LJIpi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9333320890 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3GyIQ1eB5pTAgOU2JVTuzFN4tMnvCxJQ48WNz/qN7xY=; b=b+sxwk7VTzA+p6Hs0DMW0Xpjv WuFrGwMDRi+uxOLMeRMiMzpA7rLe4fFFrxWhn5Ir4btfV0+pFSXJKaC4zOnpYUHj0xECOgNyHxZ6w jL3ImYnP94YxdYuB1eTGmTulrPEb5j8Ct5lnh+b6S4NgUnIwqCSZHJ9y1ZCxHBKBU1hV0u6OGH25p hXhMaX5oY/ARFlBR62VOd+yY4Pegw9+lFcC7ZRntzwIyq/SgPh2IcoB8HSyqM6h2FHv13ZinibZHT steP/9gREAS7EZGNvFFDDBLmAnMSFclQ/Mhkgfsa3eLhUIldbCG8FDIofb71vmrAlVuKax4r/ZWoF gdwDD3ldQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrGBv-0003EW-Rz; Fri, 03 Jul 2020 07:32:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrGBs-0003DZ-M2 for linux-arm-kernel@lists.infradead.org; Fri, 03 Jul 2020 07:32:57 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0EF2320890; Fri, 3 Jul 2020 07:32:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593761575; bh=YLzvaa1bLydJ+dj5X1a+vb6tk/OO1AZ6fTqSIeEFiRw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1e8LJIpiz+8KVyLRfSjDXioQMMpKWYIuR5wNf/uzr0CYSI1UKVVV3G5by0usGGe7S HwY+dBk5yCP8VJ5DJFZtj3b53OfjXKCmimssiC58i6fXHkK0VlIIXpfxIlRawYJJ02 BXzU7Xm0ye8DvrUyPvPA6dpx6cqHVZuKM1UlUeNM= Date: Fri, 3 Jul 2020 09:32:59 +0200 From: Greg KH To: Lee Jones Subject: Re: [PATCH 27/30] usb: class: cdc-wdm: Provide description for usb_cdc_wdm_register()'s manage_power arg Message-ID: <20200703073259.GA2335445@kroah.com> References: <20200702144625.2533530-1-lee.jones@linaro.org> <20200702144625.2533530-28-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200702144625.2533530-28-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200703_033256_809787_85D314E7 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Oliver Neukum Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 02, 2020 at 03:46:22PM +0100, Lee Jones wrote: > A good attempt was made to document everything else. > > Fixes the following W=1 kernel build warning(s): > > drivers/usb/class/cdc-wdm.c:961: warning: Function parameter or member 'manage_power' not described in 'usb_cdc_wdm_register' > > Cc: Oliver Neukum > Signed-off-by: Lee Jones > --- > drivers/usb/class/cdc-wdm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c > index e3db6fbeadef8..4dceaeca46e73 100644 > --- a/drivers/usb/class/cdc-wdm.c > +++ b/drivers/usb/class/cdc-wdm.c > @@ -940,7 +940,8 @@ static int wdm_probe(struct usb_interface *intf, const struct usb_device_id *id) > * @intf: usb interface the subdriver will associate with > * @ep: interrupt endpoint to monitor for notifications > * @bufsize: maximum message size to support for read/write > - * > + * @manage_power: call-back invoked during open and release to > + * manage the device's power > * Create WDM usb class character device and associate it with intf > * without binding, allowing another driver to manage the interface. > * You just added a coding style warning :( Hint, set your editor to flag trailing whitespace with a BIG RED COLOR so that you don't do that. If you use vim, that can be done with: highlight WhitespaceEOL ctermbg=red guibg=red match WhitespaceEOL /\s\+$/ in your .vimrc For other sane editors, I'm sure there are ways to do it as well. Please fix this patch up and send it in a new series, I've dropped it from this one. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel