From: Will Deacon <will@kernel.org>
To: Luis Machado <luis.machado@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Keno Fischer <keno@juliacomputing.com>,
kernel-team@android.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] arm64: Fix single-step handling
Date: Fri, 3 Jul 2020 12:49:46 +0100 [thread overview]
Message-ID: <20200703114945.GA18652@willie-the-truck> (raw)
In-Reply-To: <598bb1fd-c475-53b6-ef6a-bb2838f4be25@linaro.org>
Hi Luis,
On Fri, Jul 03, 2020 at 07:52:34AM -0300, Luis Machado wrote:
> On 7/2/20 6:26 PM, Will Deacon wrote:
> > This is version two of the patches I previously posted here:
> >
> > v1: https://lore.kernel.org/linux-arm-kernel/20200603151033.11512-1-will@kernel.org/
> >
> > Thanks to Keno for a bunch of helpful feedback on that, which has led to
> > the following major changes for v2:
> >
> > - Use pseudo-step traps for both entering a signal handler and exiting a
> > system call.
> >
> > - Document our weird x7 behaviour with PTRACE_SYSCALL.
> >
> > It has to be said that I'm a bit nervous about these changes. I played
> > around with GDB and things seemed ok, but I would really appreciate it
> > if Luis could run the GDB testsuite with these changes applied.
>
> Thanks for working on this. I'll need some time to give this a go. I'll let
> you know what the results are.
Brilliant, thank you.
> Do I only need to exercise the AArch64 state? Or would this impact AArch32
> as well?
I doubt AArch32 userspace goes very near PTRACE_SINGLESTEP, as it's not
supported by arch/arm/, so AArch64 testing should be sufficient.
Cheers,
Will
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-03 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 21:26 [PATCH v2 0/4] arm64: Fix single-step handling Will Deacon
2020-07-02 21:26 ` [PATCH v2 1/4] arm64: ptrace: Add a comment describing our syscall entry/exit trap ABI Will Deacon
2020-07-02 21:26 ` [PATCH v2 2/4] arm64: ptrace: Consistently use pseudo-singlestep exceptions Will Deacon
2020-07-10 14:02 ` Sasha Levin
2020-07-02 21:26 ` [PATCH v2 3/4] arm64: Override SPSR.SS when single-stepping is enabled Will Deacon
2020-07-10 14:02 ` Sasha Levin
2020-07-02 21:26 ` [PATCH v2 4/4] arm64: Use test_tsk_thread_flag() for checking TIF_SINGLESTEP Will Deacon
2020-07-03 10:52 ` [PATCH v2 0/4] arm64: Fix single-step handling Luis Machado
2020-07-03 11:49 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703114945.GA18652@willie-the-truck \
--to=will@kernel.org \
--cc=keno@juliacomputing.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=luis.machado@linaro.org \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).